Merge lp:~fluidity-core/fluidity/dont-install-diamond into lp:fluidity
| Status: | Merged |
|---|---|
| Merged at revision: | 3858 |
| Proposed branch: | lp:~fluidity-core/fluidity/dont-install-diamond |
| Merge into: | lp:fluidity |
| Diff against target: |
21 lines (+2/-2) 1 file modified
Makefile.in (+2/-2) |
| To merge this branch: | bzr merge lp:~fluidity-core/fluidity/dont-install-diamond |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Bond (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fluidity bundles libspud, as it needs it to build. libspud comes with Diamond, which also happened to be installed from the libspud/ directory to fluidity's bin/ directory as part of the building of libspud, but that was an unintended side-effect. linzhenhua reported a bug on the fluidity mailing list, that the version of Diamond installed in this process is broken, which is true; this was never detected because we always install Diamond separately.
This change makes it so that fluidity only installs the libspud and python binding components that are bundled in the libspud/ directory; i.e., diamond is no longer installed from libspud/ to fluidity's bin/. This should prevent any users getting confused about this in the future.
Aside: I wish bzr had actual externals support; the feature seems so easy, and yet it isn't available!
The fix looks good to me and the libspud/libspud.a rule works for me on a quick build test. I'm thinking it may be worth doing a bit of tidying of the libspud/ directory at some point too to remove un-needed code, and also small tidies like making the target in the makefile libspud.so as opposed to libspud.a, though this is unimportant to this merge.
Good to go; approve.