Code review comment for lp:~fluidity-core/fluidity/dont-install-diamond

Revision history for this message
Tim Bond (timothy-bond) wrote :

The fix looks good to me and the libspud/libspud.a rule works for me on a quick build test. I'm thinking it may be worth doing a bit of tidying of the libspud/ directory at some point too to remove un-needed code, and also small tidies like making the target in the makefile libspud.so as opposed to libspud.a, though this is unimportant to this merge.

Good to go; approve.

review: Approve

« Back to merge proposal