Merge lp:~fboudra/linaro-license-protection/set-write-permission-to-group into lp:~linaro-automation/linaro-license-protection/trunk

[Fathi Boudra]

Set write permission to the group (default umask is 022).

[Deepti B. Kalakeri (deeptik)]

On Wed, Apr 18, 2012 at 1:58 PM, Fathi Boudra <email address hidden>wrote:

> Fathi Boudra has proposed merging
> lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> Requested reviews:
> Linaro Infrastructure (linaro-infrastructure)
>
> For more details, see:
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
>
> Set write permission to the group (default umask is 022).
> --
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
> Your team Linaro Infrastructure is requested to review the proposed merge
> of lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> === modified file 'scripts/publish_to_snapshots.py'
> --- scripts/publish_to_snapshots.py 2012-04-17 15:49:20 +0000
> +++ scripts/publish_to_snapshots.py 2012-04-18 08:27:17 +0000
> @@ -189,6 +189,8 @@
> try:
> if not os.path.isdir(target_dir_path):
> os.makedirs(target_dir_path)
> + # Set write permission to the group as default umask is
> 022
> + os.chmod(target_dir_path, 0775)
>

Well this will set the group write permissions on the leaf directory only,
what about the top level directories.
We should make changes after the self.move_dir_content() is called, for
example by parsing till the top directory.

> if not os.path.isdir(target_dir_path):
> raise OSError
>
>
>
>

--
Thanks and Regards,
Deepti

[Deepti B. Kalakeri (deeptik)]

Well this will set the group write permissions on the leaf directory only, what about the top level directories.
We should make changes after the self.move_dir_content() is called, for example by parsing till the top directory.

Thanks!!!
Deepti.

review: Needs Fixing

[lp:~fboudra/linaro-license-protection/set-write-permission-to-group]

58. By Fathi Boudra on 2012-04-24

Merge trunk.

59. By Fathi Boudra on 2012-04-24

Set write permission to the group as default umask is 022.

[Deepti B. Kalakeri (deeptik)]

On Tue, Apr 24, 2012 at 3:08 PM, Fathi Boudra <email address hidden>wrote:

> You have been requested to review the proposed merge of
> lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> For more details, see:
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
>
> Set write permission to the group (default umask is 022).
>
> --
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
> You are requested to review the proposed merge of
> lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> === modified file 'scripts/publish_to_snapshots.py'
> --- scripts/publish_to_snapshots.py 2012-04-17 15:49:20 +0000
> +++ scripts/publish_to_snapshots.py 2012-04-24 09:36:21 +0000
> @@ -188,7 +188,9 @@
> def move_artifacts(self, args, build_dir_path, target_dir_path):
> try:
> if not os.path.isdir(target_dir_path):
> - os.makedirs(target_dir_path)
> + # Set write permission to the group as default umask is
> 022
> + os.umask(0)
> + os.makedirs(target_dir_path, 0775)
> if not os.path.isdir(target_dir_path):
> raise OSError
>
>
Looks good +1.

--
Thanks and Regards,
Deepti

=== modified file 'scripts/publish_to_snapshots.py'
--- scripts/publish_to_snapshots.py	2012-04-17 15:49:20 +0000
+++ scripts/publish_to_snapshots.py	2012-04-24 09:36:21 +0000
@@ -188,7 +188,9 @@
     def move_artifacts(self, args, build_dir_path, target_dir_path):
         try:
             if not os.path.isdir(target_dir_path):
-                os.makedirs(target_dir_path)
+                # Set write permission to the group as default umask is 022
+                os.umask(0)
+                os.makedirs(target_dir_path, 0775)
                 if not os.path.isdir(target_dir_path):
                     raise OSError