Code review comment for lp:~fboudra/linaro-license-protection/set-write-permission-to-group

On Tue, Apr 24, 2012 at 3:08 PM, Fathi Boudra <email address hidden>wrote:

> You have been requested to review the proposed merge of
> lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> For more details, see:
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
>
> Set write permission to the group (default umask is 022).
>
> --
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
> You are requested to review the proposed merge of
> lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> === modified file 'scripts/publish_to_snapshots.py'
> --- scripts/publish_to_snapshots.py 2012-04-17 15:49:20 +0000
> +++ scripts/publish_to_snapshots.py 2012-04-24 09:36:21 +0000
> @@ -188,7 +188,9 @@
> def move_artifacts(self, args, build_dir_path, target_dir_path):
> try:
> if not os.path.isdir(target_dir_path):
> - os.makedirs(target_dir_path)
> + # Set write permission to the group as default umask is
> 022
> + os.umask(0)
> + os.makedirs(target_dir_path, 0775)
> if not os.path.isdir(target_dir_path):
> raise OSError
>
>
Looks good +1.

--
Thanks and Regards,
Deepti