Code review comment for lp:~fboudra/linaro-license-protection/set-write-permission-to-group

On Wed, Apr 18, 2012 at 1:58 PM, Fathi Boudra <email address hidden>wrote:

> Fathi Boudra has proposed merging
> lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> Requested reviews:
> Linaro Infrastructure (linaro-infrastructure)
>
> For more details, see:
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
>
> Set write permission to the group (default umask is 022).
> --
>
> https://code.launchpad.net/~fboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456<https://code.launchpad.net/%7Efboudra/linaro-license-protection/set-write-permission-to-group/+merge/102456>
> Your team Linaro Infrastructure is requested to review the proposed merge
> of lp:~fboudra/linaro-license-protection/set-write-permission-to-group into
> lp:linaro-license-protection.
>
> === modified file 'scripts/publish_to_snapshots.py'
> --- scripts/publish_to_snapshots.py 2012-04-17 15:49:20 +0000
> +++ scripts/publish_to_snapshots.py 2012-04-18 08:27:17 +0000
> @@ -189,6 +189,8 @@
> try:
> if not os.path.isdir(target_dir_path):
> os.makedirs(target_dir_path)
> + # Set write permission to the group as default umask is
> 022
> + os.chmod(target_dir_path, 0775)
>

Well this will set the group write permissions on the leaf directory only,
what about the top level directories.
We should make changes after the self.move_dir_content() is called, for
example by parsing till the top directory.

> if not os.path.isdir(target_dir_path):
> raise OSError
>
>
>
>

--
Thanks and Regards,
Deepti