Merge lp:~dobey/unity8/processing-indterminate into lp:unity8

Proposed by dobey
Status: Superseded
Proposed branch: lp:~dobey/unity8/processing-indterminate
Merge into: lp:unity8
Prerequisite: lp:~dandrader/unity8/removeApplicationStage
Diff against target: 345 lines (+110/-20)
11 files modified
debian/control (+3/-1)
plugins/Ubuntu/DownloadDaemonListener/CMakeLists.txt (+3/-1)
plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.cpp (+2/-1)
plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.h (+2/-1)
plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.cpp (+2/-2)
plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.h (+71/-4)
plugins/Ubuntu/DownloadDaemonListener/interface/metatypes.h (+3/-6)
qml/Dash/Previews/PreviewProgress.qml (+5/-1)
tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.cpp (+3/-1)
tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.h (+2/-1)
tests/qmltests/Dash/Previews/tst_PreviewProgress.qml (+14/-1)
To merge this branch: bzr merge lp:~dobey/unity8/processing-indterminate
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Ubuntu Unity PS integration team packaging Pending
Review via email: mp+302318@code.launchpad.net

This proposal supersedes a proposal from 2016-07-14.

This proposal has been superseded by a proposal from 2016-09-02.

Commit message

Set progress bar indeterminate when processing signal received.

Description of the change

* Are there any related MPs required for this MP to build/function as expected?

No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes.

 * If you changed the UI, has there been a design review?

N/A

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2543
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1746/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2296/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2324
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2224
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2224
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2224
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2217/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2217/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1746/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2544
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1753/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2304/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2332
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2232
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2232
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2232
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2225/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2225/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1753/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2545
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1755/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2306/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2334
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2233
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2233
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2233
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2226/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1755/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2546
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1759/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2310/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2338
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2236
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2236
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2236
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2229/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2229/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1759/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2547
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1760/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2311
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1231
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1231
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1231
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2339
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2237
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2237
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2237
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2230/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2230
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2230/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1760/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

file:///home/tsdgeos_work/phablet/unity8/processing-indterminate/tests/qmltests/Dash/Previews/tst_PreviewProgress.qml:48:5: Type PreviewProgress unavailable
         PreviewProgress {
         ^
file:///home/tsdgeos_work/phablet/unity8/processing-indterminate/qml/Dash/Previews/PreviewProgress.qml:62:13: Cannot assign to non-existent property "onProcessing"
                 onProcessing: {

You need to update the mock DownloadTracker in tests/mocks/Ubuntu/DownloadDaemonListener/

review: Needs Fixing
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2550
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1790/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2344
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1252
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1252
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1252
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2372
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2258
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2258
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2258
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2251/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2251
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2251/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1790/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

previewProgress.progressBar doesn't exist, you need to use findChild as i suggested.

review: Needs Fixing
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2551
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1809/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2364
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1271
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1271
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1271
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2392
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2279
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2279
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2279
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2272/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2272
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2272/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1809/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2552
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1824/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2381
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1282
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1282
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1282
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2409
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2296
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2296
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2296
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2289/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2289
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2289/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1824/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

the tryCompare call is wrong, you need 3 params there

tryCompare(progressBar, "indeterminate", true);

review: Needs Fixing
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2553
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1836/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2394
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1294/console
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1294
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1294/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2422
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2309
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2309
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2309
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2302/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2302
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2302/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1836/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Have you shown this to someone in Design? In my opinion (which doesn't count much since i'm not in Design :D) this looks worse than just sticking at 100% for a few seconds more.

review: Needs Information
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2554
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1849/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2413
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1307
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1307
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1307
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2441
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2328
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2328
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2328
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2321/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2321
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2321/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1849/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) wrote : Posted in a previous version of this proposal

> Have you shown this to someone in Design? In my opinion (which doesn't count
> much since i'm not in Design :D) this looks worse than just sticking at 100%
> for a few seconds more.

I asked Paty to comment on the bug. FWIW, switching to indeterminate is also what Android does in the Play Store when download is finished and install starts. If the current result of that on Ubuntu "looks worse" as you say, then this seems like a problem with how indeterminate state is rendered, and thus a bug with UITK, and not this branch.

Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Ok, let's show it to the world and if they disagree we fix it later on.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Yes

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

Can you please resubmit with lp:~dandrader/unity8/removeApplicationStage as a prerequisite, they conflict in debian/control.

While at it, if you could please undo the two hunks where the generated file gained:

../../../../../../ubuntu-download-manager/trunk/docs/dbus/com.canonical.applications.download.xml

Or make those paths absolute, as appropriate, I'd be grateful.

Revision history for this message
dobey (dobey) wrote : Posted in a previous version of this proposal

> Can you please resubmit with lp:~dandrader/unity8/removeApplicationStage as a
> prerequisite, they conflict in debian/control.
>
> While at it, if you could please undo the two hunks where the generated file
> gained:
>
> ../../../../../../ubuntu-download-
> manager/trunk/docs/dbus/com.canonical.applications.download.xml
>
> Or make those paths absolute, as appropriate, I'd be grateful.

This is because the u-d-m packages do not include the dbus API definition xml files in the packages, and so the ../../../ mess is pointing to a checkout in my home directory. Full paths would not be helpful here, without the xml files being installed in the u-d-m packaging anywhere. I've filed bug #1611051 about this issue, so hopefully we can instead add a build rule to make this easier to maintain in the future, and it will have sensible paths in the generated code.

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2555
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1916/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2501/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2529
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2411
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2411
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2411
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2404/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2404/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1916/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) :
review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

Text conflict in debian/control
1 conflicts encountered.

review: Needs Fixing
2556. By dobey

[ Albert Astals Cid ]
* Take into account carousel selectedItemScaleFactor when setting card
  fixedArtShapeSize (LP: #1599238)
* Remove unused LimitProxyModel
* Do not calculate implicitHeight for Cards in a CardGrid
* Small clazy fixes
[ Daniel d'Andrada ]
* Remove stage property from Application
[ Larry Price ]
* Allow libertine-scope to show empty search result hint unmodified.
  (LP: #1606693)
[ Lukáš Tinkl ]
* Open the quicklist (context) menu also using the Menu key (LP:
  #1608265)
* Fix incorrect SIM PIN dialog position when entering a wrong PIN (LP:
  #1596076)
* Apply the correct keymap also on prompt surfaces (LP: #1610124)
* Implement an optional system update feature during OOBE wizard (LP:
  #1580785)
* Implement a page for choosing HW keyboard layout in OOBE wizard
[ Michael Zanetti ]
* Clean up some build script legacy
* Add a crossbuilder_post file to make crossbuilder restart unity8
  after deploying
* fixes for the automatic switching between usage modes (LP: #1590944)
[ Omer Akram ]
* Add object names for setup wizard
[ Albert Astals Cid ]
* Fix DisabledScreenNotice::test_rotation
* Make the delegate of DashNavigationList an async Loader
* unity-scope-tool: Use parse instead of process
* VerticalJournal improvements regarding model insertions and item
  height changes (LP: #1599754)
* Add math.h includes for compilation in yakkety (LP: #1605502)
[ Andrea Cimitan ]
* Unfocus the search text field in the dash page header when requested
  (LP: #1590820)
* Use binding for filter popover contentWidth (LP: #1595116)
* Add few sourceSize for Image we forgot (LP: #1595113)
* Replace Flickable with an Item inside DashPageHeader for
  headerContainer (LP: #1599235)
[ Albert Astals Cid, Andrea Cimitan ]
* Unbox the artshapeLoader
[ Daniel d'Andrada ]
* Fix splashscreen orientation when app rotates own contents (LP:
  #1586050)
* tst_PreviewIconActions: Make test name match filename
* Cursor: make its size grid unit based (LP: #1604014)
* TouchEventSequenceWrapper: item might get deleted when touch
  sequence is committed (LP: #1607686)
[ Lukáš Tinkl ]
* Implement frontend support for running keyboard indicator
* Provide window/surface close shortcuts across all the stages (LP:
  #1578392, #1606528)
* Restart the location trust prompt service when exiting the wizard
  (LP: #1594430)
* Implement clearing the search and closing the panel on pressing
  Escape key in the dash header
* Fix log timestamps (LP: #1602196)
* Don't display the mode switch warning dialog on tablets (LP:
  #1600290)
[ Michael Terry ]
* Fix indicator profile bug that caused sound indicator to say Mute
  instead of Silent Mode. (LP: #1604205)
* Fix lockscreen appearing right after unlocking a locked session on
  the desktop. (LP: #1604374)
[ Michał Sawicz ]
* Add arm64 support, drop unnecessary B-D on web plugin

Revision history for this message
Albert Astals Cid (aacid) wrote :

Merges fine again

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2556
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1989/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2608
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1423
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1423
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1423/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2636
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2515
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2515
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2515
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2509/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2509
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2509/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1989/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

2556. By dobey

[ Albert Astals Cid ]
* Take into account carousel selectedItemScaleFactor when setting card
  fixedArtShapeSize (LP: #1599238)
* Remove unused LimitProxyModel
* Do not calculate implicitHeight for Cards in a CardGrid
* Small clazy fixes
[ Daniel d'Andrada ]
* Remove stage property from Application
[ Larry Price ]
* Allow libertine-scope to show empty search result hint unmodified.
  (LP: #1606693)
[ Lukáš Tinkl ]
* Open the quicklist (context) menu also using the Menu key (LP:
  #1608265)
* Fix incorrect SIM PIN dialog position when entering a wrong PIN (LP:
  #1596076)
* Apply the correct keymap also on prompt surfaces (LP: #1610124)
* Implement an optional system update feature during OOBE wizard (LP:
  #1580785)
* Implement a page for choosing HW keyboard layout in OOBE wizard
[ Michael Zanetti ]
* Clean up some build script legacy
* Add a crossbuilder_post file to make crossbuilder restart unity8
  after deploying
* fixes for the automatic switching between usage modes (LP: #1590944)
[ Omer Akram ]
* Add object names for setup wizard
[ Albert Astals Cid ]
* Fix DisabledScreenNotice::test_rotation
* Make the delegate of DashNavigationList an async Loader
* unity-scope-tool: Use parse instead of process
* VerticalJournal improvements regarding model insertions and item
  height changes (LP: #1599754)
* Add math.h includes for compilation in yakkety (LP: #1605502)
[ Andrea Cimitan ]
* Unfocus the search text field in the dash page header when requested
  (LP: #1590820)
* Use binding for filter popover contentWidth (LP: #1595116)
* Add few sourceSize for Image we forgot (LP: #1595113)
* Replace Flickable with an Item inside DashPageHeader for
  headerContainer (LP: #1599235)
[ Albert Astals Cid, Andrea Cimitan ]
* Unbox the artshapeLoader
[ Daniel d'Andrada ]
* Fix splashscreen orientation when app rotates own contents (LP:
  #1586050)
* tst_PreviewIconActions: Make test name match filename
* Cursor: make its size grid unit based (LP: #1604014)
* TouchEventSequenceWrapper: item might get deleted when touch
  sequence is committed (LP: #1607686)
[ Lukáš Tinkl ]
* Implement frontend support for running keyboard indicator
* Provide window/surface close shortcuts across all the stages (LP:
  #1578392, #1606528)
* Restart the location trust prompt service when exiting the wizard
  (LP: #1594430)
* Implement clearing the search and closing the panel on pressing
  Escape key in the dash header
* Fix log timestamps (LP: #1602196)
* Don't display the mode switch warning dialog on tablets (LP:
  #1600290)
[ Michael Terry ]
* Fix indicator profile bug that caused sound indicator to say Mute
  instead of Silent Mode. (LP: #1604205)
* Fix lockscreen appearing right after unlocking a locked session on
  the desktop. (LP: #1604374)
[ Michał Sawicz ]
* Add arm64 support, drop unnecessary B-D on web plugin

2555. By dobey

Merged dandrader's branch.

2554. By dobey

[ Zoltán Balogh ]
* Bump the version to secure UITK compatibility
[ Albert Astals Cid ]
* Pass the correct number of arguments to mapToItem (LP: #1606835)
* Rebuild against Qt 5.6.
* Add https://code.launchpad.net/~aacid/unity8/floor_includes/+merge/300850

2553. By dobey

tryCompare is apparently inconsistent with Compare.

2552. By dobey

Update copyright years in chagned files.
Do a second findChild in the test.

2551. By dobey

Use findChild instead.

2550. By dobey

[ Daniel d'Andrada ]
Make use of MirSurface::inputBounds and drop UbuntuKeyboardInfo hack

2549. By dobey

Processing doesn't call root triggered signal.

2548. By dobey

Update the tests too.

2547. By dobey

The whitespace test is awful.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-08-11 06:26:26 +0000
3+++ debian/control 2016-08-19 13:10:13 +0000
4@@ -11,9 +11,9 @@
5 # to g++ so we don't try to run arm g++
6 # on an x86 CPU for example, when cross-compiling.
7 g++:native,
8- libandroid-properties-dev,
9 graphviz,
10 gsettings-ubuntu-schemas (>= 0.0.2+14.10.20140815),
11+ libandroid-properties-dev,
12 libconnectivity-qt1-dev (>= 0.7.1),
13 libevdev-dev,
14 libgeonames-dev (>= 0.2),
15@@ -32,9 +32,11 @@
16 libqt5svg5-dev,
17 libqt5xmlpatterns5-dev,
18 libsystemsettings-dev,
19+ libubuntu-download-manager-common-dev,
20 libubuntugestures5-dev (>= 1.3.2030),
21 libubuntugestures5-private-dev (>= 1.3.2030),
22 libudev-dev,
23+ libudm-common-dev,
24 libunity-api-dev (>= 7.117),
25 libusermetricsoutput1-dev,
26 # Need those X11 libs touch emulation from mouse events in manual QML tests on a X11 desktop
27
28=== modified file 'plugins/Ubuntu/DownloadDaemonListener/CMakeLists.txt'
29--- plugins/Ubuntu/DownloadDaemonListener/CMakeLists.txt 2016-06-02 09:32:33 +0000
30+++ plugins/Ubuntu/DownloadDaemonListener/CMakeLists.txt 2016-08-19 13:10:13 +0000
31@@ -12,5 +12,7 @@
32 add_library(DownloadDaemonListener MODULE ${DOWNLOADDAEMONLISTENER_SOURCES})
33
34 qt5_use_modules(DownloadDaemonListener Qml Quick DBus Core)
35-
36+pkg_check_modules(DDLADAPTER REQUIRED udm-common)
37+add_definitions(${DDLADAPTER_CFLAGS} ${DDLADAPTER_CFLAGS_OTHER})
38+target_link_libraries(DownloadDaemonListener ${DDLADAPTER_LIBRARIES})
39 add_unity8_plugin(Ubuntu.DownloadDaemonListener 0.1 Ubuntu/DownloadDaemonListener TARGETS DownloadDaemonListener)
40
41=== modified file 'plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.cpp'
42--- plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.cpp 2015-08-19 13:56:21 +0000
43+++ plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.cpp 2016-08-19 13:10:13 +0000
44@@ -1,5 +1,5 @@
45 /*
46- * Copyright (C) 2013 - Canonical Ltd.
47+ * Copyright (C) 2013-2016 Canonical Ltd.
48 *
49 * This program is free software: you can redistribute it and/or modify it
50 * under the terms of the GNU Lesser General Public License, as
51@@ -78,6 +78,7 @@
52 connect(m_adaptor, static_cast<void (DownloadTrackerAdaptor::*)(qulonglong, qulonglong)>(&DownloadTrackerAdaptor::progress), this, &DownloadTracker::progress);
53 connect(m_adaptor, &DownloadTrackerAdaptor::resumed, this, &DownloadTracker::resumed);
54 connect(m_adaptor, &DownloadTrackerAdaptor::started, this, &DownloadTracker::started);
55+ connect(m_adaptor, &DownloadTrackerAdaptor::processing, this, &DownloadTracker::processing);
56 }
57 // FIXME find a better way of determining if the service is ready
58 Q_EMIT serviceReadyChanged(m_adaptor && m_adaptor->isValid());
59
60=== modified file 'plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.h'
61--- plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.h 2015-11-20 15:01:39 +0000
62+++ plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.h 2016-08-19 13:10:13 +0000
63@@ -1,5 +1,5 @@
64 /*
65- * Copyright (C) 2013 - Canonical Ltd.
66+ * Copyright (C) 2013-2016 Canonical Ltd.
67 *
68 * This program is free software: you can redistribute it and/or modify it
69 * under the terms of the GNU Lesser General Public License, as
70@@ -54,6 +54,7 @@
71 void error(const QString &error);
72 void finished(const QString &path);
73 void paused(bool success);
74+ void processing(const QString &path);
75 void progress(qulonglong received, qulonglong total);
76 void resumed(bool success);
77 void started(bool success);
78
79=== modified file 'plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.cpp'
80--- plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.cpp 2013-07-24 14:18:23 +0000
81+++ plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.cpp 2016-08-19 13:10:13 +0000
82@@ -1,8 +1,8 @@
83 /*
84 * This file was generated by qdbusxml2cpp version 0.8
85- * Command line was: qdbusxml2cpp -v -c DownloadTrackerAdaptor -p downloadtrackeradaptor.h:downloadtrackeradaptor.cpp -i metatypes.h com.canonical.applications.download.xml
86+ * Command line was: qdbusxml2cpp -v -c DownloadTrackerAdaptor -p downloadtrackeradaptor.h:downloadtrackeradaptor.cpp -i metatypes.h ../../../../../../ubuntu-download-manager/trunk/docs/dbus/com.canonical.applications.download.xml
87 *
88- * qdbusxml2cpp is Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
89+ * qdbusxml2cpp is Copyright (C) 2015 The Qt Company Ltd.
90 *
91 * This is an auto-generated file.
92 * This file may have been hand-edited. Look for HAND-EDIT comments
93
94=== modified file 'plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.h'
95--- plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.h 2015-09-14 09:11:08 +0000
96+++ plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.h 2016-08-19 13:10:13 +0000
97@@ -1,15 +1,15 @@
98 /*
99 * This file was generated by qdbusxml2cpp version 0.8
100- * Command line was: qdbusxml2cpp -v -c DownloadTrackerAdaptor -p downloadtrackeradaptor.h:downloadtrackeradaptor.cpp -i metatypes.h com.canonical.applications.download.xml
101+ * Command line was: qdbusxml2cpp -v -c DownloadTrackerAdaptor -p downloadtrackeradaptor.h:downloadtrackeradaptor.cpp -i metatypes.h ../../../../../../ubuntu-download-manager/trunk/docs/dbus/com.canonical.applications.download.xml
102 *
103- * qdbusxml2cpp is Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
104+ * qdbusxml2cpp is Copyright (C) 2015 The Qt Company Ltd.
105 *
106 * This is an auto-generated file.
107 * Do not edit! All changes made to it will be lost.
108 */
109
110-#ifndef DOWNLOADTRACKERADAPTOR_H_1374434371
111-#define DOWNLOADTRACKERADAPTOR_H_1374434371
112+#ifndef DOWNLOADTRACKERADAPTOR_H
113+#define DOWNLOADTRACKERADAPTOR_H
114
115 #include <QtCore/QObject>
116 #include <QtCore/QByteArray>
117@@ -36,6 +36,22 @@
118
119 ~DownloadTrackerAdaptor();
120
121+ Q_PROPERTY(QString ClickPackage READ clickPackage)
122+ inline QString clickPackage() const
123+ { return qvariant_cast< QString >(property("ClickPackage")); }
124+
125+ Q_PROPERTY(QString DestinationApp READ destinationApp)
126+ inline QString destinationApp() const
127+ { return qvariant_cast< QString >(property("DestinationApp")); }
128+
129+ Q_PROPERTY(bool ShowInIndicator READ showInIndicator)
130+ inline bool showInIndicator() const
131+ { return qvariant_cast< bool >(property("ShowInIndicator")); }
132+
133+ Q_PROPERTY(QString Title READ title)
134+ inline QString title() const
135+ { return qvariant_cast< QString >(property("Title")); }
136+
137 public Q_SLOTS: // METHODS
138 inline QDBusPendingReply<> allowGSMDownload(bool allowed)
139 {
140@@ -50,6 +66,24 @@
141 return asyncCallWithArgumentList(QStringLiteral("cancel"), argumentList);
142 }
143
144+ inline QDBusPendingReply<> collected()
145+ {
146+ QList<QVariant> argumentList;
147+ return asyncCallWithArgumentList(QStringLiteral("collected"), argumentList);
148+ }
149+
150+ inline QDBusPendingReply<QString> filePath()
151+ {
152+ QList<QVariant> argumentList;
153+ return asyncCallWithArgumentList(QStringLiteral("filePath"), argumentList);
154+ }
155+
156+ inline QDBusPendingReply<StringMap> headers()
157+ {
158+ QList<QVariant> argumentList;
159+ return asyncCallWithArgumentList(QStringLiteral("headers"), argumentList);
160+ }
161+
162 inline QDBusPendingReply<bool> isGSMDownloadAllowed()
163 {
164 QList<QVariant> argumentList;
165@@ -80,6 +114,27 @@
166 return asyncCallWithArgumentList(QStringLiteral("resume"), argumentList);
167 }
168
169+ inline QDBusPendingReply<> setDestinationDir(const QString &path)
170+ {
171+ QList<QVariant> argumentList;
172+ argumentList << QVariant::fromValue(path);
173+ return asyncCallWithArgumentList(QStringLiteral("setDestinationDir"), argumentList);
174+ }
175+
176+ inline QDBusPendingReply<> setHeaders(StringMap headers)
177+ {
178+ QList<QVariant> argumentList;
179+ argumentList << QVariant::fromValue(headers);
180+ return asyncCallWithArgumentList(QStringLiteral("setHeaders"), argumentList);
181+ }
182+
183+ inline QDBusPendingReply<> setMetadata(const QVariantMap &data)
184+ {
185+ QList<QVariant> argumentList;
186+ argumentList << QVariant::fromValue(data);
187+ return asyncCallWithArgumentList(QStringLiteral("setMetadata"), argumentList);
188+ }
189+
190 inline QDBusPendingReply<> setThrottle(qulonglong speed)
191 {
192 QList<QVariant> argumentList;
193@@ -93,6 +148,12 @@
194 return asyncCallWithArgumentList(QStringLiteral("start"), argumentList);
195 }
196
197+ inline QDBusPendingReply<int> state()
198+ {
199+ QList<QVariant> argumentList;
200+ return asyncCallWithArgumentList(QStringLiteral("state"), argumentList);
201+ }
202+
203 inline QDBusPendingReply<qulonglong> throttle()
204 {
205 QList<QVariant> argumentList;
206@@ -106,10 +167,16 @@
207 }
208
209 Q_SIGNALS: // SIGNALS
210+ void authError(AuthErrorStruct error);
211 void canceled(bool success);
212 void error(const QString &error);
213 void finished(const QString &path);
214+ void hashError(HashErrorStruct error);
215+ void httpError(HttpErrorStruct error);
216+ void networkError(NetworkErrorStruct error);
217 void paused(bool success);
218+ void processError(ProcessErrorStruct error);
219+ void processing(const QString &path);
220 void progress(qulonglong received, qulonglong total);
221 void resumed(bool success);
222 void started(bool success);
223
224=== modified file 'plugins/Ubuntu/DownloadDaemonListener/interface/metatypes.h'
225--- plugins/Ubuntu/DownloadDaemonListener/interface/metatypes.h 2013-07-24 14:18:23 +0000
226+++ plugins/Ubuntu/DownloadDaemonListener/interface/metatypes.h 2016-08-19 13:10:13 +0000
227@@ -1,5 +1,5 @@
228 /*
229- * Copyright 2013 2013 Canonical Ltd.
230+ * Copyright 2013-2016 Canonical Ltd.
231 *
232 * This library is free software; you can redistribute it and/or
233 * modify it under the terms of version 3 of the GNU Lesser General Public
234@@ -19,10 +19,7 @@
235 #ifndef DOWNLOADER_LIB_APP_METATYPES_H
236 #define DOWNLOADER_LIB_APP_METATYPES_H
237
238-#include <QMap>
239-
240-typedef QMap<QString, QString> StringMap;
241-
242-Q_DECLARE_METATYPE(StringMap)
243+// Just include the system file so we're always up to date.
244+#include <ubuntu/download_manager/metatypes.h>
245
246 #endif // METATYPES_H
247
248=== modified file 'qml/Dash/Previews/PreviewProgress.qml'
249--- qml/Dash/Previews/PreviewProgress.qml 2015-07-15 15:07:19 +0000
250+++ qml/Dash/Previews/PreviewProgress.qml 2016-08-19 13:10:13 +0000
251@@ -1,5 +1,5 @@
252 /*
253- * Copyright (C) 2014 Canonical, Ltd.
254+ * Copyright (C) 2014-2016 Canonical, Ltd.
255 *
256 * This program is free software; you can redistribute it and/or modify
257 * it under the terms of the GNU General Public License as published by
258@@ -59,6 +59,10 @@
259 }
260 }
261
262+ onProcessing: {
263+ progressBar.indeterminate = true;
264+ }
265+
266 onFinished: {
267 root.triggered(widgetId, "finished", widgetData)
268 }
269
270=== modified file 'tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.cpp'
271--- tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.cpp 2013-09-25 19:58:58 +0000
272+++ tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.cpp 2016-08-19 13:10:13 +0000
273@@ -1,5 +1,5 @@
274 /*
275- * Copyright (C) 2013 - Canonical Ltd.
276+ * Copyright (C) 2013-2016 Canonical Ltd.
277 *
278 * This program is free software: you can redistribute it and/or modify it
279 * under the terms of the GNU Lesser General Public License, as
280@@ -67,6 +67,8 @@
281 Q_EMIT finished("downloadComplete");
282 }else if(m_dbusPath == "error") {
283 Q_EMIT error("DOWNLOAD ERROR");
284+ }else if(m_dbusPath == "processing") {
285+ Q_EMIT processing(m_dbusPath);
286 }
287 }
288 }
289
290=== modified file 'tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.h'
291--- tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.h 2013-08-13 08:50:50 +0000
292+++ tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.h 2016-08-19 13:10:13 +0000
293@@ -1,5 +1,5 @@
294 /*
295- * Copyright (C) 2013 - Canonical Ltd.
296+ * Copyright (C) 2013-2016 Canonical Ltd.
297 *
298 * This program is free software: you can redistribute it and/or modify it
299 * under the terms of the GNU Lesser General Public License, as
300@@ -51,6 +51,7 @@
301 void error(const QString &error);
302 void finished(const QString &path);
303 void paused(bool success);
304+ void processing(const QString &path);
305 void progress(qulonglong received, qulonglong total);
306 void resumed(bool success);
307 void started(bool success);
308
309=== modified file 'tests/qmltests/Dash/Previews/tst_PreviewProgress.qml'
310--- tests/qmltests/Dash/Previews/tst_PreviewProgress.qml 2015-07-15 15:07:19 +0000
311+++ tests/qmltests/Dash/Previews/tst_PreviewProgress.qml 2016-08-19 13:10:13 +0000
312@@ -1,5 +1,5 @@
313 /*
314- * Copyright 2014 Canonical Ltd.
315+ * Copyright 2014-2016 Canonical Ltd.
316 *
317 * This program is free software; you can redistribute it and/or modify
318 * it under the terms of the GNU General Public License as published by
319@@ -40,6 +40,11 @@
320 "source": { "dbus-name" : "somename", "dbus-object": "error" }
321 }
322
323+ property var progressjsonProcessing: {
324+ "type": "progress",
325+ "source": { "dbus-name" : "somename", "dbus-object": "processing" }
326+ }
327+
328 SignalSpy {
329 id: spy
330 signalName: "triggered"
331@@ -82,6 +87,14 @@
332 compare(args[0], "previewProgress");
333 compare(args[1], "failed");
334 compare(args[2], progressjsonError);
335+
336+ spy.clear();
337+
338+ var progressBar = findChild(previewProgress, "progressBar");
339+ compare(progressBar.indeterminate, false);
340+ previewProgress.widgetData = progressjsonProcessing;
341+ progressBar = findChild(previewProgress, "progressBar");
342+ tryCompare(progressBar, "indeterminate", true);
343 }
344 }
345 }

Subscribers

People subscribed via source and target branches