lp:~dandrader/unity8/removeApplicationStage

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity8 at revision 2592

Michał Sawicz: Approve on 2016-08-10

Unity8 CI Bot: Needs Fixing (continuous-integration) on 2016-08-02

Gerry Boland (community): Needs Fixing on 2016-07-29

Diff: 294 lines (+35/-42)

10 files modified

CMakeLists.txt (+1/-1)
debian/control (+3/-3)
qml/Stages/TabletStage.qml (+1/-1)
tests/mocks/Unity/Application/ApplicationInfo.cpp (+0/-8)
tests/mocks/Unity/Application/ApplicationInfo.h (+0/-4)
tests/mocks/Unity/Application/ApplicationManager.cpp (+0/-10)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+0/-2)
tests/qmltests/Stages/tst_TabletStage.qml (+6/-3)
tests/qmltests/tst_OrientedShell.qml (+10/-6)
tests/qmltests/tst_Shell.qml (+14/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2549. By Daniel d'Andrada on 2016-08-02

Update tests

2548. By Daniel d'Andrada on 2016-07-25

Remove stage property from Application

It's not used anymore

2547. By Launchpad Translations on behalf of unity-team on 2016-07-25

Launchpad automatic translations update.

2546. By Launchpad Translations on behalf of unity-team on 2016-07-22

Launchpad automatic translations update.

2545. By CI Train Bot Account on 2016-07-21

Resync trunk.

2544. By CI Train Bot Account on 2016-07-14

Releasing 8.13+16.10.20160714-0ubuntu1

2543. By CI Train Bot Account on 2016-07-14

Make use of MirSurface::inputBounds and drop UbuntuKeyboardInfo hack

2542. By Launchpad Translations on behalf of unity-team on 2016-07-14

Launchpad automatic translations update.

2541. By CI Train Bot Account on 2016-07-11

Releasing 8.12+16.10.20160711-0ubuntu1

2540. By Michael Terry on 2016-07-11

Fix tablet greeter focus to be always-on, no longer hiding the OSK or forcing a mouse click to type a password.

I've also squeezed some other small fixes in:

- Support Up and Down keys in user list.
- Don't accept non-digit characters when prompting for passcode (we ask OSK to show only digits, but due to bug 1586435, it shows other characters too; plus if the user has an external keyboard, they can type anything anyway).
- When prompting for a passcode in wide-view (tablet/desktop), stop at 4 digits just like we do in narrow-view.
- Don't show "Retry" during brief period before a prompt comes in from PAM.
- Don't let user drag user list if there's only one entry.

Now as for the focus changes...

One of the big reasons we lost keyboard focus before was because we set the shell to disabled whenever the greeter was "between PAM events" -- mostly so that the user can't swipe away greeter before we get our first prompt or are otherwise unsure about exactly what authentication is needed.

But disabled qml items can't be focused. So I've rejiggered things a bit. Instead of disabling the whole shell, I just disable the launcher, the indicators, and make the greeter non-swipeable.

I also do some tricks with the prompt so that it looks disabled (while we check with PAM about the password) but isn't actually. I don't want to make it look to the user that pressing backspace while they wait for PAM does anything, so after the user presses Enter, I present a fake label on top of the prompt that looks like a disabled prompt, while simultaneously hiding the prompt contents. (LP: #1435923)