Code review comment for lp:~dobey/unity8/processing-indterminate

Revision history for this message
dobey (dobey) wrote :

> Can you please resubmit with lp:~dandrader/unity8/removeApplicationStage as a
> prerequisite, they conflict in debian/control.
>
> While at it, if you could please undo the two hunks where the generated file
> gained:
>
> ../../../../../../ubuntu-download-
> manager/trunk/docs/dbus/com.canonical.applications.download.xml
>
> Or make those paths absolute, as appropriate, I'd be grateful.

This is because the u-d-m packages do not include the dbus API definition xml files in the packages, and so the ../../../ mess is pointing to a checkout in my home directory. Full paths would not be helpful here, without the xml files being installed in the u-d-m packaging anywhere. I've filed bug #1611051 about this issue, so hopefully we can instead add a build rule to make this easier to maintain in the future, and it will have sensible paths in the generated code.

« Back to merge proposal