Merge lp:~dobey/unity8/processing-indterminate into lp:unity8
| Status: | Superseded |
|---|---|
| Proposed branch: | lp:~dobey/unity8/processing-indterminate |
| Merge into: | lp:unity8 |
| Diff against target: |
629 lines (+145/-62) 20 files modified
CMakeLists.txt (+1/-1) debian/control (+6/-4) plugins/Ubuntu/DownloadDaemonListener/CMakeLists.txt (+3/-1) plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.cpp (+2/-1) plugins/Ubuntu/DownloadDaemonListener/DownloadTracker.h (+2/-1) plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.cpp (+2/-2) plugins/Ubuntu/DownloadDaemonListener/interface/downloadtrackeradaptor.h (+71/-4) plugins/Ubuntu/DownloadDaemonListener/interface/metatypes.h (+3/-6) qml/Dash/Previews/PreviewProgress.qml (+5/-1) qml/Stages/TabletStage.qml (+1/-1) tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.cpp (+3/-1) tests/mocks/Ubuntu/DownloadDaemonListener/MockDownloadTracker.h (+2/-1) tests/mocks/Unity/Application/ApplicationInfo.cpp (+0/-8) tests/mocks/Unity/Application/ApplicationInfo.h (+0/-4) tests/mocks/Unity/Application/ApplicationManager.cpp (+0/-10) tests/plugins/Unity/Launcher/launchermodeltest.cpp (+0/-2) tests/qmltests/Dash/Previews/tst_PreviewProgress.qml (+14/-1) tests/qmltests/Stages/tst_TabletStage.qml (+6/-3) tests/qmltests/tst_OrientedShell.qml (+10/-6) tests/qmltests/tst_Shell.qml (+14/-4) |
| To merge this branch: | bzr merge lp:~dobey/unity8/processing-indterminate |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | 2016-07-14 | Approve on 2016-08-08 | |
| Unity8 CI Bot | continuous-integration | Needs Fixing on 2016-07-29 | |
| Ubuntu Unity PS integration team | packaging | 2016-07-22 | Pending |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2016-08-08.
Commit Message
Set progress bar indeterminate when processing signal received.
Description of the Change
* Are there any related MPs required for this MP to build/function as expected?
No.
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes.
* If you changed the UI, has there been a design review?
N/A
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2543
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2544
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2545
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2546
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2547
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
file://
^
file://
You need to update the mock DownloadTracker in tests/mocks/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2548
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2549
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2550
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
previewProgress
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2551
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2552
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
the tryCompare call is wrong, you need 3 params there
tryCompare(
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2553
https:/
Executed test runs:
SUCCESS: https:/
FAILURE: https:/
UNSTABLE: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
Have you shown this to someone in Design? In my opinion (which doesn't count much since i'm not in Design :D) this looks worse than just sticking at 100% for a few seconds more.
- 2554. By dobey on 2016-07-29
-
[ Zoltán Balogh ]
* Bump the version to secure UITK compatibility
[ Albert Astals Cid ]
* Pass the correct number of arguments to mapToItem (LP: #1606835)
* Rebuild against Qt 5.6.
* Add https://code.launchpad .net/~aacid/ unity8/ floor_includes/ +merge/ 300850
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2554
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
SUCCESS: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| dobey (dobey) wrote : | # |
> Have you shown this to someone in Design? In my opinion (which doesn't count
> much since i'm not in Design :D) this looks worse than just sticking at 100%
> for a few seconds more.
I asked Paty to comment on the bug. FWIW, switching to indeterminate is also what Android does in the Play Store when download is finished and install starts. If the current result of that on Ubuntu "looks worse" as you say, then this seems like a problem with how indeterminate state is rendered, and thus a bug with UITK, and not this branch.
| Albert Astals Cid (aacid) wrote : | # |
Ok, let's show it to the world and if they disagree we fix it later on.
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Yes
| Michał Sawicz (saviq) wrote : | # |
Can you please resubmit with lp:~dandrader/unity8/removeApplicationStage as a prerequisite, they conflict in debian/control.
While at it, if you could please undo the two hunks where the generated file gained:
../../.
Or make those paths absolute, as appropriate, I'd be grateful.
| dobey (dobey) wrote : | # |
> Can you please resubmit with lp:~dandrader/unity8/removeApplicationStage as a
> prerequisite, they conflict in debian/control.
>
> While at it, if you could please undo the two hunks where the generated file
> gained:
>
> ../../.
> manager/
>
> Or make those paths absolute, as appropriate, I'd be grateful.
This is because the u-d-m packages do not include the dbus API definition xml files in the packages, and so the ../../../ mess is pointing to a checkout in my home directory. Full paths would not be helpful here, without the xml files being installed in the u-d-m packaging anywhere. I've filed bug #1611051 about this issue, so hopefully we can instead add a build rule to make this easier to maintain in the future, and it will have sensible paths in the generated code.
- 2555. By dobey on 2016-08-08
-
Merged dandrader's branch.
- 2556. By dobey on 2016-08-19
-
[ Albert Astals Cid ]
* Take into account carousel selectedItemScaleFactor when setting card
fixedArtShapeSize (LP: #1599238)
* Remove unused LimitProxyModel
* Do not calculate implicitHeight for Cards in a CardGrid
* Small clazy fixes
[ Daniel d'Andrada ]
* Remove stage property from Application
[ Larry Price ]
* Allow libertine-scope to show empty search result hint unmodified.
(LP: #1606693)
[ Lukáš Tinkl ]
* Open the quicklist (context) menu also using the Menu key (LP:
#1608265)
* Fix incorrect SIM PIN dialog position when entering a wrong PIN (LP:
#1596076)
* Apply the correct keymap also on prompt surfaces (LP: #1610124)
* Implement an optional system update feature during OOBE wizard (LP:
#1580785)
* Implement a page for choosing HW keyboard layout in OOBE wizard
[ Michael Zanetti ]
* Clean up some build script legacy
* Add a crossbuilder_post file to make crossbuilder restart unity8
after deploying
* fixes for the automatic switching between usage modes (LP: #1590944)
[ Omer Akram ]
* Add object names for setup wizard
[ Albert Astals Cid ]
* Fix DisabledScreenNotice:: test_rotation
* Make the delegate of DashNavigationList an async Loader
* unity-scope-tool: Use parse instead of process
* VerticalJournal improvements regarding model insertions and item
height changes (LP: #1599754)
* Add math.h includes for compilation in yakkety (LP: #1605502)
[ Andrea Cimitan ]
* Unfocus the search text field in the dash page header when requested
(LP: #1590820)
* Use binding for filter popover contentWidth (LP: #1595116)
* Add few sourceSize for Image we forgot (LP: #1595113)
* Replace Flickable with an Item inside DashPageHeader for
headerContainer (LP: #1599235)
[ Albert Astals Cid, Andrea Cimitan ]
* Unbox the artshapeLoader
[ Daniel d'Andrada ]
* Fix splashscreen orientation when app rotates own contents (LP:
#1586050)
* tst_PreviewIconActions: Make test name match filename
* Cursor: make its size grid unit based (LP: #1604014)
* TouchEventSequenceWrapper: item might get deleted when touch
sequence is committed (LP: #1607686)
[ Lukáš Tinkl ]
* Implement frontend support for running keyboard indicator
* Provide window/surface close shortcuts across all the stages (LP:
#1578392, #1606528)
* Restart the location trust prompt service when exiting the wizard
(LP: #1594430)
* Implement clearing the search and closing the panel on pressing
Escape key in the dash header
* Fix log timestamps (LP: #1602196)
* Don't display the mode switch warning dialog on tablets (LP:
#1600290)
[ Michael Terry ]
* Fix indicator profile bug that caused sound indicator to say Mute
instead of Silent Mode. (LP: #1604205)
* Fix lockscreen appearing right after unlocking a locked session on
the desktop. (LP: #1604374)
[ Michał Sawicz ]
* Add arm64 support, drop unnecessary B-D on web plugin
Unmerged revisions
- 2556. By dobey on 2016-08-19
-
[ Albert Astals Cid ]
* Take into account carousel selectedItemScaleFactor when setting card
fixedArtShapeSize (LP: #1599238)
* Remove unused LimitProxyModel
* Do not calculate implicitHeight for Cards in a CardGrid
* Small clazy fixes
[ Daniel d'Andrada ]
* Remove stage property from Application
[ Larry Price ]
* Allow libertine-scope to show empty search result hint unmodified.
(LP: #1606693)
[ Lukáš Tinkl ]
* Open the quicklist (context) menu also using the Menu key (LP:
#1608265)
* Fix incorrect SIM PIN dialog position when entering a wrong PIN (LP:
#1596076)
* Apply the correct keymap also on prompt surfaces (LP: #1610124)
* Implement an optional system update feature during OOBE wizard (LP:
#1580785)
* Implement a page for choosing HW keyboard layout in OOBE wizard
[ Michael Zanetti ]
* Clean up some build script legacy
* Add a crossbuilder_post file to make crossbuilder restart unity8
after deploying
* fixes for the automatic switching between usage modes (LP: #1590944)
[ Omer Akram ]
* Add object names for setup wizard
[ Albert Astals Cid ]
* Fix DisabledScreenNotice:: test_rotation
* Make the delegate of DashNavigationList an async Loader
* unity-scope-tool: Use parse instead of process
* VerticalJournal improvements regarding model insertions and item
height changes (LP: #1599754)
* Add math.h includes for compilation in yakkety (LP: #1605502)
[ Andrea Cimitan ]
* Unfocus the search text field in the dash page header when requested
(LP: #1590820)
* Use binding for filter popover contentWidth (LP: #1595116)
* Add few sourceSize for Image we forgot (LP: #1595113)
* Replace Flickable with an Item inside DashPageHeader for
headerContainer (LP: #1599235)
[ Albert Astals Cid, Andrea Cimitan ]
* Unbox the artshapeLoader
[ Daniel d'Andrada ]
* Fix splashscreen orientation when app rotates own contents (LP:
#1586050)
* tst_PreviewIconActions: Make test name match filename
* Cursor: make its size grid unit based (LP: #1604014)
* TouchEventSequenceWrapper: item might get deleted when touch
sequence is committed (LP: #1607686)
[ Lukáš Tinkl ]
* Implement frontend support for running keyboard indicator
* Provide window/surface close shortcuts across all the stages (LP:
#1578392, #1606528)
* Restart the location trust prompt service when exiting the wizard
(LP: #1594430)
* Implement clearing the search and closing the panel on pressing
Escape key in the dash header
* Fix log timestamps (LP: #1602196)
* Don't display the mode switch warning dialog on tablets (LP:
#1600290)
[ Michael Terry ]
* Fix indicator profile bug that caused sound indicator to say Mute
instead of Silent Mode. (LP: #1604205)
* Fix lockscreen appearing right after unlocking a locked session on
the desktop. (LP: #1604374)
[ Michał Sawicz ]
* Add arm64 support, drop unnecessary B-D on web plugin - 2555. By dobey on 2016-08-08
-
Merged dandrader's branch.
- 2554. By dobey on 2016-07-29
-
[ Zoltán Balogh ]
* Bump the version to secure UITK compatibility
[ Albert Astals Cid ]
* Pass the correct number of arguments to mapToItem (LP: #1606835)
* Rebuild against Qt 5.6.
* Add https://code.launchpad .net/~aacid/ unity8/ floor_includes/ +merge/ 300850 - 2553. By dobey on 2016-07-28
-
tryCompare is apparently inconsistent with Compare.
- 2552. By dobey on 2016-07-27
-
Update copyright years in chagned files.
Do a second findChild in the test. - 2551. By dobey on 2016-07-25
-
Use findChild instead.
- 2550. By dobey on 2016-07-22
-
[ Daniel d'Andrada ]
Make use of MirSurface::inputBounds and drop UbuntuKeyboardInfo hack - 2549. By dobey on 2016-07-22
-
Processing doesn't call root triggered signal.
- 2548. By dobey on 2016-07-22
-
Update the tests too.
- 2547. By dobey on 2016-07-18
-
The whitespace test is awful.
FAILED: Continuous integration, rev:2543
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/