Merge lp:~dirk.zimoch/epics-base/fix-aai-and-aao into lp:~epics-core/epics-base/3.14

[Dirk Zimoch]

* Bugfix: writing to aai/aao via db link crashed ioc. Memory allocation / device support init_record moved to pass 0.
* Soft device support for aai and aao added.
* Simulation mode fixed. SIOL link added. (sim handling is done in devsup!)
* Bugfix: writing to aai/aao modified NELM. Modify NORD instead.
* Hashing added to minimize monitor updates (like in waveform record)

Discussion:
Add features like RVAL->VAL conversion, scaling, smoothing, alarm limits?

[lp:~dirk.zimoch/epics-base/fix-aai-and-aao]

12076. By Dirk Zimoch <dirk@ubuntu> on 2010-05-28

release notes updated

12077. By Dirk Zimoch <dirk@ubuntu> on 2010-05-28

Merged with 3.14

[Ralph Lange (ralph-lange)]

Looked at the code - the changes look fine to me.

As I never used the aai/aao records, I don't see me being the right person for testing and proper evaluation of the changes in behaviour, though.

[Andrew Johnson (anj)]

Hi Dirk,

When SIMM=YES, the aai record is put into alarm using the SIMS field for the severity. The aao record always goes to INVALID_ALARM in simulation mode.

Do you know under what circumstances a device support might want to set BPTR itself? The comment about calling the pdset->init_record() in pass 0 implies that run-time changes of the device address wouldn't be possible in that case (which is in the device support's power to allow if it uses devExtend(), but prevented if it doesn't).

Have you ever seen any written documentation for the aai/aao record types? There are no chapters for them in the Record Reference wiki yet.

I haven't started actually testing this code yet (that's my next task), but so far I think this work should be merged into R3.14.12.

- Andrew

[Ben Franksen (bfrk)]

On Freitag, 2. Juli 2010, Andrew Johnson wrote:
> Do you know under what circumstances a device support might want to set
> BPTR itself?

Slightly off-topic, but I suggest removing BPTR and use VAL field instead.
VAL is not used for anything at the moment, AFAIR, and is also
DBF_NOACCESS, so this is even compatible (but not for device support, maybe
this is the reason this hasn't been done before?).

Same for waveform record, BTW.

Cheers
Ben

[Andrew Johnson (anj)]

Hi Ben,

Interesting point, although not relevant to the review of this particular branch. Making that change to the records would require a corresponding modification to all device supports, so it's not something I'd want to do for 3.14.12. I guess removing the BPTR fields completely would cause any unmodified code to fail at compile-time (which is what we'd want), so it's not an impossible idea for 3.15.

Thanks,

- Andrew

[Dirk Zimoch (dirk.zimoch)]

Andrew,

> The aao record always goes to INVALID_ALARM in simulation mode.
I missed that. It should use the SIMS field as well. As soon as I get bazaar installed on this computer, I will fix that.

I have never seen documentation on the aai/aao records, but I guess that the intention was to set BPTR directly to memory mapped register space to save the time for copying data. But this has several disadvantages:
* BPTR must be set early enough (fixed now)
* BPTR must not change at run time (e.g. no double buffering). I have to check what devExtend() does to solve this problem.
* As a result, BPTR may contain inconsistent data if the hardware modifies the buffer while it is being read (e.g. by a CA read or monitor)

I kept the memory allocation model to stay compatible to old device supports. Additionally I allow for new device supports not to set BPTR. Also to stay compatible, I do not want to switch from BPTR to VAL.

Basically the aai is the same as the waveform record except that it does not have a RARM field. The aao is the only record that is intended to write arrays. (The waveform can write through its INP if the device support allows. But if we do so, why do we need ai/ao, mbbi/mbbo, etc. pairs?)

[Andrew Johnson (anj)]

On Monday 05 July 2010 03:02:23 Dirk Zimoch wrote:
>
> * BPTR must not change at run time (e.g. no double buffering). I have to
> check what devExtend() does to solve this problem.

Sorry, devExtend() is the way that a device support tells the iocCore code
that it can accept address changes at runtime; it doesn't solve that problem.
The devExtend() routine must be called from a dset->init() routine and points
to a dsxt structure with the add_record() and del_record() routines that
support those runtime changes for this device support. My point was merely
that if BPTR can't be changed after rset->init_record(0) returns [presumably
because this somehow stops DB links from working] that it's not going to be
possible to have extended device support that sets BPTR. Not a major issue,
and there are no incompatibilities here.

> I kept the memory allocation model to stay compatible to old device
> supports. Additionally I allow for new device supports not to set BPTR.
> Also to stay compatible, I do not want to switch from BPTR to VAL.

I agree that this is the best solution for now.

Thanks,

- Andrew
--
The best FOSS code is written to be read by other humans -- Harald Welte

[Dirk Zimoch (dirk.zimoch)]

What we really need to make this work as intended, i.e. modify BPTR at run-time to point to the current data, is a way to tell a link, a CA connection, and maybe other EPICS components that the address of the data has changed. But this is a completely different problem.

[lp:~dirk.zimoch/epics-base/fix-aai-and-aao]

12078. By Dirk Zimoch <dirk@ubuntu> on 2010-07-07

Bugfix: use SIMS for simulation severity

12079. By Dirk Zimoch <dirk@ubuntu> on 2010-07-07

Merged with mirror-3.14

[Andrew Johnson (anj)]

Asynchronous processing doesn't work because of the line
    if (pact) return 0;
in the process() routines of both record types.

With those lines removed I'm happy with the result, so I will merge the code.

Thanks,

- Andrew

review: Approve

=== modified file 'documentation/RELEASE_NOTES.html'
--- documentation/RELEASE_NOTES.html	2010-07-01 16:59:22 +0000
+++ documentation/RELEASE_NOTES.html	2010-07-07 17:48:44 +0000
@@ -11,6 +11,13 @@
 
 <h2 align="center">Changes between 3.14.11 and 3.14.12</h2>
 <!-- Insert new items immediately below here ... -->
+<h4>Record Types aai and aao</h4>
+<p>Fixed bug in memory allocation that caused crashes when linking other records
+to aai or aao.
+Fixed bug where NELM was modified instead of NORD.
+Added Soft Channel device support.
+Added SIOL link and proper simulation mode for Soft Channel support.
+Added MPST, APST and HASH fields for monitor on change support like in waveform record.
 
 
 <h4>devLib cleanup</h4>

=== modified file 'src/dev/softDev/Makefile'
--- src/dev/softDev/Makefile	2008-09-24 22:40:37 +0000
+++ src/dev/softDev/Makefile	2010-07-07 17:48:44 +0000
@@ -12,6 +12,8 @@
 
 DBD += devSoft.dbd
 
+LIBSRCS += devAaiSoft.c
+LIBSRCS += devAaoSoft.c
 LIBSRCS += devAiSoft.c
 LIBSRCS += devAiSoftRaw.c
 LIBSRCS += devAoSoft.c

=== added file 'src/dev/softDev/devAaiSoft.c'
--- src/dev/softDev/devAaiSoft.c	1970-01-01 00:00:00 +0000
+++ src/dev/softDev/devAaiSoft.c	2010-07-07 17:48:44 +0000
@@ -0,0 +1,87 @@
+/*************************************************************************\
+* Copyright (c) 2008 UChicago Argonne LLC, as Operator of Argonne
+*     National Laboratory.
+* Copyright (c) 2002 The Regents of the University of California, as
+*     Operator of Los Alamos National Laboratory.
+* EPICS BASE is distributed subject to a Software License Agreement found
+* in file LICENSE that is included with this distribution. 
+\*************************************************************************/
+
+/* $Id$
+ * devAaiSoft.c - Device Support Routines for soft Waveform Records
+ *
+ *      Original Author: Bob Dalesio
+ *      Current Author:  Dirk Zimoch
+ *      Date:            27-MAY-2010
+ */
+
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+
+#include "alarm.h"
+#include "dbDefs.h"
+#include "dbAccess.h"
+#include "recGbl.h"
+#include "devSup.h"
+#include "cantProceed.h"
+#include "menuYesNo.h"
+#include "aaiRecord.h"
+#include "epicsExport.h"
+
+/* Create the dset for devAaiSoft */
+static long init_record();
+static long read_aai();
+
+struct {
+    long      number;
+    DEVSUPFUN report;
+    DEVSUPFUN init;
+    DEVSUPFUN init_record;
+    DEVSUPFUN get_ioint_info;
+    DEVSUPFUN read_aai;
+} devAaiSoft = {
+    5,
+    NULL,
+    NULL,
+    init_record,
+    NULL,
+    read_aai
+};
+epicsExportAddress(dset,devAaiSoft);
+
+static long init_record(aaiRecord *prec)
+{
+    /* INP must be a CONSTANT or a PV_LINK or a DB_LINK or a CA_LINK*/
+    switch (prec->inp.type) {
+    case CONSTANT:
+        prec->nord = 0;
+        break;
+    case PV_LINK:
+    case DB_LINK:
+    case CA_LINK:
+	break;
+    default :
+	recGblRecordError(S_db_badField, (void *)prec,
+	    "devAaiSoft (init_record) Illegal INP field");
+	return(S_db_badField);
+    }
+    return 0;
+}
+
+static long read_aai(aaiRecord *prec)
+{
+    long nRequest = prec->nelm;
+
+    dbGetLink(prec->simm == menuYesNoYES ? &prec->siol : &prec->inp,
+        prec->ftvl, prec->bptr, 0, &nRequest);
+    if (nRequest > 0) {
+        prec->nord = nRequest;
+        prec->udf=FALSE;
+        if (prec->tsel.type == CONSTANT &&
+            prec->tse == epicsTimeEventDeviceTime)
+            dbGetTimeStamp(&prec->inp, &prec->time);
+    }
+
+    return 0;
+}

=== added file 'src/dev/softDev/devAaoSoft.c'
--- src/dev/softDev/devAaoSoft.c	1970-01-01 00:00:00 +0000
+++ src/dev/softDev/devAaoSoft.c	2010-07-07 17:48:44 +0000
@@ -0,0 +1,79 @@
+/*************************************************************************\
+* Copyright (c) 2008 UChicago Argonne LLC, as Operator of Argonne
+*     National Laboratory.
+* Copyright (c) 2002 The Regents of the University of California, as
+*     Operator of Los Alamos National Laboratory.
+* EPICS BASE is distributed subject to a Software License Agreement found
+* in file LICENSE that is included with this distribution. 
+\*************************************************************************/
+
+/* $Id$
+ * devAaoSoft.c - Device Support Routines for soft Waveform Records
+ * 
+ *      Original Author: Bob Dalesio
+ *      Current Author:  Dirk Zimoch
+ *      Date:            27-MAY-2010
+ */
+
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+
+#include "alarm.h"
+#include "dbDefs.h"
+#include "dbAccess.h"
+#include "recGbl.h"
+#include "devSup.h"
+#include "cantProceed.h"
+#include "menuYesNo.h"
+#include "aaoRecord.h"
+#include "epicsExport.h"
+
+/* Create the dset for devAaoSoft */
+static long init_record();
+static long write_aao();
+
+struct {
+    long      number;
+    DEVSUPFUN report;
+    DEVSUPFUN init;
+    DEVSUPFUN init_record;
+    DEVSUPFUN get_ioint_info;
+    DEVSUPFUN read_aao;
+} devAaoSoft = {
+    5,
+    NULL,
+    NULL,
+    init_record,
+    NULL,
+    write_aao
+};
+epicsExportAddress(dset,devAaoSoft);
+
+static long init_record(aaoRecord *prec)
+{
+    /* OUT must be a CONSTANT or a PV_LINK or a DB_LINK or a CA_LINK*/
+    switch (prec->out.type) {
+    case CONSTANT:
+        prec->nord = 0;
+        break;
+    case PV_LINK:
+    case DB_LINK:
+    case CA_LINK:
+	break;
+    default :
+	recGblRecordError(S_db_badField, prec,
+		"devAaoSoft (init_record) Illegal OUT field");
+	return(S_db_badField);
+    }
+    return 0;
+}
+
+static long write_aao(aaoRecord *prec)
+{
+    long nRequest = prec->nord;
+    dbPutLink(prec->simm == menuYesNoYES ? &prec->siol : &prec->out,
+        prec->ftvl, prec->bptr, nRequest);
+
+    return 0;
+}

=== modified file 'src/dev/softDev/devSoft.dbd'
--- src/dev/softDev/devSoft.dbd	2008-09-24 22:40:37 +0000
+++ src/dev/softDev/devSoft.dbd	2010-07-07 17:48:44 +0000
@@ -1,3 +1,5 @@
+device(aai,CONSTANT,devAaiSoft,"Soft Channel")
+device(aao,CONSTANT,devAaoSoft,"Soft Channel")
 device(ai,CONSTANT,devAiSoft,"Soft Channel")
 device(ao,CONSTANT,devAoSoft,"Soft Channel")
 device(bi,CONSTANT,devBiSoft,"Soft Channel")

=== modified file 'src/misc/base.dbd'
--- src/misc/base.dbd	2008-08-14 20:41:05 +0000
+++ src/misc/base.dbd	2010-07-07 17:48:44 +0000
@@ -8,6 +8,8 @@
 include "menuConvert.dbd"
 
 # Record types
+include "aaiRecord.dbd"
+include "aaoRecord.dbd"
 include "aiRecord.dbd"
 include "aoRecord.dbd"
 include "aSubRecord.dbd"

=== modified file 'src/rec/aaiRecord.c'
--- src/rec/aaiRecord.c	2009-07-08 18:14:11 +0000
+++ src/rec/aaiRecord.c	2010-07-07 17:48:44 +0000
@@ -9,7 +9,6 @@
 /* recAai.c - Record Support Routines for Array Analog In records */
 /*
  *      Original Author: Dave Barker
- *      Date:            10/24/93
  *
  *      C  E  B  A  F
  *     
@@ -18,6 +17,8 @@
  *
  *      Copyright SURA CEBAF 1993.
  *
+ *      Current Author: Dirk Zimoch <[e-mail]>
+ *      Date:            27-MAY-2010
  */
 
 #include <stddef.h>
@@ -28,14 +29,17 @@
 
 #include "dbDefs.h"
 #include "epicsPrint.h"
+#include "epicsString.h"
 #include "alarm.h"
 #include "dbAccess.h"
+#include "dbEvent.h"
+#include "dbFldTypes.h"
 #include "dbScan.h"
-#include "dbEvent.h"
 #include "devSup.h"
 #include "errMdef.h"
 #include "recSup.h"
 #include "recGbl.h"
+#include "cantProceed.h"
 #include "menuYesNo.h"
 #define GEN_SIZE_OFFSET
 #include "aaiRecord.h"
@@ -48,7 +52,7 @@
 static long init_record(aaiRecord *, int);
 static long process(aaiRecord *);
 #define special NULL
-static long get_value(aaiRecord *, struct valueDes *);
+#define get_value NULL
 static long cvt_dbaddr(DBADDR *);
 static long get_array_info(DBADDR *, long *, long *);
 static long put_array_info(DBADDR *, long);
@@ -84,43 +88,67 @@
 epicsExportAddress(rset,aaiRSET);
 
 struct aaidset { /* aai dset */
-    long            number;
-    DEVSUPFUN       dev_report;
-    DEVSUPFUN       init;
-    DEVSUPFUN       init_record; /*returns: (-1,0)=>(failure,success)*/
-    DEVSUPFUN       get_ioint_info;
-    DEVSUPFUN       read_aai; /*returns: (-1,0)=>(failure,success)*/
+    long      number;
+    DEVSUPFUN dev_report;
+    DEVSUPFUN init;
+    DEVSUPFUN init_record; /*returns: (-1,0)=>(failure,success)*/
+    DEVSUPFUN get_ioint_info;
+    DEVSUPFUN read_aai; /*returns: (-1,0)=>(failure,success)*/
 };
 
 static void monitor(aaiRecord *);
 static long readValue(aaiRecord *);
 
-
 static long init_record(aaiRecord *prec, int pass)
 {
-    struct aaidset *pdset;
     long status;
+    struct aaidset *pdset = (struct aaidset *)(prec->dset);
 
+    /* must have dset defined */
+    if (!pdset) {
+        recGblRecordError(S_dev_noDSET, prec, "aai: init_record");
+        return S_dev_noDSET;
+    }
+    
     if (pass == 0) {
-        if (prec->nelm <= 0) prec->nelm = 1;
+        if (prec->nelm <= 0)
+            prec->nelm = 1;
+        if (prec->ftvl > DBF_ENUM)
+            prec->ftvl = DBF_UCHAR;
+        if (prec->nelm == 1) {
+            prec->nord = 1;
+        } else {
+            prec->nord = 0;
+        }
+            
+        /* we must call pdset->init_record in pass 0
+           because it may set prec->bptr which must
+           not change after links are established before pass 1
+        */
+           
+        if (pdset->init_record) {
+            /* init_record may set the bptr to point to the data */
+            if ((status = pdset->init_record(prec)))
+                return status;
+        }
+        if (!prec->bptr) {
+            /* device support did not allocate memory so we must do it */
+            prec->bptr = callocMustSucceed(prec->nelm, dbValueSize(prec->ftvl),
+                "aai: buffer calloc failed");
+        }
         return 0;
     }
-    recGblInitConstantLink(&prec->siml, DBF_USHORT, &prec->simm);
-    /* must have dset defined */
-    if (!(pdset = (struct aaidset *)(prec->dset))) {
-        recGblRecordError(S_dev_noDSET, (void *)prec, "aai: init_record");
-        return S_dev_noDSET;
+    
+    /* SIML must be a CONSTANT or a PV_LINK or a DB_LINK */
+    if (prec->siml.type == CONSTANT) {
+	recGblInitConstantLink(&prec->siml,DBF_USHORT,&prec->simm);
     }
+    
     /* must have read_aai function defined */
     if (pdset->number < 5 || pdset->read_aai == NULL) {
-        recGblRecordError(S_dev_missingSup, (void *)prec, "aai: init_record");
+        recGblRecordError(S_dev_missingSup, prec, "aai: init_record");
         return S_dev_missingSup;
     }
-    if (pdset->init_record) {
-        /* init_record sets the bptr to point to the data */
-        if ((status = pdset->init_record(prec)))
-            return status;
-    }
     return 0;
 }
 
@@ -132,14 +160,13 @@
 
     if (pdset == NULL || pdset->read_aai == NULL) {
         prec->pact = TRUE;
-        recGblRecordError(S_dev_missingSup, (void *)prec, "read_aai");
+        recGblRecordError(S_dev_missingSup, prec, "read_aai");
         return S_dev_missingSup;
     }
 
     if (pact) return 0;
 
     status = readValue(prec); /* read the new value */
-    /* check if device support set pact */
     if (!pact && prec->pact) return 0;
     prec->pact = TRUE;
 
@@ -151,22 +178,14 @@
     recGblFwdLink(prec);
 
     prec->pact = FALSE;
-    return 0;
-}
-
-static long get_value(aaiRecord *prec, struct valueDes *pvdes)
-{
-    pvdes->no_elements = prec->nelm;
-    pvdes->pvalue      = prec->bptr;
-    pvdes->field_type  = prec->ftvl;
-    return 0;
+    return status;
 }
 
 static long cvt_dbaddr(DBADDR *paddr)
 {
     aaiRecord *prec = (aaiRecord *)paddr->precord;
 
-    paddr->pfield         = (void *)(prec->bptr);
+    paddr->pfield         = prec->bptr;
     paddr->no_elements    = prec->nelm;
     paddr->field_type     = prec->ftvl;
     paddr->field_size     = dbValueSize(prec->ftvl);
@@ -178,7 +197,7 @@
 {
     aaiRecord *prec = (aaiRecord *)paddr->precord;
 
-    *no_elements =  prec->nelm;
+    *no_elements =  prec->nord;
     *offset = 0;
     return 0;
 }
@@ -187,7 +206,9 @@
 {
     aaiRecord *prec = (aaiRecord *)paddr->precord;
 
-    prec->nelm = nNew;
+    prec->nord = nNew;
+    if (prec->nord > prec->nelm)
+        prec->nord = prec->nelm;
     return 0;
 }
 
@@ -204,7 +225,7 @@
     aaiRecord *prec = (aaiRecord *)paddr->precord;
 
     *precision = prec->prec;
-    if (paddr->pfield == (void *)prec->bptr) return 0;
+    if (paddr->pfield == prec->bptr) return 0;
     recGblGetPrec(paddr, precision);
     return 0;
 }
@@ -213,7 +234,7 @@
 {
     aaiRecord *prec = (aaiRecord *)paddr->precord;
 
-    if (paddr->pfield == (void *)prec->bptr) {
+    if (paddr->pfield == prec->bptr) {
         pgd->upper_disp_limit = prec->hopr;
         pgd->lower_disp_limit = prec->lopr;
     } else recGblGetGraphicDouble(paddr, pgd);
@@ -224,7 +245,7 @@
 {
     aaiRecord *prec = (aaiRecord *)paddr->precord;
 
-    if (paddr->pfield == (void *)prec->bptr) {
+    if (paddr->pfield == prec->bptr) {
         pcd->upper_ctrl_limit = prec->hopr;
         pcd->lower_ctrl_limit = prec->lopr;
     } else recGblGetControlDouble(paddr, pcd);
@@ -234,9 +255,35 @@
 static void monitor(aaiRecord *prec)
 {
     unsigned short monitor_mask;
+    unsigned int hash = 0;
 
     monitor_mask = recGblResetAlarms(prec);
-    monitor_mask |= (DBE_LOG | DBE_VALUE);
+
+    if (prec->mpst == aaiPOST_Always)
+        monitor_mask |= DBE_VALUE;
+    if (prec->apst == aaiPOST_Always)
+        monitor_mask |= DBE_LOG;
+
+    /* Calculate hash if we are interested in OnChange events. */
+    if ((prec->mpst == aaiPOST_OnChange) ||
+        (prec->apst == aaiPOST_OnChange)) {
+        hash = epicsMemHash(prec->bptr,
+            prec->nord * dbValueSize(prec->ftvl), 0);
+
+        /* Only post OnChange values if the hash is different. */
+        if (hash != prec->hash) {
+            if (prec->mpst == aaiPOST_OnChange)
+                monitor_mask |= DBE_VALUE;
+            if (prec->apst == aaiPOST_OnChange)
+                monitor_mask |= DBE_LOG;
+
+            /* Store hash for next process. */
+            prec->hash = hash;
+            /* Post HASH. */
+            db_post_events(prec, &prec->hash, DBE_VALUE);
+        }
+    }
+
     if (monitor_mask)
         db_post_events(prec, prec->bptr, monitor_mask);
 }
@@ -253,21 +300,25 @@
 
     status = dbGetLink(&prec->siml, DBR_ENUM, &prec->simm, 0, 0);
     if (status)
-        return(status);
+        return status;
 
     if (prec->simm == menuYesNoNO){
-        /* Call dev support */
-        status = pdset->read_aai(prec);
-        return status;
+        return pdset->read_aai(prec);
     }
+    
     if (prec->simm == menuYesNoYES){
-        /* Simm processing split performed in devSup */
-        /* Call dev support */
-        status = pdset->read_aai(prec);
-        return status;
+        /* Device suport is responsible for buffer
+           which might be read-only so we may not be
+           allowed to call dbGetLink on it.
+           Maybe also device support has an advanced
+           simulation mode.
+           Thus call device now.
+        */
+        recGblSetSevr(prec, SIMM_ALARM, prec->sims);
+        return pdset->read_aai(prec);
     }
-    status = -1;
-    recGblSetSevr(prec, SIMM_ALARM, INVALID_ALARM);
-    return status;
+
+    recGblSetSevr(prec, SOFT_ALARM, INVALID_ALARM);
+    return -1;
 }
 

=== modified file 'src/rec/aaiRecord.dbd'
--- src/rec/aaiRecord.dbd	2002-07-12 21:35:43 +0000
+++ src/rec/aaiRecord.dbd	2010-07-07 17:48:44 +0000
@@ -7,6 +7,10 @@
 # and higher are distributed subject to a Software License Agreement found
 # in file LICENSE that is included with this distribution. 
 #*************************************************************************
+menu(aaiPOST) {
+        choice(aaiPOST_Always,"Always")
+        choice(aaiPOST_OnChange,"On Change")
+}
 recordtype(aai) {
 	include "dbCommon.dbd" 
 	field(VAL,DBF_NOACCESS) {
@@ -82,4 +86,25 @@
 		interest(2)
 		menu(menuAlarmSevr)
 	}
+	field(SIOL,DBF_INLINK) {
+		prompt("Sim Input Specifctn")
+		promptgroup(GUI_INPUTS)
+		interest(1)
+	}
+	field(MPST,DBF_MENU) {
+                prompt("Post Value Monitors")
+                promptgroup(GUI_DISPLAY)
+                interest(1)
+                menu(aaiPOST)
+	}
+	field(APST,DBF_MENU) {
+                prompt("Post Archive Monitors")
+                promptgroup(GUI_DISPLAY)
+                interest(1)
+                menu(aaiPOST)
+        }
+	field(HASH,DBF_ULONG) {
+		prompt("Hash of OnChange data.")
+		interest(3)
+	}
 }

=== modified file 'src/rec/aaoRecord.c'
--- src/rec/aaoRecord.c	2009-07-08 18:14:11 +0000
+++ src/rec/aaoRecord.c	2010-07-07 17:48:44 +0000
@@ -9,7 +9,6 @@
 /* recAao.c - Record Support Routines for Array Analog Out records */
 /*
  *      Original Author: Dave Barker
- *      Date:            10/28/93
  *
  *      C  E  B  A  F
  *     
@@ -18,6 +17,8 @@
  *
  *      Copyright SURA CEBAF 1993.
  *
+ *      Current Author: Dirk Zimoch <[e-mail]>
+ *      Date:            27-MAY-2010
  */
 
 #include <stddef.h>
@@ -28,14 +29,17 @@
 
 #include "dbDefs.h"
 #include "epicsPrint.h"
+#include "epicsString.h"
 #include "alarm.h"
 #include "dbAccess.h"
+#include "dbEvent.h"
 #include "dbFldTypes.h"
 #include "dbScan.h"
-#include "dbEvent.h"
 #include "devSup.h"
+#include "errMdef.h"
 #include "recSup.h"
 #include "recGbl.h"
+#include "cantProceed.h"
 #include "menuYesNo.h"
 #define GEN_SIZE_OFFSET
 #include "aaoRecord.h"
@@ -48,7 +52,7 @@
 static long init_record(aaoRecord *, int);
 static long process(aaoRecord *);
 #define special NULL
-static long get_value(aaoRecord *, struct valueDes *);
+#define get_value NULL
 static long cvt_dbaddr(DBADDR *);
 static long get_array_info(DBADDR *, long *, long *);
 static long put_array_info(DBADDR *, long);
@@ -84,43 +88,67 @@
 epicsExportAddress(rset,aaoRSET);
 
 struct aaodset { /* aao dset */
-    long            number;
-    DEVSUPFUN       dev_report;
-    DEVSUPFUN       init;
-    DEVSUPFUN       init_record; /*returns: (-1,0)=>(failure,success)*/
-    DEVSUPFUN       get_ioint_info;
-    DEVSUPFUN       write_aao; /*returns: (-1,0)=>(failure,success)*/
+    long      number;
+    DEVSUPFUN dev_report;
+    DEVSUPFUN init;
+    DEVSUPFUN init_record; /*returns: (-1,0)=>(failure,success)*/
+    DEVSUPFUN get_ioint_info;
+    DEVSUPFUN write_aao; /*returns: (-1,0)=>(failure,success)*/
 };
 
 static void monitor(aaoRecord *);
 static long writeValue(aaoRecord *);
 
-
 static long init_record(aaoRecord *prec, int pass)
 {
-    struct aaodset *pdset;
     long status;
+    struct aaodset *pdset = (struct aaodset *)(prec->dset);
 
-    if (pass == 0) {
-        if (prec->nelm <= 0) prec->nelm = 1;
-        return 0;
-    }
-    recGblInitConstantLink(&prec->siml, DBF_USHORT, &prec->simm);
     /* must have dset defined */
-    if (!(pdset = (struct aaodset *)(prec->dset))) {
-        recGblRecordError(S_dev_noDSET, (void *)prec, "aao: init_record");
+    if (!pdset) {
+        recGblRecordError(S_dev_noDSET, prec, "aao: init_record");
         return S_dev_noDSET;
     }
+    
+    if (pass == 0) {
+        if (prec->nelm <= 0)
+            prec->nelm = 1;
+        if (prec->ftvl > DBF_ENUM)
+            prec->ftvl = DBF_UCHAR;
+        if (prec->nelm == 1) {
+            prec->nord = 1;
+        } else {
+            prec->nord = 0;
+        }
+            
+        /* we must call pdset->init_record in pass 0
+           because it may set prec->bptr which must
+           not change after links are established before pass 1
+        */
+           
+        if (pdset->init_record) {
+            /* init_record may set the bptr to point to the data */
+            if ((status = pdset->init_record(prec)))
+                return status;
+        }
+        if (!prec->bptr) {
+            /* device support did not allocate memory so we must do it */
+            prec->bptr = callocMustSucceed(prec->nelm, dbValueSize(prec->ftvl),
+                "aao: buffer calloc failed");
+        }
+        return 0;
+    }
+    
+    /* SIML must be a CONSTANT or a PV_LINK or a DB_LINK */
+    if (prec->siml.type == CONSTANT) {
+	recGblInitConstantLink(&prec->siml,DBF_USHORT,&prec->simm);
+    }
+    
     /* must have write_aao function defined */
     if (pdset->number < 5 || pdset->write_aao == NULL) {
-        recGblRecordError(S_dev_missingSup, (void *)prec, "aao: init_record");
+        recGblRecordError(S_dev_missingSup, prec, "aao: init_record");
         return S_dev_missingSup;
     }
-    if (pdset->init_record) {
-        /* init records sets the bptr to point to the data */
-        if ((status = pdset->init_record(prec)))
-            return status;
-    }
     return 0;
 }
 
@@ -132,13 +160,15 @@
 
     if (pdset == NULL || pdset->write_aao == NULL) {
         prec->pact = TRUE;
-        recGblRecordError(S_dev_missingSup, (void *)prec, "write_aao");
+        recGblRecordError(S_dev_missingSup, prec, "write_aao");
         return S_dev_missingSup;
     }
 
     if (pact) return 0;
 
     status = writeValue(prec); /* write the data */
+    if (!pact && prec->pact) return 0;
+    prec->pact = TRUE;
 
     prec->udf = FALSE;
     recGblGetTimeStamp(prec);
@@ -148,22 +178,14 @@
     recGblFwdLink(prec);
 
     prec->pact = FALSE;
-    return 0;
-}
-
-static long get_value(aaoRecord *prec, struct valueDes *pvdes)
-{
-    pvdes->no_elements = prec->nelm;
-    pvdes->pvalue      = prec->bptr;
-    pvdes->field_type  = prec->ftvl;
-    return 0;
+    return status;
 }
 
 static long cvt_dbaddr(DBADDR *paddr)
 {
     aaoRecord *prec = (aaoRecord *)paddr->precord;
 
-    paddr->pfield         = (void *)(prec->bptr);
+    paddr->pfield         = prec->bptr;
     paddr->no_elements    = prec->nelm;
     paddr->field_type     = prec->ftvl;
     paddr->field_size     = dbValueSize(prec->ftvl);
@@ -175,7 +197,7 @@
 {
     aaoRecord *prec = (aaoRecord *)paddr->precord;
 
-    *no_elements =  prec->nelm;
+    *no_elements =  prec->nord;
     *offset = 0;
     return 0;
 }
@@ -184,7 +206,9 @@
 {
     aaoRecord *prec = (aaoRecord *)paddr->precord;
 
-    prec->nelm = nNew;
+    prec->nord = nNew;
+    if (prec->nord > prec->nelm)
+        prec->nord = prec->nelm;
     return 0;
 }
 
@@ -210,7 +234,7 @@
 {
     aaoRecord *prec = (aaoRecord *)paddr->precord;
 
-    if (paddr->pfield == (void *)prec->bptr) {
+    if (paddr->pfield == prec->bptr) {
         pgd->upper_disp_limit = prec->hopr;
         pgd->lower_disp_limit = prec->lopr;
     } else recGblGetGraphicDouble(paddr,pgd);
@@ -221,7 +245,7 @@
 {
     aaoRecord *prec = (aaoRecord *)paddr->precord;
 
-    if(paddr->pfield==(void *)prec->bptr){
+    if(paddr->pfield == prec->bptr){
         pcd->upper_ctrl_limit = prec->hopr;
         pcd->lower_ctrl_limit = prec->lopr;
     } else recGblGetControlDouble(paddr,pcd);
@@ -231,9 +255,35 @@
 static void monitor(aaoRecord *prec)
 {
     unsigned short monitor_mask;
+    unsigned int hash = 0;
 
     monitor_mask = recGblResetAlarms(prec);
-    monitor_mask |= (DBE_LOG | DBE_VALUE);
+
+    if (prec->mpst == aaoPOST_Always)
+        monitor_mask |= DBE_VALUE;
+    if (prec->apst == aaoPOST_Always)
+        monitor_mask |= DBE_LOG;
+
+    /* Calculate hash if we are interested in OnChange events. */
+    if ((prec->mpst == aaoPOST_OnChange) ||
+        (prec->apst == aaoPOST_OnChange)) {
+        hash = epicsMemHash(prec->bptr,
+            prec->nord * dbValueSize(prec->ftvl), 0);
+
+        /* Only post OnChange values if the hash is different. */
+        if (hash != prec->hash) {
+            if (prec->mpst == aaoPOST_OnChange)
+                monitor_mask |= DBE_VALUE;
+            if (prec->apst == aaoPOST_OnChange)
+                monitor_mask |= DBE_LOG;
+
+            /* Store hash for next process. */
+            prec->hash = hash;
+            /* Post HASH. */
+            db_post_events(prec, &prec->hash, DBE_VALUE);
+        }
+    }
+
     if (monitor_mask)
         db_post_events(prec, prec->bptr, monitor_mask);
 }
@@ -253,17 +303,20 @@
         return status;
 
     if (prec->simm == menuYesNoNO) {
-        /* Call dev support */
-        status = pdset->write_aao(prec);
-        return status;
+        return pdset->write_aao(prec);
     }
     if (prec->simm == menuYesNoYES) {
-        /* Call dev support */
-        status = pdset->write_aao(prec);
-        return status;
+        /* Device suport is responsible for buffer
+           which might be write-only so we may not be
+           allowed to call dbPutLink on it.
+           Maybe also device support has an advanced
+           simulation mode.
+           Thus call device now.
+        */
+        recGblSetSevr(prec, SIMM_ALARM, prec->sims);
+        return pdset->write_aao(prec);
     }
-    status = -1;
-    recGblSetSevr(prec, SIMM_ALARM, INVALID_ALARM);
-    return status;
+    recGblSetSevr(prec, SOFT_ALARM, INVALID_ALARM);
+    return -1;
 }
 

=== modified file 'src/rec/aaoRecord.dbd'
--- src/rec/aaoRecord.dbd	2002-07-12 21:35:43 +0000
+++ src/rec/aaoRecord.dbd	2010-07-07 17:48:44 +0000
@@ -7,6 +7,10 @@
 # and higher are distributed subject to a Software License Agreement found
 # in file LICENSE that is included with this distribution. 
 #*************************************************************************
+menu(aaoPOST) {
+        choice(aaoPOST_Always,"Always")
+        choice(aaoPOST_OnChange,"On Change")
+}
 recordtype(aao) {
 	include "dbCommon.dbd" 
 	field(VAL,DBF_NOACCESS) {
@@ -82,4 +86,25 @@
 		interest(2)
 		menu(menuAlarmSevr)
 	}
+	field(SIOL,DBF_OUTLINK) {
+		prompt("Sim Output Specifctn")
+		promptgroup(GUI_INPUTS)
+		interest(1)
+	}
+	field(MPST,DBF_MENU) {
+                prompt("Post Value Monitors")
+                promptgroup(GUI_DISPLAY)
+                interest(1)
+                menu(aaoPOST)
+	}
+	field(APST,DBF_MENU) {
+                prompt("Post Archive Monitors")
+                promptgroup(GUI_DISPLAY)
+                interest(1)
+                menu(aaoPOST)
+        }
+	field(HASH,DBF_ULONG) {
+		prompt("Hash of OnChange data.")
+		interest(3)
+	}
 }