Code review comment for lp:~dirk.zimoch/epics-base/fix-aai-and-aao

On Monday 05 July 2010 03:02:23 Dirk Zimoch wrote:
>
> * BPTR must not change at run time (e.g. no double buffering). I have to
> check what devExtend() does to solve this problem.

Sorry, devExtend() is the way that a device support tells the iocCore code
that it can accept address changes at runtime; it doesn't solve that problem.
The devExtend() routine must be called from a dset->init() routine and points
to a dsxt structure with the add_record() and del_record() routines that
support those runtime changes for this device support. My point was merely
that if BPTR can't be changed after rset->init_record(0) returns [presumably
because this somehow stops DB links from working] that it's not going to be
possible to have extended device support that sets BPTR. Not a major issue,
and there are no incompatibilities here.

> I kept the memory allocation model to stay compatible to old device
> supports. Additionally I allow for new device supports not to set BPTR.
> Also to stay compatible, I do not want to switch from BPTR to VAL.

I agree that this is the best solution for now.

Thanks,

- Andrew
--
The best FOSS code is written to be read by other humans -- Harald Welte