Code review comment for lp:~dave-cheney/juju-core/always-vet-struct-tags

Revision history for this message
Dave Cheney (dave-cheney) wrote :

Ignore, this doesn't appear to do anything

On Tue, Apr 8, 2014 at 3:41 PM, Dave Cheney <email address hidden> wrote:
> Dave Cheney has proposed merging lp:~dave-cheney/juju-core/always-vet-struct-tags into lp:juju-core.
>
> Requested reviews:
> juju hackers (juju)
>
> For more details, see:
> https://code.launchpad.net/~dave-cheney/juju-core/always-vet-struct-tags/+merge/214661
>
> Tweak lbox settings
>
>
> --
> https://code.launchpad.net/~dave-cheney/juju-core/always-vet-struct-tags/+merge/214661
> You are the owner of lp:~dave-cheney/juju-core/always-vet-struct-tags.
>
> === modified file '.lbox.check'
> --- .lbox.check 2013-09-23 13:17:29 +0000
> +++ .lbox.check 2014-04-08 05:40:53 +0000
> @@ -9,11 +9,11 @@
> exit 1
> fi
>
> -VERSION=`go version | awk '{print $3}'`
> go tool vet \
> -methods \
> -printf \
> -rangeloops \
> + -structtags=true \
> -printfuncs 'ErrorContextf:1,notFoundf:0,badReqErrorf:0,Commitf:0,Snapshotf:0,Debugf:0,Infof:0,Warningf:0,Errorf:0,Criticalf:0,Tracef:0' \
> .
>
>
>

« Back to merge proposal