Merge lp:~dave-cheney/juju-core/always-vet-struct-tags into lp:~go-bot/juju-core/trunk
Proposed by
Dave Cheney
Status: | Rejected |
---|---|
Rejected by: | John A Meinel |
Proposed branch: | lp:~dave-cheney/juju-core/always-vet-struct-tags |
Merge into: | lp:~go-bot/juju-core/trunk |
Diff against target: |
15 lines (+1/-1) 1 file modified
.lbox.check (+1/-1) |
To merge this branch: | bzr merge lp:~dave-cheney/juju-core/always-vet-struct-tags |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+214661@code.launchpad.net |
Description of the change
Tweak lbox settings
To post a comment you must log in.
Unmerged revisions
- 2583. By Dave Cheney
-
more .lbox.check tweaks
- 2582. By Dave Cheney
-
enable -structtags vet check
Ignore, this doesn't appear to do anything
On Tue, Apr 8, 2014 at 3:41 PM, Dave Cheney <email address hidden> wrote: /code.launchpad .net/~dave- cheney/ juju-core/ always- vet-struct- tags/+merge/ 214661 /code.launchpad .net/~dave- cheney/ juju-core/ always- vet-struct- tags/+merge/ 214661 1,notFoundf: 0,badReqErrorf: 0,Commitf: 0,Snapshotf: 0,Debugf: 0,Infof: 0,Warningf: 0,Errorf: 0,Criticalf: 0,Tracef: 0' \
> Dave Cheney has proposed merging lp:~dave-cheney/juju-core/always-vet-struct-tags into lp:juju-core.
>
> Requested reviews:
> juju hackers (juju)
>
> For more details, see:
> https:/
>
> Tweak lbox settings
>
>
> --
> https:/
> You are the owner of lp:~dave-cheney/juju-core/always-vet-struct-tags.
>
> === modified file '.lbox.check'
> --- .lbox.check 2013-09-23 13:17:29 +0000
> +++ .lbox.check 2014-04-08 05:40:53 +0000
> @@ -9,11 +9,11 @@
> exit 1
> fi
>
> -VERSION=`go version | awk '{print $3}'`
> go tool vet \
> -methods \
> -printf \
> -rangeloops \
> + -structtags=true \
> -printfuncs 'ErrorContextf:
> .
>
>
>