Merge lp:~dave-cheney/juju-core/always-vet-struct-tags into lp:~go-bot/juju-core/trunk

Proposed by Dave Cheney
Status: Rejected
Rejected by: John A Meinel
Proposed branch: lp:~dave-cheney/juju-core/always-vet-struct-tags
Merge into: lp:~go-bot/juju-core/trunk
Diff against target: 15 lines (+1/-1)
1 file modified
.lbox.check (+1/-1)
To merge this branch: bzr merge lp:~dave-cheney/juju-core/always-vet-struct-tags
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+214661@code.launchpad.net

Description of the change

Tweak lbox settings

To post a comment you must log in.
Revision history for this message
Dave Cheney (dave-cheney) wrote :

Ignore, this doesn't appear to do anything

On Tue, Apr 8, 2014 at 3:41 PM, Dave Cheney <email address hidden> wrote:
> Dave Cheney has proposed merging lp:~dave-cheney/juju-core/always-vet-struct-tags into lp:juju-core.
>
> Requested reviews:
> juju hackers (juju)
>
> For more details, see:
> https://code.launchpad.net/~dave-cheney/juju-core/always-vet-struct-tags/+merge/214661
>
> Tweak lbox settings
>
>
> --
> https://code.launchpad.net/~dave-cheney/juju-core/always-vet-struct-tags/+merge/214661
> You are the owner of lp:~dave-cheney/juju-core/always-vet-struct-tags.
>
> === modified file '.lbox.check'
> --- .lbox.check 2013-09-23 13:17:29 +0000
> +++ .lbox.check 2014-04-08 05:40:53 +0000
> @@ -9,11 +9,11 @@
> exit 1
> fi
>
> -VERSION=`go version | awk '{print $3}'`
> go tool vet \
> -methods \
> -printf \
> -rangeloops \
> + -structtags=true \
> -printfuncs 'ErrorContextf:1,notFoundf:0,badReqErrorf:0,Commitf:0,Snapshotf:0,Debugf:0,Infof:0,Warningf:0,Errorf:0,Criticalf:0,Tracef:0' \
> .
>
>
>

Unmerged revisions

2583. By Dave Cheney

more .lbox.check tweaks

2582. By Dave Cheney

enable -structtags vet check

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.lbox.check'
2--- .lbox.check 2013-09-23 13:17:29 +0000
3+++ .lbox.check 2014-04-08 05:40:53 +0000
4@@ -9,11 +9,11 @@
5 exit 1
6 fi
7
8-VERSION=`go version | awk '{print $3}'`
9 go tool vet \
10 -methods \
11 -printf \
12 -rangeloops \
13+ -structtags=true \
14 -printfuncs 'ErrorContextf:1,notFoundf:0,badReqErrorf:0,Commitf:0,Snapshotf:0,Debugf:0,Infof:0,Warningf:0,Errorf:0,Criticalf:0,Tracef:0' \
15 .
16

Subscribers

People subscribed via source and target branches

to status/vote changes: