lp:~dave-cheney/juju-core/always-vet-struct-tags

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2014-04-08

Diff: 15 lines (+1/-1)

1 file modified

.lbox.check (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2583. By Dave Cheney on 2014-04-08

more .lbox.check tweaks

2582. By Dave Cheney on 2014-04-08

enable -structtags vet check

2581. By Andrew Wilkins on 2014-04-08

[r=axwalk] doc: add azure provider doc

https://codereview.appspot.com/84470052/

2580. By Andrew Wilkins on 2014-04-08

[r=axwalk] Remove 1.16 support code

This drops most of the 1.16 support code from
the client-side. There's more to remove, this
is just a start.

https://codereview.appspot.com/84520046/

2579. By Dave Cheney on 2014-04-08

[r=dave-cheney] Fix nil pointer error during test setup

Now a missing mongod returns a much improved error

ubuntu@winton-02:~/src/launchpad.net/juju-core$ go test ./worker/uniter
--- FAIL: TestPackage (0.00 seconds)
        mgo.go:211: exec: "mongod": executable file not found in $PATH
FAIL
FAIL launchpad.net/juju-core/worker/uniter 0.509s

https://codereview.appspot.com/85100044/

2578. By Dimiter Naydenov on 2014-04-07

[r=dimitern] provider/maas: Get machine NICs in StartInstance

If networks were specified, in StartInstance the
MAAS provider now requests the node details from
the server, which contain XML data from lshw that
was gathered at commissioning time. The XML is
parsed to extract a map of interface name to
MAC address. This is needed so that in a follow-up
we'll combine the information from there and from
a GetNetworksList call to return []NetworkInfo
from StartInstance.

Live tested on MAAS and whitebox tested the XML
parsing helper only, because gomaasapi's test
server does not support getting node details yet.

https://codereview.appspot.com/84850045/

R=klyachin

2577. By Dimiter Naydenov on 2014-04-07

[r=dimitern] environs: Add []NetworkInfo to StartInstance

This does not introduce new logic, just changes
the StartInstance() return values (across all
providers) to include a slice of NetworkInfo,
which will be used in a follow-up by the MAAS
provider to report what networks and network
interfaces will be configured for the instance.

https://codereview.appspot.com/84470044/

R=fwereade, gz

2576. By Dave Cheney on 2014-04-07

[r=dave-cheney] Always supply fake amd64/precise tools

This is another place https://codereview.appspot.com/84280044/ needs to be applied

https://codereview.appspot.com/84860046/

2575. By Tim Penhey on 2014-04-07

[r=thumper] Add debug-log server api

Add the server side end-point for the debug-log api
call. This is implemented as a websocket, with the
request parameters defining the filtering behaviour,
and the log lines that match being streamed back to
the user over the web-socket.

The first line over the websocket is the an error
structure. If there are any issues either processing
the parameters or opening the log file, there is
an error, and if not, the Error component is 'null'.

The capabilities of the server match the older python
version as closely as possible.

https://codereview.appspot.com/84880044/

2574. By Horacio Durán on 2014-04-07

[r=hduran-8],[bug=1291022] Changed timeout on mongo wait after restore

Bug 1291022 was caused by a race condition.
After restore, there was a period of wait until
mongodb would come up. The timeout value was set
too low for cases where connection to the server
was too fast. On slow connections there was extra
time produced by the lag overhead.
I changed the timeout value and
tested in a machine in the same region than
the environment created, it stopped failing after
the change.

https://codereview.appspot.com/82280045/

R=natefinch, rogpeppe
R=natefinch, rogpeppe