Merge lp:~danilo/launchpad/bug-814580-cold-db into lp:launchpad

[Данило Шеган]

= Bug 814580: post-cleanup =

This renames the table PackagingJob to TranslationSharingJob (model code has already been changed).

This requires a downtime deployment since all appservers have to be restarted after this change is deployed.

== Proposed fix ==

[lp:~danilo/launchpad/bug-814580-cold-db]

13583. By Данило Шеган on 2011-08-01

Merged bug-814580 into bug-814580-cold-db.

[Robert Collins (lifeless)]

This will need approval from me or francis as we no long have routine coordinated downtime + schema + new appserver versions.

Whats the reason for needing a deploy-to-both ?

I'm guessing its the table rename? If so, I suggest you create a view that just presents the table, so that the same appserver code will work. Then once the appservers are upgraded, we can drop the view.

review: Needs Resubmitting

[Данило Шеган (danilo)]

Yes, it's only for the rename.

A view TranslationSharingJob mirroring PackagingJob is a great idea: that would then go into https://code.launchpad.net/~danilo/launchpad/bug-814580-db/+merge/69979 instead of this branch. However, modifications are a bit more complicated (CREATE RULE ON INSERT/UPDATE/DELETE will have to be provided as well). Even with all that, I am not sure if storm will work with it properly.

The code change from this branch would then go into https://code.launchpad.net/~danilo/launchpad/bug-814580/+merge/69978

And this branch could only drop the view and rename the table. Is that what you are suggesting?

[Stuart Bishop (stub)]

Views with update rules are a pain, but this will work for transition.

I wonder if it is easier to do at the Python end? There we are usually only concerned with changing the __storm_table__ attribute on a single class based on if a table exists or if a db patch has been deployed, and could be done via database introspection or some mechanism like a flag being set in zookeeper.

[Stuart Bishop (stub)]

https://dev.launchpad.net/Database/TableRenamePatch

Unmerged revisions

13583. By Данило Шеган on 2011-08-01

Merged bug-814580 into bug-814580-cold-db.

13582. By Данило Шеган on 2011-08-01

Add a DB patch to rename PackagingJob table to TranslationSharingJob.

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2011-08-01 12:22:06 +0000
+++ database/schema/comments.sql	2011-08-01 12:22:11 +0000
@@ -1893,14 +1893,14 @@
 that we do not keep a history of these, so if someone sets it correctly,
 then someone else sets it incorrectly, we lose the first setting.';
 
-COMMENT ON TABLE PackagingJob IS 'A Job related to a Packaging entry.';
-COMMENT ON COLUMN PackagingJob.id IS '';
-COMMENT ON COLUMN PackagingJob.job IS 'The Job related to this PackagingJob.';
-COMMENT ON COLUMN PackagingJob.job_type IS 'An enumeration specifying the type of job to perform.';
-COMMENT ON COLUMN PackagingJob.productseries IS 'The productseries of the Packaging.';
-COMMENT ON COLUMN PackagingJob.sourcepackagename IS 'The sourcepackage of the Packaging.';
-COMMENT ON COLUMN PackagingJob.distroseries IS 'The distroseries of the Packaging.';
-COMMENT ON COLUMN PackagingJob.potemplate IS 'A POTemplate to restrict the job to or NULL if all templates need to be handled.';
+COMMENT ON TABLE TranslationSharingJob IS 'A Job related to a Packaging entry.';
+COMMENT ON COLUMN TranslationSharingJob.id IS '';
+COMMENT ON COLUMN TranslationSharingJob.job IS 'The Job related to this TranslationSharingJob.';
+COMMENT ON COLUMN TranslationSharingJob.job_type IS 'An enumeration specifying the type of job to perform.';
+COMMENT ON COLUMN TranslationSharingJob.productseries IS 'The productseries of the Packaging.';
+COMMENT ON COLUMN TranslationSharingJob.sourcepackagename IS 'The sourcepackage of the Packaging.';
+COMMENT ON COLUMN TranslationSharingJob.distroseries IS 'The distroseries of the Packaging.';
+COMMENT ON COLUMN TranslationSharingJob.potemplate IS 'A POTemplate to restrict the job to or NULL if all templates need to be handled.';
 
 -- Translator / TranslationGroup
 
 
=== added file 'database/schema/patch-2208-99-0.sql'
--- database/schema/patch-2208-99-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-99-0.sql	2011-08-01 12:22:11 +0000
@@ -0,0 +1,11 @@
+-- Copyright 2011 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+SET client_min_messages=ERROR;
+
+ALTER TABLE PackagingJob
+  RENAME TO TranslationSharingJob;
+
+ALTER INDEX packagingjob__job__idx
+  RENAME TO translationsharingjob__job__idx;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 99, 0);
 
=== modified file 'lib/lp/translations/model/translationsharingjob.py'
--- lib/lp/translations/model/translationsharingjob.py	2011-08-01 12:22:06 +0000
+++ lib/lp/translations/model/translationsharingjob.py	2011-08-01 12:22:11 +0000
@@ -65,7 +65,7 @@
 class TranslationSharingJob(StormBase):
     """Base class for jobs related to a packaging."""
 
-    __storm_table__ = 'PackagingJob'
+    __storm_table__ = 'TranslationSharingJob'
 
     id = Int(primary=True)