Author: Colin Watson
Revision Date: 2019-08-23 23:28:08 UTC

Simplify some GCC attribute handling

* lib/orderfiles.c (order_files) [!HAVE_LINUX_FIEMAP_H &&
!HAVE_POSIX_FADVISE]: Use _GL_UNUSED rather than ATTRIBUTE_UNUSED.
* lib/sandbox.c (_sandbox_load) [!HAVE_LIBSECCOMP]: Likewise.
* lib/security.c (drop_privs): Likewise.
* src/accessdb.c (help_filter): Likewise.
* src/check_mandirs.c (chown_if_possible): Likewise.
* src/decompress.c (decompress_zlib): Likewise.
* src/lexgrog_test.c (help_filter): Likewise.
* src/man.c (help_filter, squeeze_blank_lines, disable_hyphenation,
disable_justification): Likewise.
* src/manconv.c (manconv): Likewise.
* src/manp.c (free_config_file): Likewise.
* src/tests/fspause.c (main): Likewise.
* src/whatis.c (help_filter): Likewise.
* src/zsoelim_main.c (parse_opt): Likewise.
* include/manconfig.h.in (ATTRIBUTE_UNUSED): Remove in favour of the
shorter _GL_UNUSED.
(ATTRIBUTE_MALLOC): Remove; it was unused.

Author: Colin Watson
Revision Date: 2019-08-23 16:18:58 UTC

Handle GPGKeyExpired and GPGKeyNotFoundError when authenticating incoming email.

Author: Colin Watson
Revision Date: 2019-08-23 15:11:52 UTC

Optimise commented bugs search further by lifting bug task ID search into a CTE as well.

Author: Colin Watson
Revision Date: 2019-08-23 11:40:51 UTC

Upgrade to rabbitfixture 0.4.2 and bump ctltimeout to 60 seconds.

Author: Colin Watson
Revision Date: 2019-08-23 10:06:34 UTC

Add a script to generate a NaCl key pair.

The instructions for generating config.snappy.store_secrets_private_key and
config.snappy.store_secrets_public_key were getting a bit long, so I decided
to put some of them in this script.

I used a plain entry point rather than the LaunchpadScript infrastructure,
since this is very simple and doesn't need all of that machinery.

Author: Colin Watson
Revision Date: 2019-08-22 13:09:17 UTC

Fix permissions on /etc/logrotate.d/logstash-forwarder.

logrotate ignores executable configuration files.

Author: Colin Watson
Revision Date: 2019-08-21 14:23:46 UTC

Add tox testing support and drop buildout.

Author: Colin Watson
Revision Date: 2019-08-21 12:10:12 UTC

Import IObjectEvent from zope.interface rather than zope.component.

Author: Colin Watson
Revision Date: 2019-08-14 13:52:37 UTC

Rewrite BugSummary triggers to be statement-level.

Author: Colin Watson
Revision Date: 2019-08-11 22:16:36 UTC

Include tests in sdist.

Author: Colin Watson
Revision Date: 2019-08-11 16:57:24 UTC

Update string handling for Python 3.

This is inspired by work done by Thiago Bellini. I've taken a different
approach in a few areas which are useful to discuss briefly here (and some
of this should end up in release notes):

 * I generally wrote "bytes" rather than "six.binary_type", since it's
   shorter and works in all supported versions of Python.

 * In the SQLite backend, there's no need to use memoryview, because the
   sqlite3 module in Python 3 automatically converts between the SQLite BLOB
   type and bytes.

 * Some exception messages have changed slightly for clarity.

 * On Python 3, raw=True and token=True in storm.expr.Compile.__call__ only
   treats str specially, not bytes and str, because ultimately the compiler
   is assembling a text string to send to the database.

 * On Python 3, storm.tracer.BaseStatementTracer.connection_raw_execute
   renders text parameters using ascii() rather than by encoding to bytes
   and then calling repr(). While this does result in slightly different
   output from Python 2, it's normally more useful since the encoding is in
   terms of Unicode codepoints rather than UTF-8.

 * storm.sqlobject.AutoUnicodeVariable (and hence StringCol) explicitly
   documents that it only accepts text on Python 3, since native strings are
   already Unicode there so there's much less need for the porting
   affordance.

Author: Colin Watson
Revision Date: 2019-08-08 08:59:51 UTC

Chase redirects in footer.

Author: Colin Watson
Revision Date: 2019-07-31 15:47:00 UTC

Merge devel.

Author: Colin Watson
Revision Date: 2019-05-28 23:39:15 UTC

Fix multiple-override race for architecture-independent binaries.

If an architecture-independent binary had multiple identical overrides
created in the same publisher run (for example by multiple archive
administrators racing to fulfil the same request, or by the
phased-updates script), then BinaryPackagePublishingHistory.supersede
would supersede them all without ensuring that the newest publication
remained live.

The architecture-independent sibling publications don't have a formal
relation to each other in the data model, which is why this has always
been hard to fix. However, the dominator sorts publications with equal
versions by their creation dates, so it will always consider the most
recent override to be live. We can therefore fix this by deferring the
superseding of architecture-independent siblings until we've positively
confirmed which publications are live using the dominator's normal
logic, and taking care not to supersede the confirmed-live publications.

An additional complication is that the dominator processes one
architecture at a time, so in general it won't have confirmed the full
set of live publications until it has processed all architectures. To
cope with this, I've lifted the handling of architecture-independent
siblings out of BinaryPackagePublishingHistory.supersede into a new
BinaryPackagePublishingHistory.supersedeAssociated method. The
supersede method calls supersedeAssociated by default to minimise chaos
in the test suite, but the dominator passes a flag to disable that and
calls supersedeAssociated separately.

Author: Colin Watson
Revision Date: 2019-05-28 16:36:49 UTC

Add warning for future developers.

Author: Colin Watson
Revision Date: 2019-05-24 16:17:07 UTC

Add SnapBuild.explicitly_private column.

Author: Colin Watson
Revision Date: 2019-05-22 08:56:20 UTC

Handle AMQP channel errors (particularly NotFound) in the publisher.

amqp 2.4.0 included a change to drain events before publishing. This
means that if we try to publish an OOPS to a nonexistent exchange, then
some future publishing attempt will raise a NotFound exception, which is
a channel error rather than a connection error and so wasn't previously
handled.

To try to minimise confusion resulting from this (which can be
considerable - it took me several days to track down what was happening
in Launchpad's test suite), spend a short time waiting for a response
for the broker after publishing an OOPS. This will typically allow us
to detect channel errors immediately, which we now handle; even if we
don't manage to handle them immediately, they'll be handled the next
time we try to publish something on the same channel.

It would be possible to handle channel errors more economically by just
reopening a channel on the same connection rather than reopening the
entire connection, but reopening the connection seems to work well
enough for now.

Author: Colin Watson
Revision Date: 2019-05-11 11:16:16 UTC

Go back to getting the logged-in user from LaunchBag.

Otherwise the model's security adapter would have a serious hole, even
though it wouldn't be possible to exploit it via the webservice.

Author: Colin Watson
Revision Date: 2019-05-10 16:48:28 UTC

Merge devel.

Author: Steve Langasek
Revision Date: 2019-03-22 15:55:28 UTC

Bump ubuntukylin limits further, per willcooke / handsome_feng

Author: Colin Watson
Revision Date: 2019-03-21 16:24:06 UTC

Delete branches and Git repositories asynchronously.

Author: Colin Watson
Revision Date: 2019-03-21 16:17:11 UTC

Add a Git repository deletion job.

Author: Colin Watson
Revision Date: 2019-03-21 15:44:34 UTC

Add a branch deletion job.

Author: Colin Watson
Revision Date: 2019-02-10 23:00:51 UTC

Use macros for common cases of list iteration

* src/glcontainers.h: New file.
* src/Makefile.am (COMMON): Add glcontainers.h.
* src/find.c (find_interpreters): Replace manual list iteration with
equivalent macros.
* src/run-detectors.c (main): Likewise.
* src/update-binfmts.c (act_enable, act_disable, act_display): Likewise.

Author: Colin Watson
Revision Date: 2019-01-30 14:04:49 UTC

Prune old completed BranchMergeProposalJobs.

Author: Colin Watson
Revision Date: 2019-01-30 09:23:59 UTC

Use HTTPS URL

* README, lib/libpipeline.pc.in (URL): Update homepage URL to
https://nongnu.org/libpipeline/.

Author: Colin Watson
Revision Date: 2018-12-17 14:08:02 UTC

Port to Python 3.

This should be safe on >= trusty, as cloud images contain python3, and
charm-helpers will bootstrap the rest as long as the hook #! line works.

I dropped unicode() from the data persistence functions, as it's
unnecessary: on Python 2 a file opened with "w" will accept str writes, and
on Python 3 json.dumps always returns str rather than bytes.

Author: Colin Watson
Revision Date: 2018-12-07 18:37:01 UTC

Add a LXD image to builds for the buildd subproject.

Author: Colin Watson
Revision Date: 2018-11-30 20:22:34 UTC

Tell rsyncd to use the proxy uid/gid when serving squid-logs.

Author: Colin Watson
Revision Date: 2018-11-28 13:12:33 UTC

Support newer versions of the nrpe charm.

This is a bit of a hack, but can be simplified once all deployments have
been upgraded.

Author: Colin Watson
Revision Date: 2018-10-01 10:12:42 UTC

Get ScopedCollection.range_factory_class from the corresponding field.

Author: Colin Watson
Revision Date: 2018-09-28 14:38:26 UTC

Remove limitation on immediately reinstating a mutator as a named operation.

Author: Colin Watson
Revision Date: 2018-09-05 10:27:00 UTC

Add dns_v4_first configuration option.

PS4.5 doesn't have IPv6 yet, so Squid's default of preferring IPv6 addresses
fails.

Author: Colin Watson
Revision Date: 2018-05-25 22:18:52 UTC

Add interstitial pages when creating or reactivating an account.

These provide an opportunity to present the user with the terms of service
and privacy policy and require that they explicitly accept them, as well as
making it harder to reactivate an account by accident.

To support testing this locally, I extended make-lp-user to be able to
create placeholder accounts, and adjusted testopenid so that it can
authenticate as an inactive account by explicitly supplying the username.

Author: Colin Watson
Revision Date: 2018-05-18 21:07:47 UTC

Cherry-pick https://code.launchpad.net/~andrewsomething/bzr/bts794146/+merge/266499 for Launchpad.

Author: Colin Watson
Revision Date: 2018-05-04 16:19:34 UTC

Dispatch private BPBs immediately, using macaroon auth for source files.

Author: Colin Watson
Revision Date: 2018-04-21 11:10:19 UTC

Turn ArchiveFile into a history table, adding date_created and date_superseded columns. Adjust the publisher to match.

Author: Colin Watson
Revision Date: 2018-04-21 10:53:17 UTC

Add ArchiveFile.date_created and ArchiveFile.date_superseded.

Author: Colin Watson
Revision Date: 2018-03-14 14:10:58 UTC

Convert translation templates builds to the new VCS mixin, thereby adding git support.

Author: Colin Watson
Revision Date: 2017-11-19 12:31:35 UTC

Merge virtualenv-pip.

Author: Colin Watson
Revision Date: 2015-09-08 11:35:19 UTC

Drop immediate mail delivery from LaunchpadScript and LaunchpadZopelessLayer.

Author: Colin Watson
Revision Date: 2017-11-01 01:09:59 UTC

Replace most of devscripts.sourcecode with codetree.

Author: Colin Watson
Revision Date: 2017-10-07 03:01:55 UTC

Include a link to the archive in "PPA access granted" email notifications.

Author: Colin Watson
Revision Date: 2017-09-30 01:09:23 UTC

Fix indentation.

Author: Colin Watson
Revision Date: 2017-09-15 18:57:39 UTC

Only include *.py from twisted/ in the sdist.

Author: Colin Watson
Revision Date: 2017-09-15 17:08:49 UTC

Don't add a process back to the ready set if it received an error such as a timeout.

Author: Aurelien Jarno
Revision Date: 2017-06-28 08:24:49 UTC

remove haskell-debian

[Debian bug #866184]

Author: Colin Watson
Revision Date: 2017-05-23 12:29:35 UTC

Remove `bzr register-branch`, since it has not worked for a long time.

Author: Colin Watson
Revision Date: 2017-05-11 10:58:58 UTC

Enable throttled progress output from git-to-git import workers.

Author: Colin Watson
Revision Date: 2017-02-03 10:37:39 UTC

Move to snap/snapcraft.yaml.

Author: Colin Watson
Revision Date: 2017-01-28 19:40:29 UTC

Set strict-origin-when-cross-origin referrer policy on private views.

Author: Colin Watson
Revision Date: 2016-12-05 14:47:41 UTC

Split out push and push-with-packages targets, since we don't need to push (dummy) resources every time.

Author: Colin Watson
Revision Date: 2016-11-21 14:01:43 UTC

Don't dispatch SnapBuilds whose code object is empty, perhaps because an associated code import hasn't finished.

Author: Colin Watson
Revision Date: 2016-11-17 15:00:35 UTC

Make GitSubscription.paths be a JSON-encoded list instead.

Author: Colin Watson
Revision Date: 2016-11-15 17:37:04 UTC

Isolate gpgme from its terminal environment, if any.

Author: Colin Watson
Revision Date: 2016-07-11 14:23:03 UTC

Fix ANT_OPTS handling.

Author: Colin Watson
Revision Date: 2016-07-08 17:34:38 UTC

Don't output passwords to the build log.

Author: Colin Watson
Revision Date: 2016-05-26 11:55:52 UTC

Handle dists/*/*/signed the same way as dists/*/*/uefi.

Author: Colin Watson
Revision Date: 2016-04-25 15:33:42 UTC

Show human-readable descriptions of macaroon caveats when we have them.

Author: Colin Watson
Revision Date: 2016-03-03 15:40:01 UTC

Add icon.png.

Author: Colin Watson
Revision Date: 2016-03-02 13:17:02 UTC

Check caveats in accessors, mutators, and collections.

Author: Colin Watson
Revision Date: 2016-02-21 18:20:33 UTC

lpbuildd/binarypackage.py: Use "apt-get indextargets" and "apt-helper
cat-file" where they exist to read Packages files, rather than looking
in /var/lib/apt/lists/ directly.

Author: Kit Randel
Revision Date: 2016-02-11 02:51:17 UTC

Update files from array to dict for snapcraft 1.0 api.

Author: Colin Watson
Revision Date: 2016-01-12 16:59:11 UTC

Model and show SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch.

Author: Colin Watson
Revision Date: 2016-01-12 16:03:23 UTC

Add SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch columns.

Author: Colin Watson
Revision Date: 2015-12-02 13:49:47 UTC

Take an advisory lock on the target archive when copying packages.

Author: Colin Watson
Revision Date: 2015-11-19 01:51:49 UTC

Rotate logs even if empty.

Author: Colin Watson
Revision Date: 2015-11-18 17:04:52 UTC

Prepare Apache configurations for xz index files in archives.

Author: Colin Watson
Revision Date: 2015-11-02 11:16:25 UTC

Fix over-indentation.

Author: Colin Watson
Revision Date: 2015-11-02 11:16:12 UTC

Fix over-indentation.

Author: Colin Watson
Revision Date: 2015-10-29 11:00:36 UTC

Move PIP_SOURCE_DIR check from build-tarball to $(ENV).

Author: Colin Watson
Revision Date: 2015-10-13 15:36:10 UTC

Copy live filesystems from the previous series on initialisation.

Author: Colin Watson
Revision Date: 2015-10-01 15:19:22 UTC

Depend on python-gi, since it's needed to import from gi.repository.

Author: Colin Watson
Revision Date: 2015-09-15 14:10:06 UTC

Also return Git-based merge proposals from IHasRequestedReviews.getRequestedReviews.

Author: Colin Watson
Revision Date: 2015-09-15 11:31:46 UTC

Prepare Apache configuration for InRelease files in archives.

Author: Colin Watson
Revision Date: 2015-07-02 11:38:00 UTC

Cherry-pick https://code.launchpad.net/~cjwatson/bzr/fix-keep-dirty/+merge/263632 for Launchpad.

Author: Colin Watson
Revision Date: 2015-06-18 13:51:59 UTC

Factor out tarball name.

Author: Colin Watson
Revision Date: 2015-06-09 16:34:06 UTC

Make sure the hints branch always points to the right place, even if it's changed due to e.g. a series being released.

Author: Colin Watson
Revision Date: 2015-05-22 15:42:11 UTC

Pass through the necessary configuration options for cgit OpenID authentication support.

Author: Colin Watson
Revision Date: 2015-05-07 15:56:22 UTC

Add configuration to open rsync log access to certain hosts.

Author: Colin Watson
Revision Date: 2015-05-01 15:20:10 UTC

Remove the ##GITNAMESPACE## markers, now that we're on production.

Author: Colin Watson
Revision Date: 2015-04-24 16:18:51 UTC

Fix Nagios checks to handle haproxy 1.5.

Author: Colin Watson
Revision Date: 2015-03-26 13:58:03 UTC

Add extra_open_ports configuration setting to make it easier to hulk-smash haproxy onto the same unit as apache2.

Author: Colin Watson
Revision Date: 2015-02-20 15:30:36 UTC

Generate the britney2 configuration file dynamically, with series-appropriate architecture lists.

Author: Colin Watson
Revision Date: 2015-02-19 15:36:45 UTC

Make the lock file be per-series as well as per-distribution.

Author: Colin Watson
Revision Date: 2015-02-19 13:47:24 UTC

Include $SERIES-updates in the baseline Sources/Packages data files.

Author: Colin Watson
Revision Date: 2015-02-19 12:58:33 UTC

Return 0 from blocks function for DISTRIBUTION != ubuntu.

Author: Colin Watson
Revision Date: 2015-02-19 12:56:42 UTC

Use series prefix for update_excuses.html in a couple more places.

Author: Colin Watson
Revision Date: 2015-02-13 18:23:56 UTC

Ensure that a repository exists on disk before receiving pack data into it.

Author: Colin Watson
Revision Date: 2015-02-13 17:28:07 UTC

Use subdirectory rather than file prefix.

Author: Colin Watson
Revision Date: 2015-02-10 14:16:48 UTC

Set up hints and blocks appropriately for runs against Ubuntu stable series.

Author: Colin Watson
Revision Date: 2015-02-03 17:09:32 UTC

Return user.id as an additional dict entry from authenticateWithPassword; require user ID rather than name in translatePath.

Author: Colin Watson
Revision Date: 2014-12-30 19:37:57 UTC

Use the most recent appropriate transition for DstTzInfo._utcoffset and friends, rather than the first transition which may be very old.

Author: Colin Watson
Revision Date: 2014-10-16 10:22:55 UTC

First cut at a native D-Bus service for click. Doesn't quite work yet.

Author: Colin Watson
Revision Date: 2014-10-10 11:09:36 UTC

Add a new cdimage-custom generator.

Author: Colin Watson
Revision Date: 2014-09-19 23:28:49 UTC

releasing package germinate version 2.19

Author: Colin Watson
Revision Date: 2012-03-19 21:43:57 UTC

bin/casper-reconfigure: Unset DEBIAN_HAS_FRONTEND, DEBIAN_FRONTEND, and
DEBCONF_REDIR so that casper-reconfigure properly uses the
noninteractive frontend when invoked from a ubiquity target-config hook
(LP: #955617).

Author: Colin Watson
Revision Date: 2014-07-30 13:10:29 UTC

Add a touch-tests seed containing all the *-autopilot packages from touch, useful for RTM branching.

Author: Colin Watson
Revision Date: 2014-07-17 09:51:30 UTC

Ask the DB to sort filelists by component and architecture and then write a group at a time directly, rather than building a dict of dicts of lists first.

Author: Colin Watson
Revision Date: 2014-06-05 09:33:22 UTC

Sort the channel list.