lp:~cjwatson/python-oops-amqp/publisher-handle-channel-errors
- Get this branch:
- bzr branch lp:~cjwatson/python-oops-amqp/publisher-handle-channel-errors
Branch merges
- Launchpad code reviewers: Pending requested
-
Diff: 85 lines (+29/-2)4 files modifiedNEWS (+5/-0)
oops_amqp/publisher.py (+11/-0)
oops_amqp/tests/test_publisher.py (+8/-0)
oops_amqp/utils.py (+5/-2)
Related source package recipes
Branch information
Recent revisions
- 24. By Colin Watson
-
Handle AMQP channel errors (particularly NotFound) in the publisher.
amqp 2.4.0 included a change to drain events before publishing. This
means that if we try to publish an OOPS to a nonexistent exchange, then
some future publishing attempt will raise a NotFound exception, which is
a channel error rather than a connection error and so wasn't previously
handled.To try to minimise confusion resulting from this (which can be
considerable - it took me several days to track down what was happening
in Launchpad's test suite), spend a short time waiting for a response
for the broker after publishing an OOPS. This will typically allow us
to detect channel errors immediately, which we now handle; even if we
don't manage to handle them immediately, they'll be handled the next
time we try to publish something on the same channel.It would be possible to handle channel errors more economically by just
reopening a channel on the same connection rather than reopening the
entire connection, but reopening the connection seems to work well
enough for now.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:python-oops-amqp
