lp:~cjwatson/launchpad/snap-check-request-private-git
Created by
Colin Watson
and last modified
- Get this branch:
- bzr branch lp:~cjwatson/launchpad/snap-check-request-private-git
Only
Colin Watson
can upload to this branch. If you are
Colin Watson
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Launchpad code reviewers: Pending requested
-
Diff: 281 lines (+140/-16) (has conflicts)5 files modifiedlib/lp/snappy/interfaces/snap.py (+31/-2)
lib/lp/snappy/model/snap.py (+9/-4)
lib/lp/snappy/model/snapbuildbehaviour.py (+3/-9)
lib/lp/snappy/tests/test_snap.py (+96/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+1/-1)
Related source package recipes
Branch information
Recent revisions
- 18648. By Colin Watson
-
Check that the snap owner has read access to the repository, rather than that owners match.
- 18646. By Colin Watson
-
Refactor duplication between Snap.requestBui
ld(s) and SnapBuildBehaviour. It makes sense for these to perform the same checks. One thing becomes
slightly stricter as a result: if the requester was a member of the snap's
owner team when the build was requested, but was removed from that team
before the build was dispatched, then the dispatched build will now fail.
That seems arguably more correct. - 18645. By Colin Watson
-
Ensure that owners match exactly if building a snap from a private Git repository.
- 18644. By Colin Watson
-
Issue an appropriate macaroon when dispatching a snap build that uses a private Git repository.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:launchpad
