Merge lp:~chuckw20/widelands/New_frontier_markers_with_playercolor into lp:widelands

Proposed by Chuck Wilder
Status: Superseded
Proposed branch: lp:~chuckw20/widelands/New_frontier_markers_with_playercolor
Merge into: lp:widelands
Diff against target: 135 lines (+12/-43)
3 files modified
tribes/atlanteans/conf (+1/-14)
tribes/barbarians/conf (+6/-15)
tribes/empire/conf (+5/-14)
To merge this branch: bzr merge lp:~chuckw20/widelands/New_frontier_markers_with_playercolor
Reviewer Review Type Date Requested Status
SirVer Needs Fixing
Review via email: mp+24277@code.launchpad.net

This proposal has been superseded by a proposal from 2010-04-28.

Description of the change

Redeisgned frontier markers for atlantean, barbarian, and empire tribes. Added playercolor masks and removed old playercolor code from their conf files.

To post a comment you must log in.
Revision history for this message
Chuck Wilder (chuckw20) wrote :

Please test this in a Windows multiplayer environment before merging. When testing it in multiplayer mode with build 15 under Windows, I encountered an error referring to a missing [initializations] section in the modified atlantean conf file. There is no such section in the old conf files and the error did not occur in single player mode.

The error did not occur in any of my linux testing.

Revision history for this message
SirVer (sirver) wrote :

The [initializations] vanished with the win-conditions merge lately. Could it be that your windows version is a little dated?

I have the following suggestions for the frontiers: I like the barbarian ones, but the empire and atlanteans look too similar. I suggest a marble stone/sign for the empire as they use marble so much. Also the playercolor areas are not shaded which gives them a bit of a dull look.

review: Needs Fixing
Revision history for this message
Chuck Wilder (chuckw20) wrote :

On Wed, Apr 28, 2010 at 5:35 AM, SirVer <email address hidden> wrote:

> Review: Needs Fixing
> The [initializations] vanished with the win-conditions merge lately. Could
> it be that your windows version is a little dated?
>
> If the win-conditions merge was post-build15, then yes. I still haven't
successfully installed a Windows compiler, so I was using the most current
Windows build I could find which was the build15 release.

I have the following suggestions for the frontiers: I like the barbarian
> ones, but the empire and atlanteans look too similar. I suggest a marble
> stone/sign for the empire as they use marble so much. Also the playercolor
> areas are not shaded which gives them a bit of a dull look.
>
> I wanted to attempt an imperial frontier that resembled a Roman legion
regimental standard, but I guess yours is the better idea. Again, the scale
required by the engine must be taken into account.

I did use shading on the atlantean frontiers, borrowing the same object used
to represent the pile of crystals in the crystal mine building. It just
didn't seem to translate that well. I'll see what I can do.

For now, I'm keeping them static images, but we may want to consider some
animation in the future. I'm thinking chevrons or animal pelts or maybe
even "blue fire". ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tribes/atlanteans/conf' (properties changed: -x to +x)
--- tribes/atlanteans/conf 2010-04-17 11:39:28 +0000
+++ tribes/atlanteans/conf 2010-04-28 16:03:43 +0000
@@ -1,19 +1,5 @@
1# Comments are for graphic designers some ideas1# Comments are for graphic designers some ideas
22
3[defaults]
4plrclr0_r=2
5plrclr0_g=2
6plrclr0_b=74
7plrclr1_r=2
8plrclr1_g=2
9plrclr1_b=112
10plrclr2_r=2
11plrclr2_g=2
12plrclr2_b=149
13plrclr3_r=2
14plrclr3_g=2
15plrclr3_b=198
16
17[tribe]3[tribe]
18author=_ The Widelands Development Team4author=_ The Widelands Development Team
19name=_ Atlanteans5name=_ Atlanteans
@@ -27,6 +13,7 @@
27name=frontier13name=frontier
28pics=pics/frontier_??.png14pics=pics/frontier_??.png
29hotspot=3 1215hotspot=3 12
16playercolor=true
3017
31# Not just a plain color, maybe a cross or some stribes18# Not just a plain color, maybe a cross or some stribes
32[flag]19[flag]
3320
=== modified file 'tribes/atlanteans/pics/frontier_00.png' (properties changed: -x to +x)
34Binary files tribes/atlanteans/pics/frontier_00.png 2009-11-11 19:21:34 +0000 and tribes/atlanteans/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ21Binary files tribes/atlanteans/pics/frontier_00.png 2009-11-11 19:21:34 +0000 and tribes/atlanteans/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ
=== added file 'tribes/atlanteans/pics/frontier_00_pc.png'
35Binary files tribes/atlanteans/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/atlanteans/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ22Binary files tribes/atlanteans/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/atlanteans/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ
=== modified file 'tribes/barbarians/conf' (properties changed: -x to +x)
--- tribes/barbarians/conf 2010-04-17 11:49:40 +0000
+++ tribes/barbarians/conf 2010-04-28 16:03:43 +0000
@@ -1,23 +1,9 @@
1# Comments are for graphic designers some ideas1# Comments are for graphic designers some ideas
22
3[defaults]
4plrclr0_r=2
5plrclr0_g=2
6plrclr0_b=74
7plrclr1_r=2
8plrclr1_g=2
9plrclr1_b=112
10plrclr2_r=2
11plrclr2_g=2
12plrclr2_b=149
13plrclr3_r=2
14plrclr3_g=2
15plrclr3_b=198
16
17[tribe]3[tribe]
18author=_The Widelands Development Team4author=_The Widelands Development Team
19name=_Barbarians5name=_Barbarians
20descr=_The mighty tribes of the eastern lands!6descr=_The mighty tribes of the east-lands!
21bob_vision_range=27bob_vision_range=2
22uiposition=108uiposition=10
23carrier2=ox9carrier2=ox
@@ -27,6 +13,7 @@
27name=frontier13name=frontier
28pics=pics/frontier_??.png14pics=pics/frontier_??.png
29hotspot=1 1915hotspot=1 19
16playercolor=true
3017
31# Not just a plain color, maybe a cross or some stribes18# Not just a plain color, maybe a cross or some stribes
32[flag]19[flag]
@@ -218,6 +205,10 @@
218scouts_hut=_"Scout's Hut"205scouts_hut=_"Scout's Hut"
219cattlefarm=_Cattle Farm206cattlefarm=_Cattle Farm
220207
208[initializations]
209headquarters_medium=_Headquarters medium
210castle_village=_Citadel village
211
221[military_data]212[military_data]
222retreat_interval=0-80213retreat_interval=0-80
223retreat=20214retreat=20
224215
=== modified file 'tribes/barbarians/pics/frontier_00.png' (properties changed: -x to +x)
225Binary files tribes/barbarians/pics/frontier_00.png 2005-12-29 01:10:07 +0000 and tribes/barbarians/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ216Binary files tribes/barbarians/pics/frontier_00.png 2005-12-29 01:10:07 +0000 and tribes/barbarians/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ
=== added file 'tribes/barbarians/pics/frontier_00_pc.png'
226Binary files tribes/barbarians/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/barbarians/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ217Binary files tribes/barbarians/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/barbarians/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ
=== modified file 'tribes/empire/conf' (properties changed: -x to +x)
--- tribes/empire/conf 2010-04-17 11:39:28 +0000
+++ tribes/empire/conf 2010-04-28 16:03:43 +0000
@@ -1,19 +1,5 @@
1# Comments are for graphic designers some ideas1# Comments are for graphic designers some ideas
22
3[defaults]
4plrclr0_r=2
5plrclr0_g=2
6plrclr0_b=74
7plrclr1_r=2
8plrclr1_g=2
9plrclr1_b=112
10plrclr2_r=2
11plrclr2_g=2
12plrclr2_b=149
13plrclr3_r=2
14plrclr3_g=2
15plrclr3_b=198
16
17[tribe]3[tribe]
18author=_The Widelands Development Team4author=_The Widelands Development Team
19name=_Empire5name=_Empire
@@ -27,6 +13,7 @@
27name=frontier13name=frontier
28pics=pics/frontier_??.png14pics=pics/frontier_??.png
29hotspot=1 1915hotspot=1 19
16playercolor=true
3017
31# Not just a plain color, maybe a cross or some stribes18# Not just a plain color, maybe a cross or some stribes
32[flag]19[flag]
@@ -212,6 +199,10 @@
212scouts_house=_"Scout's House"199scouts_house=_"Scout's House"
213donkeyfarm=_Donkeyfarm200donkeyfarm=_Donkeyfarm
214201
202[initializations]
203headquarters_medium=_Headquarters medium
204castle_village=_Castle village
205
215[military_data]206[military_data]
216retreat_interval=10-90207retreat_interval=10-90
217retreat=50208retreat=50
218209
=== modified file 'tribes/empire/pics/frontier_00.png' (properties changed: -x to +x)
219Binary files tribes/empire/pics/frontier_00.png 2009-11-12 11:55:09 +0000 and tribes/empire/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ210Binary files tribes/empire/pics/frontier_00.png 2009-11-12 11:55:09 +0000 and tribes/empire/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ
=== added file 'tribes/empire/pics/frontier_00_pc.png'
220Binary files tribes/empire/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/empire/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ211Binary files tribes/empire/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/empire/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ

Subscribers

People subscribed via source and target branches

to status/vote changes: