Code review comment for lp:~chuckw20/widelands/New_frontier_markers_with_playercolor

On Wed, Apr 28, 2010 at 5:35 AM, SirVer <email address hidden> wrote:

> Review: Needs Fixing
> The [initializations] vanished with the win-conditions merge lately. Could
> it be that your windows version is a little dated?
>
> If the win-conditions merge was post-build15, then yes. I still haven't
successfully installed a Windows compiler, so I was using the most current
Windows build I could find which was the build15 release.

I have the following suggestions for the frontiers: I like the barbarian
> ones, but the empire and atlanteans look too similar. I suggest a marble
> stone/sign for the empire as they use marble so much. Also the playercolor
> areas are not shaded which gives them a bit of a dull look.
>
> I wanted to attempt an imperial frontier that resembled a Roman legion
regimental standard, but I guess yours is the better idea. Again, the scale
required by the engine must be taken into account.

I did use shading on the atlantean frontiers, borrowing the same object used
to represent the pile of crystals in the crystal mine building. It just
didn't seem to translate that well. I'll see what I can do.

For now, I'm keeping them static images, but we may want to consider some
animation in the future. I'm thinking chevrons or animal pelts or maybe
even "blue fire". ;)