Merge lp:~chuckw20/widelands/New_frontier_markers_with_playercolor into lp:widelands

Proposed by Chuck Wilder
Status: Superseded
Proposed branch: lp:~chuckw20/widelands/New_frontier_markers_with_playercolor
Merge into: lp:widelands
Diff against target: 135 lines (+12/-43)
3 files modified
tribes/atlanteans/conf (+1/-14)
tribes/barbarians/conf (+6/-15)
tribes/empire/conf (+5/-14)
To merge this branch: bzr merge lp:~chuckw20/widelands/New_frontier_markers_with_playercolor
Reviewer Review Type Date Requested Status
SirVer Needs Fixing
Review via email: mp+24277@code.launchpad.net

This proposal has been superseded by a proposal from 2010-04-28.

Description of the change

Redeisgned frontier markers for atlantean, barbarian, and empire tribes. Added playercolor masks and removed old playercolor code from their conf files.

To post a comment you must log in.
Revision history for this message
Chuck Wilder (chuckw20) wrote :

Please test this in a Windows multiplayer environment before merging. When testing it in multiplayer mode with build 15 under Windows, I encountered an error referring to a missing [initializations] section in the modified atlantean conf file. There is no such section in the old conf files and the error did not occur in single player mode.

The error did not occur in any of my linux testing.

Revision history for this message
SirVer (sirver) wrote :

The [initializations] vanished with the win-conditions merge lately. Could it be that your windows version is a little dated?

I have the following suggestions for the frontiers: I like the barbarian ones, but the empire and atlanteans look too similar. I suggest a marble stone/sign for the empire as they use marble so much. Also the playercolor areas are not shaded which gives them a bit of a dull look.

review: Needs Fixing
Revision history for this message
Chuck Wilder (chuckw20) wrote :

On Wed, Apr 28, 2010 at 5:35 AM, SirVer <email address hidden> wrote:

> Review: Needs Fixing
> The [initializations] vanished with the win-conditions merge lately. Could
> it be that your windows version is a little dated?
>
> If the win-conditions merge was post-build15, then yes. I still haven't
successfully installed a Windows compiler, so I was using the most current
Windows build I could find which was the build15 release.

I have the following suggestions for the frontiers: I like the barbarian
> ones, but the empire and atlanteans look too similar. I suggest a marble
> stone/sign for the empire as they use marble so much. Also the playercolor
> areas are not shaded which gives them a bit of a dull look.
>
> I wanted to attempt an imperial frontier that resembled a Roman legion
regimental standard, but I guess yours is the better idea. Again, the scale
required by the engine must be taken into account.

I did use shading on the atlantean frontiers, borrowing the same object used
to represent the pile of crystals in the crystal mine building. It just
didn't seem to translate that well. I'll see what I can do.

For now, I'm keeping them static images, but we may want to consider some
animation in the future. I'm thinking chevrons or animal pelts or maybe
even "blue fire". ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tribes/atlanteans/conf' (properties changed: -x to +x)
2--- tribes/atlanteans/conf 2010-04-17 11:39:28 +0000
3+++ tribes/atlanteans/conf 2010-04-28 16:03:43 +0000
4@@ -1,19 +1,5 @@
5 # Comments are for graphic designers some ideas
6
7-[defaults]
8-plrclr0_r=2
9-plrclr0_g=2
10-plrclr0_b=74
11-plrclr1_r=2
12-plrclr1_g=2
13-plrclr1_b=112
14-plrclr2_r=2
15-plrclr2_g=2
16-plrclr2_b=149
17-plrclr3_r=2
18-plrclr3_g=2
19-plrclr3_b=198
20-
21 [tribe]
22 author=_ The Widelands Development Team
23 name=_ Atlanteans
24@@ -27,6 +13,7 @@
25 name=frontier
26 pics=pics/frontier_??.png
27 hotspot=3 12
28+playercolor=true
29
30 # Not just a plain color, maybe a cross or some stribes
31 [flag]
32
33=== modified file 'tribes/atlanteans/pics/frontier_00.png' (properties changed: -x to +x)
34Binary files tribes/atlanteans/pics/frontier_00.png 2009-11-11 19:21:34 +0000 and tribes/atlanteans/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ
35=== added file 'tribes/atlanteans/pics/frontier_00_pc.png'
36Binary files tribes/atlanteans/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/atlanteans/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ
37=== modified file 'tribes/barbarians/conf' (properties changed: -x to +x)
38--- tribes/barbarians/conf 2010-04-17 11:49:40 +0000
39+++ tribes/barbarians/conf 2010-04-28 16:03:43 +0000
40@@ -1,23 +1,9 @@
41 # Comments are for graphic designers some ideas
42
43-[defaults]
44-plrclr0_r=2
45-plrclr0_g=2
46-plrclr0_b=74
47-plrclr1_r=2
48-plrclr1_g=2
49-plrclr1_b=112
50-plrclr2_r=2
51-plrclr2_g=2
52-plrclr2_b=149
53-plrclr3_r=2
54-plrclr3_g=2
55-plrclr3_b=198
56-
57 [tribe]
58 author=_The Widelands Development Team
59 name=_Barbarians
60-descr=_The mighty tribes of the eastern lands!
61+descr=_The mighty tribes of the east-lands!
62 bob_vision_range=2
63 uiposition=10
64 carrier2=ox
65@@ -27,6 +13,7 @@
66 name=frontier
67 pics=pics/frontier_??.png
68 hotspot=1 19
69+playercolor=true
70
71 # Not just a plain color, maybe a cross or some stribes
72 [flag]
73@@ -218,6 +205,10 @@
74 scouts_hut=_"Scout's Hut"
75 cattlefarm=_Cattle Farm
76
77+[initializations]
78+headquarters_medium=_Headquarters medium
79+castle_village=_Citadel village
80+
81 [military_data]
82 retreat_interval=0-80
83 retreat=20
84
85=== modified file 'tribes/barbarians/pics/frontier_00.png' (properties changed: -x to +x)
86Binary files tribes/barbarians/pics/frontier_00.png 2005-12-29 01:10:07 +0000 and tribes/barbarians/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ
87=== added file 'tribes/barbarians/pics/frontier_00_pc.png'
88Binary files tribes/barbarians/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/barbarians/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ
89=== modified file 'tribes/empire/conf' (properties changed: -x to +x)
90--- tribes/empire/conf 2010-04-17 11:39:28 +0000
91+++ tribes/empire/conf 2010-04-28 16:03:43 +0000
92@@ -1,19 +1,5 @@
93 # Comments are for graphic designers some ideas
94
95-[defaults]
96-plrclr0_r=2
97-plrclr0_g=2
98-plrclr0_b=74
99-plrclr1_r=2
100-plrclr1_g=2
101-plrclr1_b=112
102-plrclr2_r=2
103-plrclr2_g=2
104-plrclr2_b=149
105-plrclr3_r=2
106-plrclr3_g=2
107-plrclr3_b=198
108-
109 [tribe]
110 author=_The Widelands Development Team
111 name=_Empire
112@@ -27,6 +13,7 @@
113 name=frontier
114 pics=pics/frontier_??.png
115 hotspot=1 19
116+playercolor=true
117
118 # Not just a plain color, maybe a cross or some stribes
119 [flag]
120@@ -212,6 +199,10 @@
121 scouts_house=_"Scout's House"
122 donkeyfarm=_Donkeyfarm
123
124+[initializations]
125+headquarters_medium=_Headquarters medium
126+castle_village=_Castle village
127+
128 [military_data]
129 retreat_interval=10-90
130 retreat=50
131
132=== modified file 'tribes/empire/pics/frontier_00.png' (properties changed: -x to +x)
133Binary files tribes/empire/pics/frontier_00.png 2009-11-12 11:55:09 +0000 and tribes/empire/pics/frontier_00.png 2010-04-28 16:03:43 +0000 differ
134=== added file 'tribes/empire/pics/frontier_00_pc.png'
135Binary files tribes/empire/pics/frontier_00_pc.png 1970-01-01 00:00:00 +0000 and tribes/empire/pics/frontier_00_pc.png 2010-04-28 16:03:43 +0000 differ

Subscribers

People subscribed via source and target branches

to status/vote changes: