Merge lp:~carsteng/ubuntu-docs/trusty into lp:ubuntu-docs/trusty

Proposed by Carsten Gerlach
Status: Merged
Approved by: Doug Smythies
Approved revision: no longer in the source branch.
Merged at revision: 398
Proposed branch: lp:~carsteng/ubuntu-docs/trusty
Merge into: lp:ubuntu-docs/trusty
Diff against target: 21 lines (+2/-2)
1 file modified
ubuntu-help/C/addremove-sources.page (+2/-2)
To merge this branch: bzr merge lp:~carsteng/ubuntu-docs/trusty
Reviewer Review Type Date Requested Status
Doug Smythies Approve
Gunnar Hjalmarsson Approve
Review via email: mp+212327@code.launchpad.net

Commit message

entry in sources.list updated from »saucy« to »trusty«

Description of the change

in the sources.list should now be »trusty« instead of »saucy«

To post a comment you must log in.
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Hi Carsten!

You know that doc string freeze has passed, don't you?
https://wiki.ubuntu.com/DocumentationStringFreeze

So my first thought was that this can't be dealt with before the 14.04 release.

But then I realized that it makes no sense for the translators to change those particular strings, so I'm going to merge it, and add a couple of things that make the strings explicitly nontranslatable.

Maybe that's what you thought in the first place. Or you are just lucky. ;-)

review: Approve
Revision history for this message
Doug Smythies (dsmythies) wrote :

Even though we are past string freeze, this one should be fine to merge in. The strings are within code tags and are not translatable anyhow. Although I do observe that often the same string is set as the translation, I suppose to it get off the "untranslated" list. The issue is that we typically never re-import the .POT file after string freeze, so this wouldn't get into the other languages anyhow

review: Approve
Revision history for this message
Carsten Gerlach (carsteng) wrote :
Revision history for this message
Kevin Godby (godbyk) wrote :

In some of the updated .page files, we've marked the email addresses as untranslatable.

The only reason I could think of having the names be translatable is in case they need to be transliterated to a different alphabet/orthography.

lp:~carsteng/ubuntu-docs/trusty updated
398. By Carsten Gerlach

addremove-sources.page: saucy replaced with trusty in sources.list entries.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Just merged...

@Doug: Nothing prevents us from importing the template again, does it?

@Carsten: Yeah, there are a lot of such strings that occur in the PO files for no reasonable reason. A suitable project to take on later on.

@Kevin: Would /etc/apt/sources.list be happy with e.g. Chinese? I suspect not.

Revision history for this message
Kevin Godby (godbyk) wrote :

This shouldn't prevent us from importing the template again, since we're moving strings instead of adding them.

/etc/apt/sources.list doesn't contain names like 'Gunnar Hjalmarasson'. But the Chinese might like to transliterate Gunnar to hanzi.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

On 2014-03-23 21:53, Kevin Godby wrote:
> But the Chinese might like to transliterate Gunnar to hanzi.

They just dare! ;-)

Revision history for this message
Doug Smythies (dsmythies) wrote :

"Doug, the strings are translatable, see "
O.K. what I meant to say was that they have to verbatim what was originally written.
Anyway, I see that Gunnar set them to untranslatable, which is the proper solution.

"@Doug: Nothing prevents us from importing the template again, does it?" Matt East cautioned me against it, but I can not recall why. Give me some time to try to find my notes. (I could also be recalling incorrectly.)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntu-help/C/addremove-sources.page'
--- ubuntu-help/C/addremove-sources.page 2014-01-06 21:56:33 +0000
+++ ubuntu-help/C/addremove-sources.page 2014-03-23 19:31:00 +0000
@@ -67,7 +67,7 @@
67 similar to:67 similar to:
68 </p>68 </p>
69 <p>69 <p>
70 <code>deb http://archive.ubuntu.com/ubuntu/ saucy main</code>70 <code>deb http://archive.ubuntu.com/ubuntu/ trusty main</code>
71 </p>71 </p>
72 </item>72 </item>
73 <item>73 <item>
@@ -99,7 +99,7 @@
99 <gui>Add</gui> and enter:99 <gui>Add</gui> and enter:
100 </p>100 </p>
101 <p>101 <p>
102 <code>deb http://archive.canonical.com/ubuntu saucy partner</code>102 <code>deb http://archive.canonical.com/ubuntu trusty partner</code>
103 </p>103 </p>
104 <p>104 <p>
105 Click <gui>Add Source</gui> then close the Software Sources window. Wait a 105 Click <gui>Add Source</gui> then close the Software Sources window. Wait a

Subscribers

People subscribed via source and target branches