Merge lp:~canonical-ci-engineering/charms/precise/gunicorn/fix-config-changed-departed into lp:~charmers/charms/precise/gunicorn/trunk
Proposed by
Andy Doan
Status: | Rejected |
---|---|
Rejected by: | Matt Bruzek |
Proposed branch: | lp:~canonical-ci-engineering/charms/precise/gunicorn/fix-config-changed-departed |
Merge into: | lp:~charmers/charms/precise/gunicorn/trunk |
Diff against target: |
65 lines (+13/-8) 2 files modified
hooks/hooks.py (+6/-4) hooks/tests/test_hooks.py (+7/-4) |
To merge this branch: | bzr merge lp:~canonical-ci-engineering/charms/precise/gunicorn/fix-config-changed-departed |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matt Bruzek (community) | Needs Fixing | ||
Evan (community) | Approve | ||
Review via email: mp+213338@code.launchpad.net |
Description of the change
fix config-changed and wsgi_file_
These were depending on "remote unit" for the service name that's
only available in those contexts. This saves the service name so
that config-changed and wsgi_file_
with the upstart file.
To post a comment you must log in.
Can we have a comment in the code for why __unit__ is needed? I want to make sure that when we try to merge back to gunicorn trunk, they understand the rationale behind all the changes without having to endlessly dig through bzr logs.
Otherwise, +1.