Code review comment for lp:~canonical-ci-engineering/charms/precise/gunicorn/fix-config-changed-departed

Revision history for this message
Simon Davy (bloodearnest) wrote :

Heya, I have a branch pending that fixes this issue, but differently. It also provides support for an upgrade path for those using the older env_extra relation paramter format.

https://code.launchpad.net/~bloodearnest/charms/precise/gunicorn/upgrade-path/+merge/213236

My solution was like yours to just use the gunicorn unit name rather than the remote unit name (which was the original authors design). I did not bother saving it, as it is always available to all gunicorn hooks, but maybe I missed some detail?

Be good to coordinate these landing.

« Back to merge proposal