Code review comment for lp:~canonical-ci-engineering/charms/precise/gunicorn/fix-config-changed-departed

Revision history for this message
Andy Doan (doanac) wrote :

On 04/02/2014 10:54 AM, Simon Davy wrote:
> Ah, so it does.
>
> I'm not too bothered on the upstart name either way, tbh. Given that a user shouldn't really need to manually restart gunicorn often, I don't think it matters that much. Slight preference for just using local_unit to reduce the complexity of the charm slightly, but it's not a big deal.

+1 for me then. I just really want to get a fix upstreamed so my team
doesn't have to carry this patch along.

« Back to merge proposal