Merge lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364 into lp:ubuntu/oneiric/gnomebaker

[Bones]

[Scott Moser (smoser)]

Hi,
  This looks like a trivial enough fix, and I assume someone can easily upload it to oneiric (I do not have access to do so).
  The one thing that should be changed is the release string (from 'natty' to 'oneiric') in the changelog entry. This does not seem like an important enough change to make it into an SRU, so we would normally fix it in the development release only.

  The other change is that you should specify your full email address in the changelog. You can do that by setting the environment variables DEBEMAIL and DEBFULLNAME. then 'dch' will use those values. Ie, in ~/.profile, you can set
  export <email address hidden>
  export DEBFULLNAME="Tim Biddington"

review: Needs Fixing

[Bones (bones)]

Ah ok,

So not being accepted as an SRU means it won't go back into 10.04, 10.10 and
so on correct? Is the current development of 11.10 still accepting changes
like these anyway?

Thanks

On 23 August 2011 01:31, Scott Moser <email address hidden> wrote:

> Review: Needs Fixing
> Hi,
> This looks like a trivial enough fix, and I assume someone can easily
> upload it to oneiric (I do not have access to do so).
> The one thing that should be changed is the release string (from 'natty'
> to 'oneiric') in the changelog entry. This does not seem like an important
> enough change to make it into an SRU, so we would normally fix it in the
> development release only.
>
> The other change is that you should specify your full email address in the
> changelog. You can do that by setting the environment variables DEBEMAIL
> and DEBFULLNAME. then 'dch' will use those values. Ie, in ~/.profile, you
> can set
> export <email address hidden>
> export DEBFULLNAME="Tim Biddington"
>
> --
>
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> You are the owner of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364.
>

[Scott Moser (smoser)]

yes, this can make it into oneiric/11.10

On Aug 22, 2011, at 6:35 PM, Bones <email address hidden> wrote:

> Ah ok,
>
> So not being accepted as an SRU means it won't go back into 10.04, 10.10 and
> so on correct? Is the current development of 11.10 still accepting changes
> like these anyway?
>
> Thanks
>
> On 23 August 2011 01:31, Scott Moser <email address hidden> wrote:
>
>> Review: Needs Fixing
>> Hi,
>> This looks like a trivial enough fix, and I assume someone can easily
>> upload it to oneiric (I do not have access to do so).
>> The one thing that should be changed is the release string (from 'natty'
>> to 'oneiric') in the changelog entry. This does not seem like an important
>> enough change to make it into an SRU, so we would normally fix it in the
>> development release only.
>>
>> The other change is that you should specify your full email address in the
>> changelog. You can do that by setting the environment variables DEBEMAIL
>> and DEBFULLNAME. then 'dch' will use those values. Ie, in ~/.profile, you
>> can set
>> export <email address hidden>
>> export DEBFULLNAME="Tim Biddington"
>>
>> --
>>
>> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
>> You are the owner of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364.
>>
>
> --
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> You are reviewing the proposed merge of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364 into lp:ubuntu/gnomebaker.
>

[Bones (bones)]

Thanks for your help Scott.

As a side note, I am new to Ubuntu dev, and I was using typo changes as a
way to learn the development process; from reading the "getting started"
material I had never heard of SRU. In future how do I identify a feature I'm
working on will an be a available as an SRU?

Thanks again.

Tim

On 23 August 2011 10:22, Scott Moser <email address hidden> wrote:

> yes, this can make it into oneiric/11.10
>
> On Aug 22, 2011, at 6:35 PM, Bones <email address hidden> wrote:
>
> > Ah ok,
> >
> > So not being accepted as an SRU means it won't go back into 10.04, 10.10
> and
> > so on correct? Is the current development of 11.10 still accepting
> changes
> > like these anyway?
> >
> > Thanks
> >
> > On 23 August 2011 01:31, Scott Moser <email address hidden> wrote:
> >
> >> Review: Needs Fixing
> >> Hi,
> >> This looks like a trivial enough fix, and I assume someone can easily
> >> upload it to oneiric (I do not have access to do so).
> >> The one thing that should be changed is the release string (from 'natty'
> >> to 'oneiric') in the changelog entry. This does not seem like an
> important
> >> enough change to make it into an SRU, so we would normally fix it in the
> >> development release only.
> >>
> >> The other change is that you should specify your full email address in
> the
> >> changelog. You can do that by setting the environment variables
> DEBEMAIL
> >> and DEBFULLNAME. then 'dch' will use those values. Ie, in ~/.profile,
> you
> >> can set
> >> export <email address hidden>
> >> export DEBFULLNAME="Tim Biddington"
> >>
> >> --
> >>
> >>
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> >> You are the owner of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364.
> >>
> >
> > --
> >
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> > You are reviewing the proposed merge of
> lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364 into
> lp:ubuntu/gnomebaker.
> >
>
> --
>
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> You are the owner of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364.
>

[Scott Moser (smoser)]

On Thu, 25 Aug 2011, Bones wrote:

> Thanks for your help Scott.
>
> As a side note, I am new to Ubuntu dev, and I was using typo changes as a
> way to learn the development process; from reading the "getting started"
> material I had never heard of SRU. In future how do I identify a feature I'm
> working on will an be a available as an SRU?

Well, SRU is described at https://wiki.ubuntu.com/StableReleaseUpdates .
See the 'When' section specifically.

As part of that policy, the bug is supposed to be fixed in the development
release first, and then can be SRU'd. So fixes are *always* first done
against development release, and then applied to stable releases only if
they meant the criteria there.

I hope that makes sense. Thanks for getting involved in Ubuntu.

[Bones (bones)]

Yeah, cleared it all up.

Thanks again.

On 26 August 2011 11:43, Scott Moser <email address hidden> wrote:

> On Thu, 25 Aug 2011, Bones wrote:
>
> > Thanks for your help Scott.
> >
> > As a side note, I am new to Ubuntu dev, and I was using typo changes as a
> > way to learn the development process; from reading the "getting started"
> > material I had never heard of SRU. In future how do I identify a feature
> I'm
> > working on will an be a available as an SRU?
>
> Well, SRU is described at https://wiki.ubuntu.com/StableReleaseUpdates .
> See the 'When' section specifically.
>
> As part of that policy, the bug is supposed to be fixed in the development
> release first, and then can be SRU'd. So fixes are *always* first done
> against development release, and then applied to stable releases only if
> they meant the criteria there.
>
> I hope that makes sense. Thanks for getting involved in Ubuntu.
>
> --
>
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> You are the owner of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364.
>

[Michael Terry (mterry)]

Hi! So I would normally approve this, except for two things:

1) Most importantly, this package has been removed from Debian and Ubuntu because it is "obsolete, dead upstream, unmaintained, doesn't work with current kernels."

2) Even if it hadn't been removed, this was a package that we got from Debian. Since Ubuntu loves to be in sync with Debian where possible, this change isn't important enough to carry a delta from Debian for it. So I would have forwarded this patch on to Debian for you, but not committed it to Ubuntu. https://wiki.ubuntu.com/Debian/ForUbuntuDevelopers

Regardless, thanks for the effort and I'm glad you're learning Ubuntu development!

review: Disapprove

Unmerged revisions

25. By Bones <email address hidden> on 2011-08-03

Corrected spelling mistake: "formating" to "formatting"

=== modified file 'debian/changelog'
--- debian/changelog	2010-03-30 17:49:52 +0000
+++ debian/changelog	2011-08-03 00:13:32 +0000
@@ -1,3 +1,9 @@
+gnomebaker (0.6.4-1ubuntu2) natty; urgency=low
+
+  * debian/control: corrected spelling mistake "formating" to "formatting" (LP: #818364)
+
+ -- Bones <bones@bones-VirtualBox>  Wed, 03 Aug 2011 10:06:20 +1000
+
 gnomebaker (0.6.4-1ubuntu1) lucid; urgency=low
 
   * debian/patches/03_fix_random_crashes.dpatch: Fix random crashes

=== modified file 'debian/control'
--- debian/control	2010-03-30 17:49:52 +0000
+++ debian/control	2011-08-03 00:13:32 +0000
@@ -16,7 +16,7 @@
  Gnomebaker is an easy to use CD/DVD burner. Its current features include:
    * Data and audio CD burning
    * Multisession CDs
-   * DVD formating
+   * DVD formatting
    * DVD data disk burning
    * On-the-fly data CD burning
    * Cue bin data CD writing