Code review comment for lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364

Thanks for your help Scott.

As a side note, I am new to Ubuntu dev, and I was using typo changes as a
way to learn the development process; from reading the "getting started"
material I had never heard of SRU. In future how do I identify a feature I'm
working on will an be a available as an SRU?

Thanks again.

Tim

On 23 August 2011 10:22, Scott Moser <email address hidden> wrote:

> yes, this can make it into oneiric/11.10
>
> On Aug 22, 2011, at 6:35 PM, Bones <email address hidden> wrote:
>
> > Ah ok,
> >
> > So not being accepted as an SRU means it won't go back into 10.04, 10.10
> and
> > so on correct? Is the current development of 11.10 still accepting
> changes
> > like these anyway?
> >
> > Thanks
> >
> > On 23 August 2011 01:31, Scott Moser <email address hidden> wrote:
> >
> >> Review: Needs Fixing
> >> Hi,
> >> This looks like a trivial enough fix, and I assume someone can easily
> >> upload it to oneiric (I do not have access to do so).
> >> The one thing that should be changed is the release string (from 'natty'
> >> to 'oneiric') in the changelog entry. This does not seem like an
> important
> >> enough change to make it into an SRU, so we would normally fix it in the
> >> development release only.
> >>
> >> The other change is that you should specify your full email address in
> the
> >> changelog. You can do that by setting the environment variables
> DEBEMAIL
> >> and DEBFULLNAME. then 'dch' will use those values. Ie, in ~/.profile,
> you
> >> can set
> >> export <email address hidden>
> >> export DEBFULLNAME="Tim Biddington"
> >>
> >> --
> >>
> >>
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> >> You are the owner of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364.
> >>
> >
> > --
> >
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> > You are reviewing the proposed merge of
> lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364 into
> lp:ubuntu/gnomebaker.
> >
>
> --
>
> https://code.launchpad.net/~bones/ubuntu/oneiric/gnomebaker/fix-for-818364/+merge/70234
> You are the owner of lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364.
>