Code review comment for lp:~bones/ubuntu/oneiric/gnomebaker/fix-for-818364

Revision history for this message
Scott Moser (smoser) wrote :

Hi,
  This looks like a trivial enough fix, and I assume someone can easily upload it to oneiric (I do not have access to do so).
  The one thing that should be changed is the release string (from 'natty' to 'oneiric') in the changelog entry. This does not seem like an important enough change to make it into an SRU, so we would normally fix it in the development release only.

  The other change is that you should specify your full email address in the changelog. You can do that by setting the environment variables DEBEMAIL and DEBFULLNAME. then 'dch' will use those values. Ie, in ~/.profile, you can set
  export <email address hidden>
  export DEBFULLNAME="Tim Biddington"

review: Needs Fixing

« Back to merge proposal