address-book-app

Merge lp:~bfiller/address-book-app/input-hints into lp:address-book-app

  1. input-hints
  2. Merge into trunk
Proposed by Bill Filler
Status: Superseded
Proposed branch: lp:~bfiller/address-book-app/input-hints
Merge into: lp:address-book-app
Diff against target: 69 lines (+7/-0)
5 files modified
src/imports/ContactEdit/ContactDetailEmailsEditor.qml (+1/-0)
src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml (+2/-0)
src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml (+1/-0)
src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml (+1/-0)
src/imports/ContactEdit/ContactDetailWithTypeEditor.qml (+2/-0)
To merge this branch: bzr merge lp:~bfiller/address-book-app/input-hints
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Bill Filler Pending
Tiago Salem Herrmann Pending
Review via email: mp+184232@code.launchpad.net

This proposal supersedes a proposal from 2013-08-19.

This proposal has been superseded by a proposal from 2013-09-11.

Commit message

merge latest from trunk

Description of the change

merge latest from trunk

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:52
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/114/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-amd64-ci/114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/115
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-i386-ci/114

Click here to trigger a rebuild:
http://s-jenkins:8080/job/address-book-app-ci/114/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote : Posted in a previous version of this proposal

Using Qt.ImhDialableCharactersOnly prevents the user to add some common phone number characters, like parentheses, comma and hyphen. Also, the button '+*' in the osk does not work at all.

review: Needs Information
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote : Posted in a previous version of this proposal

> Using Qt.ImhDialableCharactersOnly prevents the user to add some common phone
> number characters, like parentheses, comma and hyphen. Also, the button '+*'
> in the osk does not work at all.

I do not think the parentheses, comma and hyphen should be accepted. Since they are not DialableCharacters. As the enum says.

About the "+*" there is a related bug report on Qt: https://bugreports.qt-project.org/browse/QTBUG-13696

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote : Posted in a previous version of this proposal

In general we normalize the phone numbers before making calls. So the non diable characters wouldn't be a problem.
It is commom to use () for area codes. IMO we should allow users to enter those chars
Also, comma should be considered as diable, it means to stop a second before dialing the next numbers, used mostly to call extensions IIRC.

Revision history for this message
Bill Filler (bfiller) wrote : Posted in a previous version of this proposal

I think the MR is fine, but the OSK layout is totally broken for phone numbers, both in layout and certain characters not working. Lets hold off on landing this until the OSK is fixed.

review: Abstain
Revision history for this message
Bill Filler (bfiller) wrote : Posted in a previous version of this proposal

btw, the email layout seems ok but not sure it's worth reverting the phone number code or just wait till osk fixed

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:53
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/129/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-amd64-ci/129/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/130
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/130/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-i386-ci/129
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3071/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/632/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3077/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/634/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/address-book-app-ci/129/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:53
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/131/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-amd64-ci/131
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/132
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/132/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-i386-ci/131
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3094/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/654/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3100
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2593
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/656
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/656/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/address-book-app-ci/131/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/imports/ContactEdit/ContactDetailEmailsEditor.qml'
--- src/imports/ContactEdit/ContactDetailEmailsEditor.qml 2013-07-25 21:16:28 +0000
+++ src/imports/ContactEdit/ContactDetailEmailsEditor.qml 2013-09-06 05:01:56 +0000
@@ -25,4 +25,5 @@
25 detailType: QtContacts.ContactDetail.Email25 detailType: QtContacts.ContactDetail.Email
26 fields: [ 0 ]26 fields: [ 0 ]
27 placeholderTexts: [ i18n.tr("Enter an email address") ]27 placeholderTexts: [ i18n.tr("Enter an email address") ]
28 inputMethodHints: Qt.ImhEmailCharactersOnly
28}29}
2930
=== modified file 'src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml'
--- src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml 2013-07-26 00:19:09 +0000
+++ src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml 2013-09-06 05:01:56 +0000
@@ -28,6 +28,7 @@
28 property int currentItem: -128 property int currentItem: -1
29 property int fieldType: QtContacts.ContactDetail.FieldContext29 property int fieldType: QtContacts.ContactDetail.FieldContext
30 property variant placeholderTexts: []30 property variant placeholderTexts: []
31 property variant inputMethodHints
3132
32 function save() {33 function save() {
33 var changed = false34 var changed = false
@@ -137,6 +138,7 @@
137 height: implicitHeight138 height: implicitHeight
138 width: root.width139 width: root.width
139140
141 inputMethodHints: root.inputMethodHints
140 onDetailChanged: updateCombo(false)142 onDetailChanged: updateCombo(false)
141143
142 // this is necessary due the default property of ListItem.Empty144 // this is necessary due the default property of ListItem.Empty
143145
=== modified file 'src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml'
--- src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml 2013-07-31 19:36:55 +0000
+++ src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml 2013-09-06 05:01:56 +0000
@@ -27,4 +27,5 @@
27 fields: [ QtContacts.OnlineAccount.AccountUri ]27 fields: [ QtContacts.OnlineAccount.AccountUri ]
28 placeholderTexts: [ i18n.tr("Enter a social alias") ]28 placeholderTexts: [ i18n.tr("Enter a social alias") ]
29 typeModel: ContactDetailOnlineAccountTypeModel { }29 typeModel: ContactDetailOnlineAccountTypeModel { }
30 inputMethodHints: Qt.ImhEmailCharactersOnly
30}31}
3132
=== modified file 'src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml'
--- src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml 2013-07-31 19:36:55 +0000
+++ src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml 2013-09-06 05:01:56 +0000
@@ -27,4 +27,5 @@
27 fields: [ QtContacts.PhoneNumber.Number ]27 fields: [ QtContacts.PhoneNumber.Number ]
28 placeholderTexts: [ i18n.tr("Enter a number") ]28 placeholderTexts: [ i18n.tr("Enter a number") ]
29 typeModel: ContactDetailPhoneNumberTypeModel { }29 typeModel: ContactDetailPhoneNumberTypeModel { }
30 inputMethodHints: Qt.ImhDialableCharactersOnly
30}31}
3132
=== modified file 'src/imports/ContactEdit/ContactDetailWithTypeEditor.qml'
--- src/imports/ContactEdit/ContactDetailWithTypeEditor.qml 2013-08-28 17:06:38 +0000
+++ src/imports/ContactEdit/ContactDetailWithTypeEditor.qml 2013-09-06 05:01:56 +0000
@@ -29,6 +29,7 @@
29 property int fieldType: -129 property int fieldType: -1
30 property alias selectedTypeIndex: detailTypeSelector.currentIndex30 property alias selectedTypeIndex: detailTypeSelector.currentIndex
31 property variant placeholderTexts: []31 property variant placeholderTexts: []
32 property var inputMethodHints
3233
33 function selectType(type) {34 function selectType(type) {
34 detailTypeSelector.selectItem(type)35 detailTypeSelector.selectItem(type)
@@ -106,6 +107,7 @@
106 detail: root.detail107 detail: root.detail
107 field: modelData108 field: modelData
108 placeholderText: root.placeholderTexts[index]109 placeholderText: root.placeholderTexts[index]
110 inputMethodHints: root.inputMethodHints
109111
110 anchors {112 anchors {
111 left: parent.left113 left: parent.left

Subscribers

People subscribed via source and target branches