Merge lp:~renatofilho/address-book-app/input-hint into lp:address-book-app

[Renato Araujo Oliveira Filho]

Used the correct input hint for each input field.

[lp:~renatofilho/address-book-app/input-hint]

52. By Renato Araujo Oliveira Filho on 2013-08-19

Used the correct input hint for each input field.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:52
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/114/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-amd64-ci/114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/115
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-armhf-ci/115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-saucy-i386-ci/114

Click here to trigger a rebuild:
http://s-jenkins:8080/job/address-book-app-ci/114/rebuild

review: Approve (continuous-integration)

[Tiago Salem Herrmann (tiagosh)]

Using Qt.ImhDialableCharactersOnly prevents the user to add some common phone number characters, like parentheses, comma and hyphen. Also, the button '+*' in the osk does not work at all.

review: Needs Information

[Renato Araujo Oliveira Filho (renatofilho)]

> Using Qt.ImhDialableCharactersOnly prevents the user to add some common phone
> number characters, like parentheses, comma and hyphen. Also, the button '+*'
> in the osk does not work at all.

I do not think the parentheses, comma and hyphen should be accepted. Since they are not DialableCharacters. As the enum says.

About the "+*" there is a related bug report on Qt: https://bugreports.qt-project.org/browse/QTBUG-13696

[Tiago Salem Herrmann (tiagosh)]

In general we normalize the phone numbers before making calls. So the non diable characters wouldn't be a problem.
It is commom to use () for area codes. IMO we should allow users to enter those chars
Also, comma should be considered as diable, it means to stop a second before dialing the next numbers, used mostly to call extensions IIRC.

[Bill Filler (bfiller)]

I think the MR is fine, but the OSK layout is totally broken for phone numbers, both in layout and certain characters not working. Lets hold off on landing this until the OSK is fixed.

review: Abstain

[Bill Filler (bfiller)]

btw, the email layout seems ok but not sure it's worth reverting the phone number code or just wait till osk fixed

Unmerged revisions

=== modified file 'src/imports/ContactEdit/ContactDetailEmailsEditor.qml'
--- src/imports/ContactEdit/ContactDetailEmailsEditor.qml	2013-07-25 21:16:28 +0000
+++ src/imports/ContactEdit/ContactDetailEmailsEditor.qml	2013-08-19 02:53:53 +0000
@@ -25,4 +25,5 @@
     detailType: QtContacts.ContactDetail.Email
     fields: [ 0 ]
     placeholderTexts: [ i18n.tr("Enter an email address") ]
+    inputMethodHints: Qt.ImhEmailCharactersOnly
 }

=== modified file 'src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml'
--- src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml	2013-07-26 00:19:09 +0000
+++ src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml	2013-08-19 02:53:53 +0000
@@ -28,6 +28,7 @@
     property int currentItem: -1
     property int fieldType: QtContacts.ContactDetail.FieldContext
     property variant placeholderTexts: []
+    property variant inputMethodHints
 
     function save() {
         var changed = false
@@ -137,6 +138,7 @@
         height: implicitHeight
         width: root.width
 
+        inputMethodHints: root.inputMethodHints
         onDetailChanged: updateCombo(false)
 
         // this is necessary due the default property of ListItem.Empty

=== modified file 'src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml'
--- src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml	2013-07-31 19:36:55 +0000
+++ src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml	2013-08-19 02:53:53 +0000
@@ -27,4 +27,5 @@
     fields: [ QtContacts.OnlineAccount.AccountUri ]
     placeholderTexts: [ i18n.tr("Enter a social alias") ]
     typeModel: ContactDetailOnlineAccountTypeModel { }
+    inputMethodHints: Qt.ImhEmailCharactersOnly
 }

=== modified file 'src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml'
--- src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml	2013-07-31 19:36:55 +0000
+++ src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml	2013-08-19 02:53:53 +0000
@@ -27,4 +27,5 @@
     fields: [ QtContacts.PhoneNumber.Number ]
     placeholderTexts: [ i18n.tr("Enter a number") ]
     typeModel: ContactDetailPhoneNumberTypeModel { }
+    inputMethodHints: Qt.ImhDialableCharactersOnly
 }

=== modified file 'src/imports/ContactEdit/ContactDetailWithTypeEditor.qml'
--- src/imports/ContactEdit/ContactDetailWithTypeEditor.qml	2013-07-26 00:19:09 +0000
+++ src/imports/ContactEdit/ContactDetailWithTypeEditor.qml	2013-08-19 02:53:53 +0000
@@ -29,6 +29,7 @@
     property int fieldType: -1
     property alias selectedTypeIndex: detailTypeSelector.currentIndex
     property variant placeholderTexts: []
+    property var inputMethodHints
 
     function selectType(type) {
         detailTypeSelector.selectItem(type)
@@ -98,6 +99,7 @@
                 detail: root.detail
                 field: modelData
                 placeholderText: root.placeholderTexts[index]
+                inputMethodHints: root.inputMethodHints
 
                 anchors {
                     left: parent.left