address-book-app

Code review comment for lp:~renatofilho/address-book-app/input-hint

  1. input-hint
  2. Merge into trunk
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Using Qt.ImhDialableCharactersOnly prevents the user to add some common phone
> number characters, like parentheses, comma and hyphen. Also, the button '+*'
> in the osk does not work at all.

I do not think the parentheses, comma and hyphen should be accepted. Since they are not DialableCharacters. As the enum says.

About the "+*" there is a related bug report on Qt: https://bugreports.qt-project.org/browse/QTBUG-13696

« Back to merge proposal