Merge ~alexsander-souza/maas:lp1989567 into maas:master

[Alexsander de Souza]

fix flaky test_update_allows_new_connections_while_updating_connections_in_db

fixes LP#1989567

avoid conn_id collision

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1989567 lp:~alexsander-souza/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 3ecc8bbdba047458d5eae098aebccc8e97d6dd41

review: Approve

[Jack Lloyd-Walters (lloydwaltersj)]

+1, I appreciate the simplicity of the solution!

review: Approve

diff --git a/src/maasserver/tests/test_ipc.py b/src/maasserver/tests/test_ipc.py
index 19344fd..b26c209 100644
--- a/src/maasserver/tests/test_ipc.py
+++ b/src/maasserver/tests/test_ipc.py
@@ -594,10 +594,10 @@ class TestIPCCommunication(MAASTransactionServerTestCase):
 
         rack_controller = yield deferToDatabase(factory.make_RackController)
 
-        for _ in range(2):
+        for i in range(2):
             master.registerWorkerRPCConnection(
                 pid,
-                random.randint(1, 512),
+                i,
                 rack_controller.system_id,
                 ip,
                 random.randint(1, 512),
@@ -608,7 +608,7 @@ class TestIPCCommunication(MAASTransactionServerTestCase):
                 master.update(),
                 master.registerWorkerRPCConnection(
                     pid,
-                    random.randint(1, 512),
+                    3,
                     rack_controller.system_id,
                     ip,
                     random.randint(1, 512),