Merge lp:~ajeans/bzr/fix-40103-status-on-ignored into lp:bzr
Proposed by
Arnaud Jeansen
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Robert Collins | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~ajeans/bzr/fix-40103-status-on-ignored | ||||
Merge into: | lp:bzr | ||||
Diff against target: |
68 lines (+47/-0) 2 files modified
bzrlib/status.py (+14/-0) bzrlib/tests/blackbox/test_status.py (+33/-0) |
||||
To merge this branch: | bzr merge lp:~ajeans/bzr/fix-40103-status-on-ignored | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Needs Fixing | ||
Martin Pool | Needs Fixing | ||
Review via email: mp+22486@code.launchpad.net |
Commit message
Inform users that a file specified to commit is an ignored unversioned file.
Description of the change
This branch adds a warning when the user issues a status command on a given file, but the file is unversioned *and* should be ignored. A unit test is added to show the new behaviour
LP: #40103 has more details
To post a comment you must log in.
Thanks for tackling this and thanks for giving a good cover letter including the bug link - it makes it much easier to review.
I think this is a bit overspecific to the case of giving just one ignored file; if I said
bzr st foo~ bar~
and they were both ignored I would still find it strange if this just said nothing.
Now in the output format perhaps it is better not to give a warning but rather to show them under the heading 'ignored':
% bzr st foo~ bar~
ignored:
foo~
bar~
that might be more adaptable to other presentations of the status output too.
hth