Code review comment for lp:~ajeans/bzr/fix-40103-status-on-ignored

On 1 April 2010 03:17, Arnaud Jeansen <email address hidden> wrote:
> Thanks for the quick reply Martin,
>
> I was looking for an easy fix to a very specific case. If we want to be complete, we need to answer the following questions (where 'we' translates to 'you' :))
>
> 1) "ignored:\n foo~\n bar~\n" looks similar to the "normal" output, so to be consistent we should also handle short output with something like "I  foo~\nI  bar~". Does it look correct to you ?
>
> 2) If we output a list of ignored files, in which conditions do we make it appear ?
>   a) Display ignored files whatever the case (even for a general "bzr status")
>   b) Display ignored files when specific files have been fed (only for "bzr status foo~ bar~")
>   c) Display ignored files when specifc files have been fed, and no other status is present (for "bzr status foo*" and only if there is not a versioned 'foo' file)
>
> I would be in favor of 1)handling short and 2)c), which is the less intrusive change.

I would have said 1 and 2b, if I'm understanding you correctly. All
the files you name on the command line should be included in the
output, even if some or all of them are ignored. That seems probably
simplest for the user.

--
Martin <http://launchpad.net/~mbp/>