Code review comment for lp:~ajeans/bzr/fix-40103-status-on-ignored

Revision history for this message
Martin Pool (mbp) wrote :

Thanks for tackling this and thanks for giving a good cover letter including the bug link - it makes it much easier to review.

I think this is a bit overspecific to the case of giving just one ignored file; if I said

 bzr st foo~ bar~

and they were both ignored I would still find it strange if this just said nothing.

Now in the output format perhaps it is better not to give a warning but rather to show them under the heading 'ignored':

  % bzr st foo~ bar~
  ignored:
    foo~
    bar~

that might be more adaptable to other presentations of the status output too.

hth

review: Needs Fixing

« Back to merge proposal