Merge ~aieri/juju-lint:bug/1905609 into juju-lint:master

Proposed by Andrea Ieri
Status: Merged
Merge reported by: Andrea Ieri
Merged at revision: ff61747015aef93c13b0c6715a4239cd47c51a69
Proposed branch: ~aieri/juju-lint:bug/1905609
Merge into: juju-lint:master
Diff against target: 13 lines (+1/-1)
1 file modified
contrib/canonical-rules.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Dan Ackerson (community) Approve
BootStack Reviewers Pending
Review via email: mp+398080@code.launchpad.net
To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Andrea Ieri (aieri) wrote :

For the record, this will produce a false positive due to bug 1905605

Revision history for this message
Dan Ackerson (dan.ackerson) wrote :

lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has invalid commit message, setting status to needs review.

Revision history for this message
Andrea Ieri (aieri) wrote :

rebased on top of master to resolve merge conflicts

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has invalid commit message, setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has invalid commit message, setting status to needs review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
index e7ee200..6eaa448 100644
--- a/contrib/canonical-rules.yaml
+++ b/contrib/canonical-rules.yaml
@@ -56,7 +56,7 @@ config:
56 gte: 356 gte: 3
57 ntp:57 ntp:
58 auto_peers:58 auto_peers:
59 eq: true59 eq: false
60 nrpe:60 nrpe:
61 lacp_bonds:61 lacp_bonds:
62 isset: true62 isset: true

Subscribers

People subscribed via source and target branches