Juju Lint

juju-lint giving false positives for ceph-osd-replication-count in many charms

Bug #1905605 reported by Andre Ruiz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Lint
Fix Released
High
Unassigned

Bug Description

juju-lint is reporting missing configuration "ceph-osd-replication-count" in many different charms, including:

ceph-radosgw
cinder-ceph
glance
nova-compute

It wants it to be set with value "3" which makes it redundant because this is the default, which makes this a false positive.

Setting the value makes juju-lint happy, though and do not harm, afaik.

Revision history for this message
Andrea Ieri (aieri) wrote :

This happens also for any rule wanting to compare a value with a default, because juju does not export the value of default options in bundles.

We could consider supporting rules such as:

 nova-compute:
  ceph-osd-replication-count:
   isdefault: true

Or even better:

 nova-compute:
  ceph-osd-replication-count:
   or:
    eq: 3
    isdefault: true

Changed in juju-lint:
status: New → Confirmed
importance: Undecided → High
status: Confirmed → Triaged
Revision history for this message
Andrea Ieri (aieri) wrote :

see bug 1903607 as it's very relevant

Revision history for this message
Jose Guedez (jfguedez) wrote :

Values coming from defaults can be obtained on juju >= 2.9.2 [0], with the following flag: --include-charm-defaults

Can check for undesirable values then using the 'neq' check [1]

[0] https://bugs.launchpad.net/juju/+bug/1903607
[1] https://bugs.launchpad.net/juju-lint/+bug/1943222

Both of those fixes have been released, marking fix released here as well.

Changed in juju-lint:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.