Juju Lint

Merge ~aieri/juju-lint:bug/1905609 into juju-lint:master

  1. Git
  2. lp:~aieri/juju-lint
  3. bug/1905609
  4. Merge into master
Proposed by Andrea Ieri
Status: Merged
Merge reported by: Andrea Ieri
Merged at revision: ff61747015aef93c13b0c6715a4239cd47c51a69
Proposed branch: ~aieri/juju-lint:bug/1905609
Merge into: juju-lint:master
Diff against target: 13 lines (+1/-1)
1 file modified
contrib/canonical-rules.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Dan Ackerson (community) Approve
BootStack Reviewers Pending
Review via email: mp+398080@code.launchpad.net
To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Andrea Ieri (aieri) wrote :

For the record, this will produce a false positive due to bug 1905605

Revision history for this message
Dan Ackerson (dan.ackerson) wrote :

lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has invalid commit message, setting status to needs review.

Revision history for this message
Andrea Ieri (aieri) wrote :

rebased on top of master to resolve merge conflicts

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has invalid commit message, setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has invalid commit message, setting status to needs review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
2index e7ee200..6eaa448 100644
3--- a/contrib/canonical-rules.yaml
4+++ b/contrib/canonical-rules.yaml
5@@ -56,7 +56,7 @@ config:
6 gte: 3
7 ntp:
8 auto_peers:
9- eq: true
10+ eq: false
11 nrpe:
12 lacp_bonds:
13 isset: true

Subscribers

People subscribed via source and target branches