View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/gnome-shell

GNOME Shell has 1 active review. See all merge proposals.

Import details

Import Status: Reviewed

This repository is an import of the Git repository at https://git.gnome.org/browse/gnome-shell/.

The next import is scheduled to run .

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 1 hour — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 2 minutes — see the log

Branches

Name Last Modified Last Commit
gnome-3-32 2019-08-21 19:29:31 UTC
shell: Ignore non-toplevels for ShellWindowTracker::tracked-windows-changed

Author: Carlos Garnacho
Author Date: 2019-07-19 16:17:54 UTC

shell: Ignore non-toplevels for ShellWindowTracker::tracked-windows-changed

Popups and other override-redirect windows are meaningless to everything
that depends on the ShellWindowTracker. Ignoring those windows will result
in less ShellApp::windows-changed signal emissions, and less activity in
the AppMenuButton and everything else that depends on them.

Reduces gnome-shell CPU activity while typing on the Epiphany addressbar,
as the pop up animation there results in a number of xdg_popup being
created and destroyed.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/642
https://gitlab.gnome.org/GNOME/mutter/issues/556

(cherry picked from commit db9a7ea7a9b4c9485428a63a0bb4b8c2446ba801)

gnome-3-30 2019-08-21 11:38:25 UTC
Update Persian translation

Author: Danial Behzadi
Author Date: 2019-08-21 11:38:25 UTC

Update Persian translation

gbsneto/icon-grid-dnd 2019-08-02 19:33:04 UTC
appDisplay: Close popup when dragging

Author: Georges Basile Stavracas Neto
Author Date: 2019-07-04 19:03:20 UTC

appDisplay: Close popup when dragging

When a drag starts inside a folder, and the cursor moves to
outside it, close the currently opened folder popup.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/603

gbsneto/more-content 2019-07-16 17:31:30 UTC
workspace, workspaceThumbnail: Use window content (WIP)

Author: Georges Basile Stavracas Neto
Author Date: 2019-07-16 17:07:10 UTC

workspace, workspaceThumbnail: Use window content (WIP)

issue369 2019-07-08 11:57:23 UTC
endSessionDialog: Check for PackageKit before considering updates/upgrades

Author: Mario Sanchez Prada
Author Date: 2019-07-08 06:51:36 UTC

endSessionDialog: Check for PackageKit before considering updates/upgrades

GNOME Shell is spitting out some errors in the journal due to its attempts
to speak to PackageKit, which is not present on Endless OS, so let's add
some runtime checks to make sure that PackageKit is actually available
before assuming so and using its proxy to decide which kind of UI to
show to the user when ending the session.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/369

wip/aday/standardise-text-styles 2019-06-27 12:52:40 UTC
adjust UI to new text styles

Author: Allan Day
Author Date: 2019-06-26 13:52:09 UTC

adjust UI to new text styles

With the new text styles, some UI needs to adjusted, primarily to
accommodate larger heading text.

wip/jimmac/typography 2019-06-25 12:28:49 UTC
theme: Standardise text styles

Author: Allan Day
Author Date: 2019-06-19 10:10:28 UTC

theme: Standardise text styles

Initial attempt to use standard text styles, in line with what's
being done for GTK (https://gitlab.gnome.org/GNOME/gtk/issues/1808).

This is just changing the sizes and weights for now. Spacing
adjustments will be required further down the line.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/594

wip/jimmac/sync-with-adwaita 2019-06-24 08:10:14 UTC
Theme: update to sync with gtk Adwaita

Author: Frederik Feichtmeier
Author Date: 2019-06-18 13:29:00 UTC

Theme: update to sync with gtk Adwaita

- consistent OSD colors
- consistent fg/bg colors
- updated rounded corners
- switches

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/841

wip/nielsdg/remove-coglerror 2019-06-20 08:19:37 UTC
Drop CoglError for GError

Author: NielsDG
Author Date: 2019-06-20 08:12:16 UTC

Drop CoglError for GError

From https://gitlab.gnome.org/GNOME/mutter/merge_requests/631

```
CoglError was added at a certain point to remove the hard dependency on
GLib, but since this can't be avoided inside mutter, let's remove this
whole abstraction.
```

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/585

wip/jimmac/frederik-light 2019-06-15 16:32:18 UTC
Icon tile changes

Author: Frederik Feichtmeier
Author Date: 2019-06-15 16:32:18 UTC

Icon tile changes

- use the medium radius
- make checked tiles less hardcore black
- adjust folder popup bg color to checked tiles

wip/jimmac/adwaita-light 2019-05-27 14:03:40 UTC
theme: use light theme for popovers

Author: jimmac
Author Date: 2019-05-27 14:03:40 UTC

theme: use light theme for popovers

Make shell mimic Adwaita gtk.

FIXME:
 - switches
 - buttons
 - modal dialogs

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1045

wip/mcrha/eds-libical-glib 2019-05-17 20:24:08 UTC
calendar-server: Port to libecal-2.0

Author: Milan Crha
Author Date: 2019-04-18 14:21:43 UTC

calendar-server: Port to libecal-2.0

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/501

wip/fmuellner/ease-wm-animations 2019-05-15 22:08:07 UTC
windowManager: Use easing for window animations

Author: Florian Müllner
Author Date: 2018-07-20 19:46:19 UTC

windowManager: Use easing for window animations

wip/carlosg/fix-osk-warnings 2019-05-09 22:09:23 UTC
keyboard: Fix warnings on destroyed actors

Author: Carlos Garnacho
Author Date: 2019-05-09 22:07:25 UTC

keyboard: Fix warnings on destroyed actors

Trying to hide a page gets hard when the page was previouly destroyed.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1281

gnome-3-26 2019-05-03 21:33:58 UTC
dialog: Really set ellipsize mode in subtitle and body

Author: Marco Trevisan (Treviño)
Author Date: 2019-05-03 20:27:13 UTC

dialog: Really set ellipsize mode in subtitle and body

Dialog's subtitle or body could not be properly wrapped, while it's ellipsized
when the text's width doesn't exceed the container size.

Clutter text has an `ellipsize` property, however in dialog's subtitle and body
we have been setting the `ellipsize-mode` property to Pango.EllipsizeMode.NONE
that is not present in the underlying GObject.

Not being an error in javascript, gjs didn't warn us about this, while at the
same time the St.Label's default Pango.EllipsizeMode.END was used.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/922

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/531

(cherry picked from commit 3121c9aa29406ad85e949b697e90092f1fa6fc2e)

wip/rstrode/fix-smooshed-fedora 2019-04-30 18:58:26 UTC
texture-cache: preserve aspect ratio of loaded pixbufs

Author: Ray Strode
Author Date: 2019-04-30 18:58:26 UTC

texture-cache: preserve aspect ratio of loaded pixbufs

st_texture_cache_load_file_async takes optional width and height hints
to specify how much space on-screen the loaded image will take up. One
or both of the width and height can be negative.

gdk-pixbuf uses this information to scale down the image to an
appropriate size, when necessary, to save memory and prevent
aliasing.

gdk-pixbuf never uses this information to scale up the image, though;
that would just waste memory. Instead, the width and height hints are
used to set the geometry of the clutter content, so the texture may
get upscaled on-screen.

If both the passed in width and height are negative, it means to assume
the image will fit at native size, and gdk-pixbuf shouldn't downscale
the image.

If just one dimension is negative, it means the image should be
downscaled by gdk-pixbuf proportionally to fit the given (positive)
dimension.

If neither dimension is negative, it means the image should be
downscaled by gdk-pixbuf proportionally to fit whichever dimension keeps
the whole image within the bounds of its clutter content.

In any case, if the passed in width and height are bigger than the
dimensions of the loaded image, then those passed in values won't be used
by gdk-pixbuf, since it has no downscaling to do.

The problem is, the code that converts a pixbuf to a clutter content
fails to handle the case where the passed in dimensions aren't used by
gdk-pixbuf. It assumes at least one of the pixbuf dimensions matches the
dimensions passed to st_texture_cache_load_file_async. That won't be the
case if the pixbuf code had no downscaling to do.

This commit fixes that problem by deriving the unknown clutter content
dimension from the known clutter content dimension and the aspect ratio
of the image.

wip/fmuellner/opt-in-hot-corner 2019-04-29 17:33:22 UTC
layout: Offer to enable hot corner after repeated attempts to trigger it

Author: Florian Müllner
Author Date: 2019-04-29 17:27:39 UTC

layout: Offer to enable hot corner after repeated attempts to trigger it

wip/jimmac/osd-sync-with-gtk 2019-04-16 14:47:59 UTC
theme: sync OSD colors with gtk

Author: jimmac
Author Date: 2019-04-16 14:47:59 UTC

theme: sync OSD colors with gtk

1151-moving-window-up-to-a-new-workspace-clears-all-always-on-visible-workspace-flags 2019-04-03 13:27:42 UTC
weather: Handle missing permission store

Author: Florian Müllner
Author Date: 2019-04-03 10:35:03 UTC

weather: Handle missing permission store

Our weather integration is supposed to follow GNOME Weather's settings,
including its permission to use location services. However there's a
discrepancy in case xdg-desktop-portal is unavailable:

While our geoclue agent grants all applications access to location
services in that case, the weather integration treats it as if
access was denied.

Fix this by handling this case explicitly.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1130

gbsneto/automatic-updates 2019-03-19 12:18:54 UTC
Introduce updates indicator

Author: Georges Basile Stavracas Neto
Author Date: 2019-03-19 12:16:00 UTC

Introduce updates indicator

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/466

wip/jimmac/closebutton-tweaks 2019-03-11 19:52:27 UTC
theme: window close button touchup

Author: jimmac
Author Date: 2019-03-11 13:14:18 UTC

theme: window close button touchup

- tone down the shading considerably to match the previous look

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/453

wip/rstrode/rhel-8.0.0 2019-02-17 17:28:08 UTC
background: refresh background on gl-video-memory-purged signal

Author: Ray Strode
Author Date: 2019-01-21 20:07:15 UTC

background: refresh background on gl-video-memory-purged signal

Right now we refresh the background when resuming and when NVIDIA.
But mutter has a signal to tell us specifically when to refresh,
and the signal is only emitted for NVIDIA, so use that instead.

pot-ci 2019-02-09 03:51:00 UTC
ci: Check that pot file is generated correctly

Author: Florian Müllner
Author Date: 2019-02-09 03:51:00 UTC

ci: Check that pot file is generated correctly

This is to guard against the now infamous xgettext bug[0].

[0] https://savannah.gnu.org/bugs/?50920#comment5

gbsneto/fix-long-user-names 2019-02-07 19:54:35 UTC
system: Use username if full name is longer than 100 characters

Author: Georges Basile Stavracas Neto
Author Date: 2019-02-07 19:54:35 UTC

system: Use username if full name is longer than 100 characters

The current code relies on unstable behavior of ClutterText, and
does not really work as expected. Still, limiting the label size
is important.

Use a hardcoded limit of 100 characters instead of checking if
the layout is ellipsized already.

wip/timed-login-fix 2019-02-07 17:57:48 UTC
loginDialog: hide user list when starting timed login

Author: Ray Strode
Author Date: 2019-02-07 16:20:51 UTC

loginDialog: hide user list when starting timed login

If the timeout fires and we're starting timed login, we
should hide the user list, in case the login process
needs to show the user any messages on the auth prompt.

wip/fmuellner/remove-app-menu 2019-01-26 13:35:30 UTC
build: Don't introspect ShellMenu

Author: Florian Müllner
Author Date: 2018-10-04 18:09:25 UTC

build: Don't introspect ShellMenu

It is now only used internally by ShellApp to track remote actions,
so there's no need to expose it to javascript code.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/624

cherry-pick-74bb9e62 2019-01-21 16:28:20 UTC
ibusManager: Don't pass undefined callback to ibus

Author: Florian Müllner
Author Date: 2018-11-15 17:47:55 UTC

ibusManager: Don't pass undefined callback to ibus

Since commit 551e8278416, we don't always pass a callback parameter.
However passing it on as undefined to ibus doesn't work, as gjs doesn't
accept that as a valid callback value and throw an error. As a result,
we can end up with no layout selected in the keyboard menu and an "empty"
indicator. Fix this by explicitly passing null if no callback has been
provided.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/293

(cherry picked from commit 74bb9e62492bacda372904d30891eb97685e9b0c)

cherry-pick-b719744e 2019-01-16 00:05:59 UTC
st-bin: Destroy child in ClutterActor:destroy vfunc

Author: Georges Basile Stavracas Neto
Author Date: 2018-08-28 20:29:13 UTC

st-bin: Destroy child in ClutterActor:destroy vfunc

According to Clutter documentation, "[…] actors implementing the
ClutterContainer interface should override the default implementation
of the class handler of this signal and call clutter_actor_destroy()
on their children."

StBin was doing that in GObject:dispose() instead. Move the child
destruction to a new ClutterActor:destroy() vfunc override.

(cherry picked from commit b719744e75e56502cf0340066f9311fdcc755628)

wip/texture-purge-on-nvidia 2019-01-15 17:54:32 UTC
st-texture-cache: purge on resume

Author: Ray Strode
Author Date: 2019-01-15 17:54:32 UTC

st-texture-cache: purge on resume

With the proprietary nvidia driver, textures get garbled on suspend,
so the texture cache needs to evict all textures in that situation.

wip/rstrode/mouse-freeze-fix 2018-12-10 20:29:07 UTC
popupMenu: block input events when menu is closing

Author: Ray Strode
Author Date: 2018-12-10 20:25:35 UTC

popupMenu: block input events when menu is closing

At the moment gnome-shell can get really confused if a menu is
fading out and gets clicked.

It can lead to mouse pointer input getting stuck until the shell
is restarted.

This commit addresses the problem by ignoring input events that
come in when the menu is closing.

wip/jimmac/sharp-icons 2018-11-13 14:11:14 UTC
icons: avoid 96x96

Author: jimmac
Author Date: 2018-11-13 13:52:04 UTC

icons: avoid 96x96

- use 128 instead for total sharpness

see https://gitlab.gnome.org/GNOME/nautilus/issues/743

wip/fmuellner/background-gradient 2018-10-09 13:01:01 UTC
layout: Use background gradient when top bar is transparent

Author: Alessandro Bono
Author Date: 2017-08-19 15:17:40 UTC

layout: Use background gradient when top bar is transparent

Make sure the legibility of top bar elements doesn't depend on the
wallpaper by adding a light gradient at the top when the top bar
is transparent, similar to what Android does.

https://bugzilla.gnome.org/show_bug.cgi?id=783913

wip/fmuellner/duplicate-favs 2018-10-08 16:22:04 UTC
appFavorites: Don't add app explicitly

Author: Florian Müllner
Author Date: 2018-08-12 00:17:42 UTC

appFavorites: Don't add app explicitly

When adding a favorite, we add the ID to the list of favorites, save the
setting and add the new app to the favorites map. However as writing the
settings value already results in reload() to update the favorites map,
the new app is usually already in the map when we add it.

The only exception is when the ID was found in the RENAMED_DESKTOP_IDS map,
in which case we end up adding both the renamed app and the original one.
Fix this by simply relying on reload() to properly update the map, just like
we already do in _removeFavorite().

https://gitlab.gnome.org/GNOME/gnome-shell/issues/471

wip/fix-drag-lock-up 2018-09-19 16:52:39 UTC
dnd: don't try to access destroyed dragActor

Author: Ray Strode
Author Date: 2018-09-19 15:47:35 UTC

dnd: don't try to access destroyed dragActor

The dragComplete handler incorrectly checks
this._actorDestroyed to see if the drag actor
is destroyed. The drag actor may not be the same
as the main actor.

The end result is an exception in drop handling,
leading to a shell lockup.

This commit changes the code to always set
this._dragActor to undefined when it's destroyed,
and check for that condition instead of
this._actorDestroyed in the dragComplete handler.

Closes https://gitlab.gnome.org/GNOME/gnome-shell/issues/577

wip/fmuellner/fix-98 2018-09-11 14:27:47 UTC
appIconMenu: Disable sourceActor key events

Author: Florian Müllner
Author Date: 2018-09-11 14:06:09 UTC

appIconMenu: Disable sourceActor key events

Enter/space are already taken over by the app icon to activate the
app, and arrow keys interfere with keyboard navigation where icons
are arranged in a grid (namely the app picker).

Also as app icons only create the menu when it is first needed, the
shortcuts only starts to work once a menu has been opened, which is
rather inconsistent and confusing.

It is better to simply disable the key handling altogether for the
app icon menu.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/98

wip/carlosg/fix-workspace-transient-dialog-warnings 2018-08-04 11:26:08 UTC
workspaceThumbnail: Pass MetaWindow to _updateDialogPosition

Author: Carlos Garnacho
Author Date: 2018-06-28 16:08:46 UTC

workspaceThumbnail: Pass MetaWindow to _updateDialogPosition

This function was mistakenly called with a MetaWindow as first
argument inside the ::position-changed callback, instead of a
MetaWindowActor as it should.

However, that function quickly grabs the MetaWindow from the
actor, and all calling places have the MetaWindow readily available,
so switch to handing it as first function parameter.

Fixes warnings on ::position-changed, because of the aforementioned
typo.

wip/carlosg/osk-warning-fixes 2018-08-03 15:02:20 UTC
keyboard: Refactor code resetting IM on window drags

Author: Carlos Garnacho
Author Date: 2018-08-03 14:01:48 UTC

keyboard: Refactor code resetting IM on window drags

When a window is dragged, the OSK should get hidden. Just
do this in a nicer way.

wip/fmuellner/overview-keynav 2018-08-01 14:18:06 UTC
workspacesView: Enable keynav between all monitors

Author: Florian Müllner
Author Date: 2018-08-01 14:13:59 UTC

workspacesView: Enable keynav between all monitors

Instead of using one focus group for each (per-monitor) workspacesView,
use a single one that is shared between all of them.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/412

wip/jimmac/settings-app-icon 2018-07-24 13:35:41 UTC
icons: use actual Settings icon for settings

Author: jimmac
Author Date: 2018-07-24 13:35:41 UTC

icons: use actual Settings icon for settings

- rather than relying on a category icon, use actual Settings app icon

fixes issue #433

wip/fmuellner/indicate-app-in-polkit-dialogs 2018-07-09 14:18:18 UTC
polkitAgent: Indicate which application initiated a request

Author: Florian Müllner
Author Date: 2017-06-28 19:55:50 UTC

polkitAgent: Indicate which application initiated a request

Now that the ::initiate signal may contain the PID of the initiating
process, we can try to resolve it to an application and use that to
indicate where a request originated. This should work for well-behaved
applications that only ask for permissions in response to a user action,
but unfortunately not when it would be most useful, that is when the
dialog is triggered "out of nowhere" by a background service ...

https://bugzilla.gnome.org/show_bug.cgi?id=688351

theme-search-version 2018-06-28 10:14:54 UTC
theme: Search in versioned directories

Author: Iain Lane
Author Date: 2018-06-28 10:14:54 UTC

theme: Search in versioned directories

We support third party themes, via the "stylesheetName" property of a
mode's json files. However, our external CSS API is not completely
stable. If a third party theme wants to work on multiple gnome-shell
versions - for example because it is shipped as a Flatpak or a Snap - it
is not possible to ensure that a theme corresponding to the running
gnome-shell version is loaded.

GTK+ loads themes from versioned directories, search backwards from the
current version. Let's do the same in gnome-shell too. Then a downstream
theme can be shipped in $datadir/gnome-shell/3.28/theme/.

We keep searching all of the current paths. Additionally, the default
case where we look for the 'gnome' theme as a resource in the binary
continues to be the default so there are no additional lookups for users
of this theme.

gbsneto/789110 2018-05-29 23:18:28 UTC
bluetooth: Be consistent when determining whether Bluetooth is off

Author: Mario Sánchez Prada
Author Date: 2017-10-17 16:57:12 UTC

bluetooth: Be consistent when determining whether Bluetooth is off

It would be nice if we could use the same exact condition to decide
whether to show "Off"/"Turn On" vs "On"/"Turn Off" in the menu, since
otherwise we risk showing inconsistent states in each place.

https://bugzilla.gnome.org/show_bug.cgi?id=789110

issue267 2018-05-17 16:10:05 UTC
shell-app: Finish startup sequence for process that exit too early

Author: Mario Sánchez Prada
Author Date: 2018-05-11 12:36:02 UTC

shell-app: Finish startup sequence for process that exit too early

If a process associated to an application declaring StartupNotify=true
in its desktop file exits before having ever mapped a top level window,
the "remove" X message expected as per the Startup Notification Spec [1]
won't ever be issued, and the shell will keep waiting for a while until
the sequence is finished on time out.

This provides a confusing and bad experience since things like a confusing
icon + a spinner, or the mouse pointer switching to a spinning cursor, will
be showing up in the meantime, so we need to detect those situations and
make sure the sequence gets completed, and the app moved to STOPPED.

[1] https://www.freedesktop.org/wiki/Specifications/startup-notification-spec

Closes: #267

issue219 2018-04-20 13:09:28 UTC
window-tracker: check WM_CLASS for sandboxed apps before the app's ID

Author: Mario Sánchez Prada
Author Date: 2018-04-20 13:02:35 UTC

window-tracker: check WM_CLASS for sandboxed apps before the app's ID

For sandboxed apps, the shell needs to consider the app's ID when
matching its windows against the right .desktop file, but that
check can't be done before having attempted to match using the
WM_CLASS property of the app's window, otherwise apps installing
multiple desktop files (e.g. LibreOffice) will always match every
single window against the same .desktop file, ignoring hints such
as the StartupWMClass key.

This commit moves the call to get_app_from_sandboxed_app_id() after
get_app_from_window_wmclass() and before get_app_from_window_pid(),
so that we only rely on the sandboxed app's ID when no match has
succeed using the WM_CLASS property, but before checking by PID to
prevent wrong groups that could be created when the PID of the app
inside the sandbox matches the one from a process outside of it.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/219

issue154 2018-04-18 00:14:05 UTC
st-entry: Set text-related CSS properties on the internal ClutterText

Author: Mario Sánchez Prada
Author Date: 2018-03-26 11:38:57 UTC

st-entry: Set text-related CSS properties on the internal ClutterText

Call _st_set_text_from_style() when updating the entry's style, so
that CSS style properties such as text-decoration or letter-spacing
are applied over the internal ClutterText instance.

wip/fmuellner/guard-shadow-pipeline-from-actor-call 2018-02-20 16:40:40 UTC
st: Guard against spec being invalided during shadow creation

Author: Florian Müllner
Author Date: 2018-02-20 16:23:16 UTC

st: Guard against spec being invalided during shadow creation

If an actor is pending a relaying when get_allocation_box() is called,
the method forces an allocation update. In case of StWidget, this might
then result in a style update and a consecutive invalidation of the
shadow spec - we will then try to create a shadow specified by random
memory, with undefined (though likely fatal) consequences.

Guard against this by taking a temporary reference during the function
call.

https://bugzilla.gnome.org/show_bug.cgi?id=788908

jrocha/polkit-dialog-without-passwd 2018-02-14 16:29:40 UTC
polkitAgent: Do not set initial focus in the password entry

Author: Joaquim Rocha
Author Date: 2017-07-19 12:08:20 UTC

polkitAgent: Do not set initial focus in the password entry

The password entry can be hidden if the user has no password set, but
setting the initial focus to it will result in the entry responding to
the "activate" and signals.
Besides, with the logic that the dialog follows, setting the initial
focus in the entry is redundant, because the focus is also set in the
entry upon showing it.

issue-36 2018-02-09 12:22:58 UTC
shadow: Don't attempt to create a shadow for unallocated actors

Author: Mario Sánchez Prada
Author Date: 2018-02-09 11:50:32 UTC

shadow: Don't attempt to create a shadow for unallocated actors

Calling clutter_actor_get_allocation_box() can potentially cause a
re-layout, which in _st_create_shadow_pipeline_from_actor() would
mean invalidating the shadow_spec passed as a parameter, which
could crash the shell later on since the value for shadow_spec->blur
passed from _st_create_shadow_pipeline() to blur_pixels() would
not be a valid one.

Thus, whether the ClutterActor has an allocation before calling
clutter_actor_get_allocation_box(), and early return if needed.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/36

Closes: #36

wip/rancell/guest 2018-01-19 03:17:55 UTC
Show a guest login prompt

Author: Robert Ancell
Author Date: 2017-12-13 02:27:47 UTC

Show a guest login prompt

wip/msanchez/620106 2017-12-01 21:30:26 UTC
altTab: Close the list of thumbnails in the switcher when closing an app

Author: Mario Sánchez Prada
Author Date: 2017-12-01 20:40:41 UTC

altTab: Close the list of thumbnails in the switcher when closing an app

This makes sure that no thumbnails list is left open and empty, since both
the app's icon and all its thumbnails will be gone once the app is closed.

https://bugzilla.gnome.org/show_bug.cgi?id=620106

gnome-3-24 2017-11-17 15:04:21 UTC
overview: Protect ::drag-end handlers

Author: Carlos Garnacho
Author Date: 2017-11-16 16:27:12 UTC

overview: Protect ::drag-end handlers

These end up emitting item-drag-end/window-drag-end pretty much
without checks. Given the MetaDnd object may end up emitting
::drag-leave as a result of the plugin ending its grab, this
would result on spurious emission of those events and subsequent
warnings.

For extra paranoia, the _inDrag variable has been split into
_inItemDrag/_inWindowDrag so we can't cross the streams.

https://bugzilla.gnome.org/show_bug.cgi?id=784545

gnome-3-20 2017-10-21 11:38:34 UTC
Update zh_CN translation

Author: wsxy162
Author Date: 2017-10-21 11:38:34 UTC

Update zh_CN translation

wip/raresv/system-actions 2017-08-22 00:46:42 UTC
appDisplay: Include system actions in search results

Author: Rares Visalom
Author Date: 2017-08-21 13:20:25 UTC

appDisplay: Include system actions in search results

The way system actions are displayed in the search
results is by appending them at the end of the list
returned by the ApplicationProvider.

https://bugzilla.gnome.org/show_bug.cgi?id=691900

gnome-3-22 2017-08-12 13:33:16 UTC
Update Indonesian translation

Author: Andika Triwidada
Author Date: 2017-08-12 13:33:16 UTC

Update Indonesian translation

wip/fmuellner/overview-tweaks 2017-08-10 09:27:39 UTC
workspace: update window close

Author: jimmac
Author Date: 2017-07-19 11:58:07 UTC

workspace: update window close

- match the updated visuals

https://bugzilla.gnome.org/show_bug.cgi?id=783953

wip/beniofel/gesture 2017-08-01 11:16:02 UTC
magnify 4 finger swipe gesture by 1.5

Author: Ben
Author Date: 2017-08-01 11:15:59 UTC

magnify 4 finger swipe gesture by 1.5

wip/rstrode/list-extension 2017-07-26 17:34:06 UTC
gdmUtil: enable support for GDM's ChoiceList PAM extension

Author: Ray Strode
Author Date: 2017-07-17 20:48:03 UTC

gdmUtil: enable support for GDM's ChoiceList PAM extension

This commit hooks up support for GDM's ChoiceList PAM extension.

wip/raresv/uiTweaks 2017-07-04 22:00:49 UTC
search.js: Vertically center the provider icon

Author: raresvis
Author Date: 2017-07-03 19:35:21 UTC

search.js: Vertically center the provider icon

wip/jstpierre/cursor-position-tracker 2017-02-23 19:13:36 UTC
Replace cursor position monitoring with MetaCursorTracker

Author: Jasper St. Pierre
Author Date: 2017-02-23 19:13:36 UTC

Replace cursor position monitoring with MetaCursorTracker

I was tired of seeing 1s updates in shell recording videos when seeing
them on Planet GNOME, so here you go.

gnome-3-18 2016-10-29 18:57:30 UTC
browser-plugin: The NPObject returned by NPP_GetValue should be retained

Author: Carlos Garcia Campos
Author Date: 2016-10-28 13:33:11 UTC

browser-plugin: The NPObject returned by NPP_GetValue should be retained

The Mozilla documentation says: "And as always when working with
reference counted NPObjects, the caller is responsible for calling
NPN_ReleaseObject on the NPObject to drop the reference."

Browsers assume that the plugin does the right thing and always call
NPN_ReleaseObject. At some point the object is released and deallocated
and both the plugin and browser still have references to the object
thinking that it's still alive. That's why the crash is sometimes in the
plugin when it tries to use the np object, and sometimes in the browser.

https://bugzilla.gnome.org/post_bug.cgi

wip/ptomato/remove-gjs-internal-api 2016-10-05 05:27:18 UTC
WIP - Remove ShellJS gir

Author: Philip Chimento
Author Date: 2016-10-05 05:27:18 UTC

WIP - Remove ShellJS gir

You can define a new importer object by importing a subdirectory in GJS.
This is undocumented, but it is likely to at least hold until the whole
thing moves to ES6 modules.

wip/pad-osd 2016-07-20 17:24:42 UTC
TMP: theme osd changes

Author: Carlos Garnacho
Author Date: 2016-06-27 10:22:22 UTC

TMP: theme osd changes

wip/rtcm/merge 2016-04-11 21:12:23 UTC
mutter/clutter/cogl merge build fixes

Author: Rui Matos
Author Date: 2016-04-09 17:02:17 UTC

mutter/clutter/cogl merge build fixes

gnome-3-4 2016-03-21 18:55:13 UTC
Added Occitan translation

Author: Cédric VALMARY (Tot en òc)
Author Date: 2016-03-21 18:55:13 UTC

Added Occitan translation

gnome-3-6 2016-03-21 18:53:53 UTC
Added Occitan translation

Author: Cédric VALMARY (Tot en òc)
Author Date: 2016-03-21 18:53:53 UTC

Added Occitan translation

gnome-3-0 2016-03-21 18:53:10 UTC
Added Occitan translation

Author: Cédric VALMARY (Tot en òc)
Author Date: 2016-03-21 18:53:10 UTC

Added Occitan translation

gnome-3-2 2016-03-21 18:52:20 UTC
Added Occitan translation

Author: Cédric VALMARY (Tot en òc)
Author Date: 2016-03-21 18:52:20 UTC

Added Occitan translation

wip/loc-apps 2016-02-11 22:23:15 UTC
tmp

Author: Zeeshan Ali
Author Date: 2016-02-09 17:16:08 UTC

tmp

gnome-3-16 2015-12-05 13:06:34 UTC
Updated Icelandic translation

Author: Sveinn í Felli
Author Date: 2015-12-05 13:06:34 UTC

Updated Icelandic translation

gnome-3-14 2015-11-23 07:53:57 UTC
Updated Portuguese translation

Author: Pedro Albuquerque
Author Date: 2015-11-23 07:53:57 UTC

Updated Portuguese translation

wip/fullscreen 2015-10-12 19:40:30 UTC
windowManager: add animations for fullscreen and unfullscreen

Author: Cosimo Cecchi
Author Date: 2013-09-01 20:03:59 UTC

windowManager: add animations for fullscreen and unfullscreen

We use the newly introduced feature from Mutter to hook up our own
fullscreen and unfullscreen animations.
To give the illusion of a transition as smooth as possible, we create a
snapshot of the current contents of the actor before its state is
changed, and crossfade between the two states while the size changes.

https://bugzilla.gnome.org/show_bug.cgi?id=707248

gnome-3-10 2015-10-07 07:17:55 UTC
Updated Portuguese translation

Author: Pedro Albuquerque
Author Date: 2015-10-07 07:17:55 UTC

Updated Portuguese translation

matthiasc/misc-fixes 2015-09-24 17:31:07 UTC
Check error of g_dbus_proxy_new_sync call

Author: Matthias Clasen
Author Date: 2015-09-24 17:31:07 UTC

Check error of g_dbus_proxy_new_sync call

Otherwise errors pile up and we crash later on.

wip/halfline/env 2015-09-17 01:14:48 UTC
shell-global: import environment from $XDG_RUNTIME_DIR/gnome/environment

Author: Ray Strode
Author Date: 2015-09-16 19:34:36 UTC

shell-global: import environment from $XDG_RUNTIME_DIR/gnome/environment

environment variables are normally propagated from parent to child, but
they're used to convey information that's typically scoped to the
session. gnome-shell needs to know about environment variables that
are set in the session after it's already been started.

gnome-session now exports its environment to
$XDG_RUNTIME_DIR/gnome/environment so that programs in the session can
pick up on the latest environment variables.

This commit changes gnome-shell to propagate the gnome-session's latest
environment when launching new children.

wip/csoriano/modal-dialog-button-style 2015-08-05 11:43:22 UTC
spinner: use a 60fps spinner

Author: jimmac
Author Date: 2015-07-30 18:28:10 UTC

spinner: use a 60fps spinner

- sync with gtk+ and provide a fluid spinner

https://bugzilla.gnome.org/show_bug.cgi?id=753064

wip/garnacho/touchpad-gestures 2015-07-09 10:42:38 UTC
windowManager: Add TouchpadWorkspaceSwitchAction

Author: Carlos Garnacho
Author Date: 2015-07-01 13:53:24 UTC

windowManager: Add TouchpadWorkspaceSwitchAction

This object (not really a Clutter.GestureAction) sets up a captured-event
handler, which exclusively looks for 4 finger touchpad swipes, emitting
an ::activated signal under the same terms than WorkspaceSwitchAction.

wip/maximize 2015-07-06 06:11:50 UTC
implement maximize

Author: Jasper St. Pierre
Author Date: 2015-07-06 04:28:14 UTC

implement maximize

gnome-3-8 2015-05-16 07:17:17 UTC
Added Occitan translation

Author: Cédric VALMARY (Tot en òc)
Author Date: 2015-05-16 07:17:17 UTC

Added Occitan translation

gnome-3-12 2015-05-11 07:44:34 UTC
Updated Occitan translation

Author: Cédric VALMARY (Tot en òc)
Author Date: 2015-05-11 07:44:34 UTC

Updated Occitan translation

wip/muktupavels/flashback 2015-04-02 20:43:38 UTC
ui/shellDBus.js: move ShowOSD to org.gnome.Shell.OSD

Author: Alberts Muktupāvels
Author Date: 2014-12-13 21:37:18 UTC

ui/shellDBus.js: move ShowOSD to org.gnome.Shell.OSD

wip/fmuellner/chat-notifications 2015-03-17 05:17:44 UTC
messageTray: Stop including an actor with Notifications

Author: Florian Müllner
Author Date: 2015-02-11 19:20:03 UTC

messageTray: Stop including an actor with Notifications

We now stopped using notification actors directly for anything, so
we can simplify the Notification class significantly by turning it
into a purely informational object others can use to built their UI
representation from.

wip/sass 2015-02-20 16:15:31 UTC
update theme

Author: Carlos
Author Date: 2015-02-20 09:36:43 UTC

update theme

wip/sassWithSomeFixes 2014-11-11 15:30:11 UTC
panelMenu: Don't fade appMenuButton icon and put it on the side

Author: Carlos Soriano Sánchez
Author Date: 2014-11-11 15:30:11 UTC

panelMenu: Don't fade appMenuButton icon and put it on the side

Design request, don't fade the icon of the appMenuButton and put it on
the side instead of overlaping with the text.

wip/wobbly 2014-09-03 17:58:01 UTC
wobbly

Author: Jasper St. Pierre
Author Date: 2014-08-31 23:50:50 UTC

wobbly

wip/background-rework 2014-08-28 20:38:12 UTC
Adapt to Mutter background changes

Author: Owen Taylor
Author Date: 2014-08-11 16:15:45 UTC

Adapt to Mutter background changes

The rewrite of Mutter's background code (see bug 735637) requires
corresponding changes here - we no longer need to layer multiple
MetaBackgroundActors together.

The general strategy is that a BackgroundSource object is created
per GSettings schema, and keeps either one Background/MetaBackground pair,
or, for animation, a Background/Metabackground pair for each monitor.

https://bugzilla.gnome.org/show_bug.cgi?id=735638

wip/gestures 2014-06-27 21:32:54 UTC
windowManager: Switch the focused application on 3-finger hold + tap

Author: Carlos Garnacho
Author Date: 2014-06-27 20:45:58 UTC

windowManager: Switch the focused application on 3-finger hold + tap

The gesture action only cycles through the applications in the current
workspace.

wip/notif-d3 2014-06-13 18:23:24 UTC
preview

Author: Jasper St. Pierre
Author Date: 2014-06-13 16:08:09 UTC

preview

wip/notif-banner-relayout 2014-06-04 16:58:34 UTC
messageTray: Remove an unused variable

Author: Jasper St. Pierre
Author Date: 2014-06-04 16:58:34 UTC

messageTray: Remove an unused variable

wip/new-notifications 2014-06-03 17:51:59 UTC
nn

Author: Jasper St. Pierre
Author Date: 2014-05-28 22:48:22 UTC

nn

wip/quadbuffer-stereo 2014-05-08 23:08:01 UTC
Add support for meta_restart() and MetaDisplay::restart

Author: Owen Taylor
Author Date: 2014-05-08 22:56:23 UTC

Add support for meta_restart() and MetaDisplay::restart

Support was added to Mutter to allow it to trigger a restart
to allow for restarts when switching in or out of stereo mode.

Hook up to the new signals on MetaDisplay to show the restart
message and reexec. Meta.is_restart() is used to suppress
the startup animation.

This also allows us to do 'Alt-F2 r' restarts more cleanly
without a visual flash and animation.

wip/wayland-gdm-cleanup 2014-03-08 00:36:31 UTC
retrigger greeter

Author: Jasper St. Pierre
Author Date: 2014-03-08 00:35:02 UTC

retrigger greeter

wip/overview-transition 2014-01-31 22:57:57 UTC
overview: new transition

Author: Jasper St. Pierre
Author Date: 2014-01-14 13:40:23 UTC

overview: new transition

wip/folders 2013-12-16 18:28:14 UTC
folders

Author: Jasper St. Pierre
Author Date: 2013-12-16 03:24:25 UTC

folders

wip/desktop-file-index 2013-10-02 22:22:28 UTC
app-system: Add back StartupWMClass matching

Author: Jasper St. Pierre
Author Date: 2013-09-26 21:19:21 UTC

app-system: Add back StartupWMClass matching

While unfortunate that we still have to scan all apps with get_all(),
support for this feature will be short-lived, so hopefully we can drop
it in the future as new apps adapt to the desktop file / app ID
recommendations.

For now, simply scan all desktop IDs.

wip/cogl-deprecations 2013-09-11 19:26:44 UTC
Fix most of the Cogl deprecation warnings

Author: Jasper St. Pierre
Author Date: 2013-09-10 20:03:21 UTC

Fix most of the Cogl deprecation warnings

wip/smartcard 2013-07-30 00:21:06 UTC
authPrompt: support smartcard authentication

Author: Ray Strode
Author Date: 2013-06-27 12:54:19 UTC

authPrompt: support smartcard authentication

This commit detects when a user inserts a smartcard,
and then initiates user verification using the gdm-smartcard
PAM service.

Likewise, if a user removes their smartcard, password verification
(or the user list depending on auth mode and configuration) are initiated

https://bugzilla.gnome.org/show_bug.cgi?id=683437

wip/login-unlock-merge 2013-07-16 18:13:05 UTC
unlockDialog: Use GdmUtil.AuthPrompt instead of ModalDialog

Author: Ray Strode
Author Date: 2013-07-16 11:31:22 UTC

unlockDialog: Use GdmUtil.AuthPrompt instead of ModalDialog

commit ea02380c1524c28e6538ffedb789a12c298742ab made the login
screen stop using ModalDialog. It makes sense for the unlock
code to also stop using ModalDialog, too (for similar reasons).

Now that the login screen's auth prompt code has been separated
out, the unlock dialog can use it to get the buttons and spinners
etc, that it was previously getting from ModalDialog.

This commit drops the ModalDialog usage in the unlock dialog, and
makes the unlock dialog use GdmUtil.AuthPrompt instead.

wip/wayland-2 2013-07-15 11:22:10 UTC
Make ShellXFixesCursor work under wayland

Author: Giovanni Campagna
Author Date: 2013-07-15 11:11:33 UTC

Make ShellXFixesCursor work under wayland

Replace ClutterX11 with GdkX11 + Mutter, so that it works when
Clutter is not using the X11 backend.

FIXME: doesn't work...

wip/window-scales 2013-07-03 13:18:07 UTC
gross hack to make things work with HiDPI gtk+

Author: Alexander Larsson
Author Date: 2013-07-03 13:16:49 UTC

gross hack to make things work with HiDPI gtk+

We temporatily set GDK_SCALE to 1 when initializing Gtk+ so that
we get the old non-hidpi behaviour.

wip/session-menu 2013-06-26 14:05:32 UTC
loginDialog: make spinner and session menu button share position

Author: Ray Strode
Author Date: 2013-06-25 17:35:38 UTC

loginDialog: make spinner and session menu button share position

They never need to be shown at the same time, and the design has
the UI fade between them.

This commit implements that.

https://bugzilla.gnome.org/show_bug.cgi?id=702818

101200 of 229 results

Other repositories

Name Last Modified
lp:gnome-shell 11 hours ago
lp:~vanvugt/gnome-shell 2019-03-01
12 of 2 results
You can't create new repositories for GNOME Shell.