Author: Sebastian Wick
Author Date: 2024-04-16 14:29:48 UTC

shell-util: Only use systemd if gnome-shell is managed by systemd

Simply looking at the return value of sd_pid_get_user_unit can be used
to determine if the process is in a systemd unit, but it doesn't say if
gnome-shell is managed by systemd.

For example, running toolbx on a host with systemd creates a libpod
unit, even if the gnome-shell that gets started in the toolbx is itself
not managed by systemd.

We can make sure that gnome-shell is managed by systemd simply by
checking if the unit we're running starts with org.gnome.Shell.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3267>

Author: Andika Triwidada
Author Date: 2024-04-22 11:08:20 UTC

Update Indonesian translation

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2024-04-21 12:32:39 UTC

Bump version to 45.6

Update NEWS.

Author: Milan Crha
Author Date: 2024-04-17 12:09:59 UTC

calendar-server: Add 'Snooze' button into the notification

Snoozes the reminder for 9 minutes.

Author: Marco Trevisan (Treviño)
Author Date: 2024-02-27 22:34:13 UTC

gdm/util: Catch errors on re-authentication

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2024-03-16 14:01:51 UTC

Bump version to 44.10

Update NEWS.

Author: Bilal Elmoussaoui
Author Date: 2024-02-21 14:47:19 UTC

cleanup: Add missing Xlib include

That was indirectly inherited from a mutter header which removed that
include

Author: Ray Strode
Author Date: 2023-08-16 18:09:50 UTC

status/keyboard: Use gnome-desktop API for getting default input sources list

At the moment, gnome-shell tries to figure out the default input sources
from localed. It fails to take into account the system locale and input
methods.

This commit switches it to use a new function in gnome-desktop,
gnome_get_default_input_sources, which does most of the heavy
lifting itself, instead.

Author: Bilal Elmoussaoui
Author Date: 2024-01-24 16:49:51 UTC

cleanup: Adapt to removed ClutterColor

It was replaced by CoglColor

Author: AsciiWolf
Author Date: 2024-01-22 01:02:20 UTC

Update Czech translation

Author: jimmac
Author Date: 2024-01-15 10:51:03 UTC

theme: Lock/Login -- bring back focus ring

- Revert to the prominent focus ring for lock and login screen,
  lost with a refactor of the entry drawing code.

See https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6802 and
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3109#note_1970652
Fixes #7326 as well.

Author: Zander Brown
Author Date: 2023-12-27 20:27:08 UTC

screenshot: Use FileManager1 to show files

Author: Zander Brown
Author Date: 2023-08-09 03:48:19 UTC

shell/window-preview-layout: Ensure we don't touch dead objects

We were assuming the lifetime of the MetaWindow worked out in our
favour, and further hoping the GC didn't work against us

Avoid this by taking an explict weak ref, and checking the object is
live before removing handlers

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6570

Author: Zander Brown
Author Date: 2023-10-28 03:39:46 UTC

popupMenu: Use connectObject to disconnect when parent destroyed

Currently the handler is leaked, contributing to
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7143 , by using
`connectObject` with the `owner` actor we avoid leaking `PopupMenuManager`s
for things like the password entry in `AuthenticationDialog`

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7143

Author: Zander Brown
Author Date: 2023-10-28 05:36:10 UTC

shell/monitor-group: Avoid doing extra work

A lot of our calculations only change based on (unlikely) external
events, simply cache those parts and only update when the underlying
properties actually change.

Notable is base_direction, which was previously being calculated
repeatedly per workspace per monitor on every interpolate — now it's
simply a private int.

This seriously cuts down the number of calls, vs just maths, we need to
do at each step including eliminating a repeated `g_object_get` in favour
of a gboolean flag.

Author: Zander Brown
Author Date: 2023-10-24 22:35:02 UTC

shell/workspace-dot: Avoid excess marshalling

No need for the overhead of via properties when we can just have a
method to call in the tight loop in update_expansion

Author: Zander Brown
Author Date: 2023-10-24 23:54:54 UTC

shell/global: signal marshallers

Author: Niels De Graef
Author Date: 2023-09-26 12:42:20 UTC

quickSettings: Set Atk checked state

Make sure that we update the accessibility state of a quick settings
toggle button appropriately to its actual state, as a screen reader has
no way of knowing otherwise whether it's actually checked or not.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7048

Author: Ray Strode
Author Date: 2023-09-20 14:51:17 UTC

panel: React to new 'language-changed' signal

This commit makes the panel sets up a connection to the new
language-changed signal and react by rebuilding its components.

Author: Ray Strode
Author Date: 2023-09-14 19:47:17 UTC

panel: Make quick settings configurable in session mode

Right now the gnome-initial-setup mode has quick settings that aren't
that useful (like "Power Mode" and "Dark Style"). It also has some
that are useful (like "Wi-Fi").

Ths commit allows gnome-initial-setup to decide which settings to show
by adjusting its session mode configuration.

This will also give us the flexibility later to evaluate and change
which quick settings are shown in the lock screen, as well.

The changes are 4-fold:

1. Updating the session mode configuration to include a new
quickSettings property which contains the list of quick settings to
load for the given mode. For backward compatibility, by default, this
property is null which means "load the default set of quick settings".

2. A new QuickSettingsManager class that's akin to ComponentManager but
for quick settings instead of components. It handles importing the
status modules that provide system indicators and quick setting menu
items.

3. Changing the QuickSettings panel menu button to use the
QuickSettingsManager instead of importing the status modules itself.

4. Changing the modules that provide quick settings that are supposed to
span multiple columns in the grid to announce that requirement by
setting a new "expand" propery on the modules indicator quick settings
items array.

Author: Ray Strode
Author Date: 2023-09-06 13:23:51 UTC

backgroundApps: Don't crash if app id can't be looked up

I'm looking at a log file with this trace back:

    JS ERROR: TypeError: a.app is null
              _sync/<@resource:///org/gnome/shell/ui/status/backgroundApps.js:226:17
              _sync@resource:///org/gnome/shell/ui/status/backgroundApps.js:225:14
              _init/</<@resource:///org/gnome/shell/ui/status/backgroundApps.js:170:67
              @resource:///org/gnome/shell/ui/init.js:21:20

This commit should avoid the failure by filtering out items where
lookup_app fails.

Author: Sam Hewitt
Author Date: 2023-08-29 16:20:36 UTC

style: Fix contrast issue in app switcher

- update focus style for tile_button drawing
- override style for switcher selected state to use focus style
- fix contrast issue with checked state

Author: Sam Hewitt
Author Date: 2023-08-29 12:14:32 UTC

style: Restore overview search entry focus color

- Fixes #6945

Author: Corey Berla
Author Date: 2023-08-16 17:24:19 UTC

introspect: Enhance WindowsChanged DBus API

Splits WindowsChanged into 3 signals: WindowAdded, WindowChanged,
WindowRemoved and nclude the window as an argument. This gives us
the necessary information to tracked each window changed, rather than
requiring continuous calls to GetWindows (returning all windows).

The main consumer of the shell-introspect signals is
xdg-desktop-portal-gnome, so an API break seems reasonable, rather
than introducing a new API.

See: https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/93

Author: Simon McVittie
Author Date: 2023-08-04 11:47:47 UTC

Get uninstalled libraries from environment in preference to ELF headers

Introspecting the dynamic headers is low-level and full of implementation
details.

It seems that gnome-shell was assuming the address of the string table is
given by taking the DT_STRTAB dynamic symbol table's value (d_un.d_val)
and casting it to an absolute pointer. However, in some environments
(apparently including Debian mips64el) the DT_STRTAB dynamic symbol
table's d_un.d_val can be merely an offset relative to the base address
of the executable in memory. The base address would have to be parsed from
a different ELF header, which as far as I know is not part of _DYNAMIC.

Rather than trying to look up the Shell executable's base address using
dlinfo() or similar, during unit testing it seems easier to pass in the
uninstalled library search path in the environment, along with other
uninstalled paths that we are going to need anyway.

The reason given for not using GI_TYPELIB_PATH in commit 9bc89b82
"main: Prepend RPATH or RUNPATH paths to gir search paths" was that
g_irepository_prepend_library_path() takes precedence, but we can easily
define our own environment variable that takes even higher precedence.
If it's set, we might as well also bypass the PKGLIBDIR, since while
running uninstalled we *only* want to use the uninstalled libraries.

When not running unit tests, it's desirable to make
`./build/src/gnome-shell` something you can run directly, so continue
to parse the ELF headers - but only on x86_64, where we're reasonably
confident that it works and any regressions with a newer glibc will
be noticed promptly.

Resolves: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6877
Bug-Debian: https://bugs.debian.org/1042980
Signed-off-by: Simon McVittie <smcv@debian.org>

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2023-07-15 02:51:14 UTC

ci: Tmp

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2023-06-20 12:20:59 UTC

tmp: Force image rebuild

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2023-06-20 12:20:59 UTC

tmp: Force image rebuild

Author: Sam Hewitt
Author Date: 2023-05-23 15:57:38 UTC

style: Drop numeric font feature from panel

Author: Alexander Mikhaylenko
Author Date: 2023-03-21 20:06:01 UTC

theme: Support accent color

Author: DяA
Author Date: 2020-01-21 10:30:42 UTC

toggleSwitch: Make handle draggable

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2023-03-19 20:50:15 UTC

Bump version to 42.9

Update NEWS.

Author: Quentin PAGÈS
Author Date: 2023-02-13 19:18:36 UTC

Update Occitan translation

Author: Sergej A
Author Date: 2023-01-10 12:39:12 UTC

Update Russian translation

Author: Carlos Garnacho
Author Date: 2022-11-11 12:13:41 UTC

status/keyboard: Ignore purpose hint changes while keymap switcher is shown

If we are getting purpose hint changes while the language switcher is popped
up, this likely means the purpose hint was actually triggered by the key
focus change induced by the language switcher popping up.

In this case, we on one hand would like to preserve the state that applied
before thise focus change, and on the other we very much want to avoid the
keymap change that would forget about the keys being pressed.

(Cherry-picked from commit 2e8e1fe8fcd5af37dff7efccc17269366a2001b2)

Author: Carlos Garnacho
Author Date: 2022-10-05 10:19:14 UTC

dnd: Start implicit DnD from the original drag position

Locking the DnD actor to the pointer coordinates at the time of
starting a drag (e.g. after the DnD threshold) is going to look like
it lags behind.

Start the DnD operation at the button/touch press coordinates, so
the actor looks like it snaps to that position instead of being dragged
from there.

Author: Mohammed Sadiq
Author Date: 2022-09-17 02:51:52 UTC

osk-layouts: Update Malayalam layout

Prefer Arabic numerals and add some missing keys

Fixes #5879

Author: jimmac
Author Date: 2022-09-05 14:11:48 UTC

theme: Light variant tweaks

- having system grey derived form the base color means having
  classic/light theme overview light/illegible
- System grey needs a foreground too
- login/gdm entries derived from system grey fg (assumed dark bg)

Fixes https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/issues/410

Author: jimmac
Author Date: 2022-08-24 10:20:36 UTC

theme: Quicksettings toggle size

- stick to the original dimensions of the buttons

See https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5792

Author: Georges Basile Stavracas Neto
Author Date: 2022-08-22 21:46:20 UTC

quickSettings: Rotate menu arrows

Static arrows representing menus are inconsistent with the rest of
the platform, where we rotate arrows to represent that the menu is
open. Make quick settings arrows do the same.

Author: jimmac
Author Date: 2022-08-22 11:13:54 UTC

theme: Prominent hover for buttons

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5765

Author: Georges Basile Stavracas Neto
Author Date: 2020-09-02 20:35:23 UTC

plugin: Implement profiling vfuncs

Use the new GJS API to pass an external capture writer, and
start/stop whenever the compositor asks us to do so.

Author: Will Thompson
Author Date: 2022-08-16 06:07:16 UTC

main: Only set last-shown-version if welcome actually shown

At startup, if the welcome-dialog-last-shown-version GSetting compares
older than WELCOME_DIALOG_LAST_TOUR_CHANGE, Shell attempts to offer the
welcome tour to the user, and then sets that GSetting to the current
version of Shell.

However, showing the welcome dialog can fail. In particular, if
gnome-tour is not installed, WelcomeDialog.open() returns false and the
dialog is not shown; but there are other reasons, such as another modal
dialog already being open. Previously, welcome-dialog-last-shown-version
would nonetheless be updated in this case, so if you subsequently
install gnome-tour (or on the next login, if there is no modal dialog),
the welcome dialog will not be offered until the next time
WELCOME_DIALOG_LAST_TOUR_CHANGE is bumped.

Instead, check whether WelcomeDialog.open() fails; if so, don't update
welcome-dialog-last-shown-version.

Author: Georges Basile Stavracas Neto
Author Date: 2022-08-08 01:55:37 UTC

accessDialog: Skip focus check for screenshot permissions

Screenshot is a special case compared to other permissions because
apps might want to hide themselves from the desktop when a screenshot
is about to be taken. In that case, this heuristic of checking if
the focus window corresponds to the application that is requesting
screenshot permissions becomes problematic.

Special case the screenshot permission to skip the focused window
check.

See also: https://github.com/flatpak/xdg-desktop-portal/pull/851

Author: Sam Hewitt
Author Date: 2022-05-31 18:29:32 UTC

notifications: Rework notification layout to not rely on css hacks

- rework message bubbles to have elements laid out in a sensible way
- remove some of the css hacks that assisted the layout
- rework the media player widget to not be as constrained by the notification layout
- clean up notifications css

Author: Sam Hewitt
Author Date: 2022-05-26 17:04:02 UTC

search: Change results to entirely vertical layout

- rearrange search provider button contents
- cleanup search related styles & reduce padding

Author: Sam Hewitt
Author Date: 2022-05-27 13:40:03 UTC

popovers: Convert menu ornament to icons and cleanup stylesheets

- convert ornaments to icons
- add check and radio icon assets for ornaments
- cleanup a lot of stylesheet hacks because the ornaments used to be labels

Author: Bilal Elmoussaoui
Author Date: 2022-04-14 10:35:09 UTC

sound player: Add Shell implementation of mutter#2375

Author: Carlos Garnacho
Author Date: 2022-04-08 14:18:35 UTC

switcherPopup: Avoid Clutter.CURRENT_TIME timestamps

Request the last time with a roundtrip here, in order to ensure the
received time is not Clutter.CURRENT_TIME, and mistakenly triggers the
meta_window_set_demands_attention() paths in window activation.

Fixes some situations that very quick alt press, tab press, alt release,
tab release sequences trigger "$app needs attention" notifications.

Author: Will Thompson
Author Date: 2022-01-26 10:43:13 UTC

endSessionDialog: Support eos-updater [DRAFT]

eos-updater is used in Endless OS and GNOME OS.

Much more invasive changes will be needed since the eos-updater state
machine looks very different to the packagekit state machine. The update
is staged in the background; once staged, the next clean
shutdown/startup or reboot will boot straight into the new version.

Author: Sam Hewitt
Author Date: 2021-12-28 13:46:54 UTC

style: Stylesheet updates for GNOME 42

- updated switch assets
 - new high contrast assets
- use non-hardcoded bg color for dash
- updated palette colors
 - add missing color definitions to hc
- increase radii of many elements
- update search entry style
- align icon better in search entry
- restyle panel popovers without arrow and add drop shadow
- used theme colors in panel
- fix some things with popover labels
- new slider style
- some light variant fixes
- fixes to the calendar popover
 - day with event styles
 - better calendar-today.svg and dark variant
 - shorten calendary weekday header
 - saner padding
- overhaul popover menu style
- minor fixes to app grid and alt-tab switch
- updated looking glass styles
- nm-dialog adjustments
- search results adjustments
- expand out panel button hover styles
- button drawing adjustments
- adjust notifications area
- update on-screen keyboard style
 - better keyboard symbolic icon assets
 - change keyboard symbolic icons to 24px
 - improved keyboard style
 - gave the keyboard word suggestions some styles
- less obnoxious saner media control buttons
- cleaned up the css for the dash
- reworked the alt-tab switcher style
- sync style on workspace switcher
- adjusted dialog button style drawing
- popover submenu redrawing adjustement

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2104>

Author: Sam Hewitt
Author Date: 2022-01-12 18:20:34 UTC

new symbolic icon assets
 - migrate theme assets to symbolic icons
 - new local osd icons
 - general cleanup of symbolics

Author: Evan Welsh
Author Date: 2021-10-30 22:22:25 UTC

loginDialog: Remove some dead code

_getBannerAllocation() takes a single argument.

Author: Bastien Nocera
Author Date: 2021-11-02 14:25:12 UTC

bluetooth: Remove unused shell_bluetooth_type_to_filter_string()

Author: Ray Strode
Author Date: 2021-10-06 19:42:17 UTC

keyboard: Emit key release right away

At the moment the on-screen keyboard doesn't emit the key release event
until the user stops pushing the keyboard button with their pointer.

This means if the user uses the pointer to hold the button down, it can
generate repeat events for some keys.

But this creates a bit of an inconsistency in behavior between keys that
support multiple choices via long press and those that don't. The ones
that support long press, don't repeat, instead they show the available
choices.

Furthermore, key repeat doesn't work for any of the keys with the
wayland backend, since key repeat is a client side thing, and we just
don't have it implemented for this path.

Also, key repeat is repeating the wrong keys right now, even on X11, for
keys that require a shift level (see
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2045 )

Given key repeat is a dubious feature in an on-screen keyboard to begin
with, and it's only implemented for one backend, and it's not even
completely working on that backend, it's probably best to drop support.

This commit changes the on-screen keyboard to always emit a key
release immediately after each key press.

Author: Evan Welsh
Author Date: 2021-09-18 06:48:04 UTC

ESM Part 1

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2021-08-17 23:32:36 UTC

Bump version to 3.38.6

Update NEWS.

Author: jimmac
Author Date: 2021-07-22 11:19:50 UTC

theme: Searchbar with no border

- don't do stroke on search entry, sync with all other entries
- Tobias' GUADEC mini initiated

Author: Evan Welsh
Author Date: 2021-07-15 03:19:45 UTC

Fix leftover and incorrect JavaScript.

Author: Felipe Borges
Author Date: 2021-06-24 13:19:57 UTC

runDialog: Don't run commands for apps filtered by parental controls

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4415

Author: Gustavo Noronha Silva
Author Date: 2021-05-18 18:28:43 UTC

calendar-server: Fix double-free detection abort

app_notify_events_added uses an intermediate builder to construct an
array that is then added to the main variant using g_variant_builder_add
which should clear the intermediate, but doesn't due to the way it is
passed: by value, rather than as a pointer.

This was debugged with the help of Eduardo Habkost, who believes it
works on x86 due to big structs being passed as pointers.

Fixed: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3440
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1848>

(cherry picked from commit 404ca91941226faaf2479609f0109244e66d4bcd)

Author: Carlos Garnacho
Author Date: 2021-04-01 15:03:13 UTC

layout: Add check about whether session should start on Overview

In situations that there are UI applications that are meant to be
started together with the session, it is undesirable to boot into
the overview.

In ideal situations, we would have session management infrastructure
in place that would allow GNOME Shell to find out there's UI services
to be brought up in the startup phase, and be able to decide window
positions and workspaces beforehand.

But we don't have any of that. Add a sneaky file existence test
so the behavior can be tweaked by savvy users and e.g. installers.
The hope being that this is a temporary solution till we have the
ideal framework in place.

Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3854

Author: Evan Welsh
Author Date: 2021-02-20 18:15:46 UTC

Implement gnome-extensions:// protocol.

Add a simple protocol to install extensions.
Currently supports gnome-extensions://install?uuid=name@name.com

Author: Allan Day
Author Date: 2021-02-19 15:58:18 UTC

schemas: Define default app grid arrangement

Specify the default app grid arrangement. This makes the app grid
more useful since the interesting apps are prioritised. It also
communicates that the app grid can be customised.

Fixes #3122

Author: jimmac
Author Date: 2021-02-04 13:16:00 UTC

appDisplay: Revisit "Add drop shadow to icons"

The shadow is barely visible on dark backgrounds, but it's not
wrong to be consistent with Settings, Software and GNOME Classic.

With the app icon swarm animation gon, the performance implications might not be as critical (https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3124

- increase blur but not much, while we can't have multi-layered shadows.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3670
Also see https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3123

Author: jimmac
Author Date: 2021-02-02 11:01:15 UTC

theme: adjust dash icon spacing

- no padding between icon containers, except the first and last

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3640

Author: Florian Müllner
Author Date: 2020-11-19 03:04:14 UTC

appDisplay/pageManager: Update layout when apps are renamed

Now that the app picker uses custom, user-defined positioning, it
makes sense to pick up renamed app IDs like we do for favorites.

Author: Ray Strode
Author Date: 2020-10-14 19:40:05 UTC

weather: Don't spew messages when geolocation is unavailable

It's not a requirement that the xdg portal is installed, so we
shouldn't log an error when it's not.

Furthermore, we shouldn't log an error when geolocation is disabled
in settings.

This commit mutes the log spew.

Author: Carlos Garnacho
Author Date: 2020-07-20 10:08:43 UTC

shell: Update to MetaCursorTracker API change

The pointer coordinates in meta_cursor_tracker_get_pointer() are now
returned as a graphene_point_t.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1405

Author: Carlos Garnacho
Author Date: 2018-12-03 12:09:47 UTC

shell-global: Make saving of persistent state asynchronous

This is an expensive operation that is best avoided in the main loop. Given
the call doesn't care much about returning error or status, it can just
be made async within.

Every operation on a given file will be destructive wrt previous
operations on the same file, so we just cancel any pending operation on
it before batching the current one.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/815

(cherry picked from commit 86a00b6872375a266449beee1ea6d5e94f1ebbcb)

Author: Benjamin Berg
Author Date: 2020-07-31 13:43:25 UTC

runDialog: Use new app based launch helper

Doing this has the advantage of using the GLib GDesktopAppInfo launching
API, resulting in the automatic registration of the application with
systemd.

See: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1596
Closes: #3025

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1384

Author: Exalm
Author Date: 2020-06-23 19:20:59 UTC

Add screen corners

Commit message TBD

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1328

Author: Evan Welsh
Author Date: 2020-06-21 08:28:17 UTC

Initial experiment unifying app menus.

Author: Marco Trevisan (Treviño)
Author Date: 2020-06-05 14:12:58 UTC

shell-mime-sniffer: Ignore invalid file content type

The shell mime sniffer goes through all the files in a directory,
however in case a file content type is not recognized, the GIO function
g_file_info_get_content_type() may return NULL, causing a crash when
looking up into the content type tables, as they are supposed to contain
strings only and they use `g_str_hash` has func, which doesn't support
NULL values.

So, in case we get an invalid content type, let's just ignore it,
without adding it to the cache as we do in the nautilus code that was
inspiring the sniffer.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2643

(cherry picked from commit 46547ae02797558699510595b27857b80c027b5b)

Author: Matej Urbančič
Author Date: 2020-06-01 20:09:11 UTC

Updated Slovenian translation

Author: Carlos Garnacho
Author Date: 2020-05-12 14:41:45 UTC

keyboard: Detect taps close to the cursor caret on X11

Try to bring some feature parity wrt OSK being toggled on. Set up
a gesture that triggers on taps nearby the text caret position, as
reported by ibus.

Author: Milan Crha
Author Date: 2020-04-02 07:24:28 UTC

calendar-server: Improve performance by properly using ECalClientView

The previous code always restarted whole ECalClientView when it received
any changes in it, which could sometimes lead to constant repeated restarts
of the view.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/1875

Author: Georges Basile Stavracas Neto
Author Date: 2020-04-06 14:19:28 UTC

animation: Set size through CSS

Pretty much the same case of the previous commit: we want this size
to be scale-dependant, and using the width and height properties of
ClutterActor doesn't automatically update.

Use CSS to set the width and height.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1176

Author: Georges Basile Stavracas Neto
Author Date: 2020-04-03 22:00:28 UTC

st/theme-context: Invalidate texture cache when scaling changes

Author: Simon McVittie
Author Date: 2020-04-02 18:32:18 UTC

blur: Always allocate at least one pixel

This works around a crash when we try to blur a background that hasn't
yet had any space allocated for it, in particular when locking the screen
with mutter 3.36.1 and the Native Window Placement extension.

Workaround for <https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2538>.

Signed-off-by: Simon McVittie <smcv@debian.org>

Author: Marco Trevisan (Treviño)
Author Date: 2020-03-31 18:13:46 UTC

main: Don't override DesktopAppInfo desktop if already GNOME

During the shell initialization we call the (deprecated) function to
override the Desktop environment in Gio DesktopAppInfo to make sure that
applications are correctly shown (as per commit b2fbf5a2), however this
might break the cases in which $XDG_CURRENT_DESKTOP is already set and
contains GNOME (given that is now a list).

In Ubuntu this is in fact set to: ubuntu:GNOME.
Now, if an application contains NotShowIn=ubuntu, the key will be ignored by
the shell, and the application is still listed everywhere.

So, override the DesktopAppInfo desktop environment only in the case that
the current desktop is not already GNOME.

At the current date I think we could just safely get rid of this override at
all, but there could be still cases where it still might be useful, like when
running as nested in some other environment, so keeping it.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1156

(cherry picked from commit a0def239408b389020c8d2dc634ab0250e2d9721)

Author: Bilal Elmoussaoui
Author Date: 2020-03-02 10:02:56 UTC

ExtensionsPref: always convert the extension version to a string

This fixes: Wrong type number; string expected
MR: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1060

Author: Christian Hergert
Author Date: 2020-02-28 03:48:35 UTC

app-cache: add ShellAppCache for GAppInfo caching

This caches GAppInfo so that the compositor thread does not have to perform
costly disk access to load them. Instead, they are loaded from a worker
thread and the ShellAppCache notifies of changes.

To simplfy maintenace, ShellAppCache manages this directly and the
existing ShellAppSystem wraps the cache. We may want to graft these
together in the future, but now it provides the easiest way to backport
changes to older Shell releases.

Another source of compositor thread disk access was in determining the
name for an application directory. Translations are provided via GKeyFile
installed in "desktop-directories". Each time we would build the name
for a label (or update it) we would have to load all of these files.

Instead, the ShellAppCache caches that information and updates the cache
in bulk when those change. We can reduce this in the future to do less
work, but chances are these will come together anyway so that is probably
worth fixing if we every come across it.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2282

Author: Alexander Mikhaylenko
Author Date: 2019-07-04 18:43:23 UTC

workspaceAnimation: Support multiple monitors

Currently, there's one animation for the whole canvas. While it looks fine
with just one screen, it causes windows to move between screens when
switching workspaces. Instead, have a separate animation on each screen,
and sync their progress so that at any given time the progress "fraction"
is the same between all screens. Clip all animations to their screens so
that the windows don't leak to other screens.

If a window is placed between every screen, can end up in multiple
animations, in that case each part is still animated separately.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1213

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/605

Author: jimmac
Author Date: 2020-02-20 13:08:34 UTC

theme: OSK opaque

- the on screen keyboard is not an overlay in most cases. the semi-opacity
  is distracting.
- use opaque background color
- see discussion on https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1028

  FIXME: whitespace at the bottom without scaling everything down (padding)
  FIXME: don't behave as overlay anywhere (even for entries above the fold)

Author: Jan Tojnar
Author Date: 2020-02-11 02:42:42 UTC

extension-tool: Use asciidoctor for manpage

The Python implementation of Asciidoc is abandoned and stuck with Python 2.
Asciidoctor is a maintained implementation written in Ruby.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/992

Author: Florian Müllner
Author Date: 2019-11-30 18:52:42 UTC

extensions-tool: Add option to list updates

Now that we support extension updates, it may be useful to list
pending updates from the command line. It's easy enough to support,
so add a corresponding option to the list command.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/988

Author: Carlos Garnacho
Author Date: 2020-02-05 15:49:34 UTC

magnifier: Use core idletime monitor

As it's getting the idletime monitor for the seat pointer, boils
down to about the same thing. We are moving away from per-device
idletime monitors though.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/978

Author: jimmac
Author Date: 2020-02-04 11:29:02 UTC

theme: update system grey background

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/2174

Author: Carlos Garnacho
Author Date: 2020-01-31 10:12:19 UTC

shellEntry: Look up keymap from the ClutterSeat

The get_keymap() method no longer exists on the ClutterBackend, but was
moved to the ClutterSeat.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/969

Author: Matthias Clasen
Author Date: 2019-12-06 04:10:54 UTC

data: Stop providing an Access portal backend

A portal review by the design team has concluded that
it is better to have all portals as application-modal
GTK dialogs, instead of mixing them with some system-modal
shell dialogs.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1994

Author: Umang Jain
Author Date: 2019-12-17 09:55:21 UTC

gnome-shell-sass: Add top padding to unlock-dialog-clock-time

The (imaginary)center line for clock time of unlock dialog and the user
avatar should be the same. Since the clock font is 64pt, we need
32pt padding (or 42px).

Author: Benjamin Berg
Author Date: 2019-12-13 18:07:16 UTC

util: Improve systemd start/stop API to permit waiting for job

In some cases it may be interesting to wait for the start/stop job to
complete. Improve the API to be asynchronous and add the appropriate
watches for systemd. Only return the task once the start or stop job has
been removed again on the systemd side.

Author: Carlos Garnacho
Author Date: 2019-12-13 17:14:51 UTC

workspace: Pass device to startDrag()

This is necessary to make DnD operations work from tablet devices on
wayland, as it's not the same onscreen pointer sprite than mice. Fixes
window DnD in the overview on tablet devices, no longer having them stick
to the wrong pointer.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/897

Author: Umang Jain
Author Date: 2019-12-10 19:05:10 UTC

StPasswordEntry: Add the peek-password-icon for show/hide passwords

Also introduce a "show-peek-icon" property to enable/disable
the peek-password-icon in the password entry. This is useful
in cases where the peeking the password functionality needs
to be avoided.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/619

Author: Georges Basile Stavracas Neto
Author Date: 2019-10-17 06:42:37 UTC

altTab: Switch to MetaWindowContent

Author: Georges Basile Stavracas Neto
Author Date: 2019-10-15 19:34:35 UTC

authPrompt: Wiggle on failure

WIP

Author: Georges Basile Stavracas Neto
Author Date: 2018-11-27 14:33:15 UTC

dnd: Finish animation before destroying actor

Otherwise JavaScript aborts the execution of the function
and the drag is never released. That's because _dragComplete
tries to unhide this._dragActor from picking, and that cannot
be done after calling this._dragActor.destroy(), which is
the case now.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/744

Author: Exalm
Author Date: 2019-09-14 07:10:40 UTC

power: Ceil percentage when looking for icon

Use correct battery icon. For example, use battery-level-10-symbolic, with
a warning, on 1%-10% instead of 10%-19%.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1617

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/726

Author: Benjamin Berg
Author Date: 2019-04-19 22:19:17 UTC

data: Add desktop autostart file for extension warning

Adding this file allows gnome-session to trigger the warning after it
disabled extensions in the non-systemd case.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/695