lp:gnome-shell

Owned by GNOME3 Team
Get this repository:
git clone https://git.launchpad.net/gnome-shell

Import details

Import Status: Reviewed

This repository is an import of the Git repository at https://git.gnome.org/browse/gnome-shell/.

The next import is scheduled to run .

Last successful import was .

Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 1 minute — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 1 minute — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 2 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 1 minute — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 40 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 40 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 50 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 50 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 40 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 40 seconds — see the log

Branches

Name Last Modified Last Commit
wip/wjt/dont-set-welcome-dialog-last-shown-if-tour-not-installed 2022-08-16 06:07:16 UTC
main: Only set last-shown-version if welcome actually shown

Author: Will Thompson
Author Date: 2022-08-16 06:07:16 UTC

main: Only set last-shown-version if welcome actually shown

At startup, if the welcome-dialog-last-shown-version GSetting compares
older than WELCOME_DIALOG_LAST_TOUR_CHANGE, Shell attempts to offer the
welcome tour to the user, and then sets that GSetting to the current
version of Shell.

However, showing the welcome dialog can fail. In particular, if
gnome-tour is not installed, WelcomeDialog.open() returns false and the
dialog is not shown; but there are other reasons, such as another modal
dialog already being open. Previously, welcome-dialog-last-shown-version
would nonetheless be updated in this case, so if you subsequently
install gnome-tour (or on the next login, if there is no modal dialog),
the welcome dialog will not be offered until the next time
WELCOME_DIALOG_LAST_TOUR_CHANGE is bumped.

Instead, check whether WelcomeDialog.open() fails; if so, don't update
welcome-dialog-last-shown-version.

main 2022-08-15 17:30:47 UTC
style: Visual papercut fixes for quicksettings

Author: Sam Hewitt
Author Date: 2022-08-15 17:30:47 UTC

style: Visual papercut fixes for quicksettings

- fixes #5742

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2427>

gnome-42 2022-08-15 11:55:13 UTC
Update Catalan translation

Author: Jordi Mas
Author Date: 2022-08-15 11:55:13 UTC

Update Catalan translation

gnome-41 2022-08-11 13:16:07 UTC
Bump version to 41.9

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2022-08-11 13:16:07 UTC

Bump version to 41.9

Update NEWS.

gbsneto/access-portal-ignore-focus-window-for-screenshot 2022-08-08 02:02:40 UTC
accessDialog: Skip focus check for screenshot permissions

Author: Georges Basile Stavracas Neto
Author Date: 2022-08-08 01:55:37 UTC

accessDialog: Skip focus check for screenshot permissions

Screenshot is a special case compared to other permissions because
apps might want to hide themselves from the desktop when a screenshot
is about to be taken. In that case, this heuristic of checking if
the focus window corresponds to the application that is requesting
screenshot permissions becomes problematic.

Special case the screenshot permission to skip the focused window
check.

See also: https://github.com/flatpak/xdg-desktop-portal/pull/851

4592-calendar-correct-handling-of-recurring-events 2022-07-15 11:57:20 UTC
calendar: Correct handling of recurring events

Author: Milan Crha
Author Date: 2022-06-06 15:31:23 UTC

calendar: Correct handling of recurring events

When a recurring event has deleted a single instance, it's received
as an event modification, thus make sure all of the old instances
are removed before adding the event to the list of events.

Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4592

gnome-40 2022-06-21 09:36:27 UTC
kbdA11yDialog: Use MetaKeyboardA11yFlags

Author: Olivier Fourdan
Author Date: 2022-06-14 14:38:27 UTC

kbdA11yDialog: Use MetaKeyboardA11yFlags

The change in mutter to move keyboard accessibility into backends needs
to be applied in gnome-shell as well, otherwise the keyboard
accessibility dialog cannot work.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2306
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2334>
(cherry picked from commit ed910a7216bd7afe0dea06228d532f2e17d70b4d)

wip/snwh/notification-layout-rework 2022-06-14 13:48:35 UTC
notifications: Rework notification layout to not rely on css hacks

Author: Sam Hewitt
Author Date: 2022-05-31 18:29:32 UTC

notifications: Rework notification layout to not rely on css hacks

- rework message bubbles to have elements laid out in a sensible way
- remove some of the css hacks that assisted the layout
- rework the media player widget to not be as constrained by the notification layout
- clean up notifications css

wip/snwh/search-layout-changes 2022-06-02 14:29:35 UTC
search: Change results to entirely vertical layout

Author: Sam Hewitt
Author Date: 2022-05-26 17:04:02 UTC

search: Change results to entirely vertical layout

- rearrange search provider button contents
- cleanup search related styles & reduce padding

wip/snwh/menu-ornament-rework 2022-05-27 18:37:11 UTC
popovers: Convert menu ornament to icons and cleanup stylesheets

Author: Sam Hewitt
Author Date: 2022-05-27 13:40:03 UTC

popovers: Convert menu ornament to icons and cleanup stylesheets

- convert ornaments to icons
- add check and radio icon assets for ornaments
- cleanup a lot of stylesheet hacks because the ornaments used to be labels

wip/carlosg/pad-osd-labels 2022-04-30 12:14:31 UTC
padOsd: Figure out label/edition UI positions from unchanged fonts

Author: Carlos Garnacho
Author Date: 2022-04-30 12:09:37 UTC

padOsd: Figure out label/edition UI positions from unchanged fonts

We can figure out the better position to render the text without
resorting to sub-pixel font sizes.

bilelmoussaoui/libcanberra-sound 2022-04-14 10:35:09 UTC
sound player: Add Shell implementation of mutter#2375

Author: Bilal Elmoussaoui
Author Date: 2022-04-14 10:35:09 UTC

sound player: Add Shell implementation of mutter#2375

wip/carlosg/alt-tab-focus-timestamps 2022-04-08 14:18:35 UTC
switcherPopup: Avoid Clutter.CURRENT_TIME timestamps

Author: Carlos Garnacho
Author Date: 2022-04-08 14:18:35 UTC

switcherPopup: Avoid Clutter.CURRENT_TIME timestamps

Request the last time with a roundtrip here, in order to ensure the
received time is not Clutter.CURRENT_TIME, and mistakenly triggers the
meta_window_set_demands_attention() paths in window activation.

Fixes some situations that very quick alt press, tab press, alt release,
tab release sequences trigger "$app needs attention" notifications.

wip/wjt/eos-updater 2022-01-26 10:53:04 UTC
endSessionDialog: Support eos-updater [DRAFT]

Author: Will Thompson
Author Date: 2022-01-26 10:43:13 UTC

endSessionDialog: Support eos-updater [DRAFT]

eos-updater is used in Endless OS and GNOME OS.

Much more invasive changes will be needed since the eos-updater state
machine looks very different to the packagekit state machine. The update
is staged in the background; once staged, the next clean
shutdown/startup or reboot will boot straight into the new version.

4944-sttexturecache-keeping-thousands-of-icons-from-the-appindicator-extension 2022-01-14 20:14:21 UTC
style: Stylesheet updates for GNOME 42

Author: Sam Hewitt
Author Date: 2021-12-28 13:46:54 UTC

style: Stylesheet updates for GNOME 42

- updated switch assets
 - new high contrast assets
- use non-hardcoded bg color for dash
- updated palette colors
 - add missing color definitions to hc
- increase radii of many elements
- update search entry style
- align icon better in search entry
- restyle panel popovers without arrow and add drop shadow
- used theme colors in panel
- fix some things with popover labels
- new slider style
- some light variant fixes
- fixes to the calendar popover
 - day with event styles
 - better calendar-today.svg and dark variant
 - shorten calendary weekday header
 - saner padding
- overhaul popover menu style
- minor fixes to app grid and alt-tab switch
- updated looking glass styles
- nm-dialog adjustments
- search results adjustments
- expand out panel button hover styles
- button drawing adjustments
- adjust notifications area
- update on-screen keyboard style
 - better keyboard symbolic icon assets
 - change keyboard symbolic icons to 24px
 - improved keyboard style
 - gave the keyboard word suggestions some styles
- less obnoxious saner media control buttons
- cleaned up the css for the dash
- reworked the alt-tab switcher style
- sync style on workspace switcher
- adjusted dialog button style drawing
- popover submenu redrawing adjustement

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2104>

wip/snwh/icon-resources 2022-01-12 18:20:34 UTC
new symbolic icon assets

Author: Sam Hewitt
Author Date: 2022-01-12 18:20:34 UTC

new symbolic icon assets
 - migrate theme assets to symbolic icons
 - new local osd icons
 - general cleanup of symbolics

ewlsh/dead-code 2022-01-05 15:42:49 UTC
loginDialog: Remove some dead code

Author: Evan Welsh
Author Date: 2021-10-30 22:22:25 UTC

loginDialog: Remove some dead code

_getBannerAllocation() takes a single argument.

155-move-functionality-from-evolution-alarm-notify-to-gnome-shell-calendar-server 2021-11-29 15:03:25 UTC
calendar-server: Add 'Dismiss' button and application action

Author: Milan Crha
Author Date: 2021-11-29 15:03:25 UTC

calendar-server: Add 'Dismiss' button and application action

- add 'Dismiss' button to the notification
- introduce org.gnome.Shell.CalendarServer.desktop.in.in to benefit from GNotification API

Closes https://gitlab.gnome.org/GNOME/gnome-shell/issues/155

wip/hadess/import-gnome-bluetooth 2021-11-02 14:28:17 UTC
bluetooth: Remove unused shell_bluetooth_type_to_filter_string()

Author: Bastien Nocera
Author Date: 2021-11-02 14:25:12 UTC

bluetooth: Remove unused shell_bluetooth_type_to_filter_string()

drop-osk-key-repeat-feature 2021-10-07 17:59:50 UTC
keyboard: Emit key release right away

Author: Ray Strode
Author Date: 2021-10-06 19:42:17 UTC

keyboard: Emit key release right away

At the moment the on-screen keyboard doesn't emit the key release event
until the user stops pushing the keyboard button with their pointer.

This means if the user uses the pointer to hold the button down, it can
generate repeat events for some keys.

But this creates a bit of an inconsistency in behavior between keys that
support multiple choices via long press and those that don't. The ones
that support long press, don't repeat, instead they show the available
choices.

Furthermore, key repeat doesn't work for any of the keys with the
wayland backend, since key repeat is a client side thing, and we just
don't have it implemented for this path.

Also, key repeat is repeating the wrong keys right now, even on X11, for
keys that require a shift level (see
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2045 )

Given key repeat is a dubious feature in an on-screen keyboard to begin
with, and it's only implemented for one backend, and it's not even
completely working on that backend, it's probably best to drop support.

This commit changes the on-screen keyboard to always emit a key
release immediately after each key press.

ewlsh/esm 2021-09-24 01:26:20 UTC
ESM Part 1

Author: Evan Welsh
Author Date: 2021-09-18 06:48:04 UTC

ESM Part 1

gnome-3-38 2021-08-17 23:32:36 UTC
Bump version to 3.38.6

Author: =?utf-8?q?Florian_M=C3=BCllner?=
Author Date: 2021-08-17 23:32:36 UTC

Bump version to 3.38.6

Update NEWS.

wip/jimmac/searchbox-nostroke 2021-07-22 12:04:55 UTC
theme: Searchbar with no border

Author: jimmac
Author Date: 2021-07-22 11:19:50 UTC

theme: Searchbar with no border

- don't do stroke on search entry, sync with all other entries
- Tobias' GUADEC mini initiated

zbrown/docgen 2021-07-19 01:44:06 UTC
ci: Build docs in CI

Author: Zander Brown
Author Date: 2021-06-07 00:10:28 UTC

ci: Build docs in CI

ewlsh/javascript-fixes 2021-07-15 03:19:45 UTC
Fix leftover and incorrect JavaScript.

Author: Evan Welsh
Author Date: 2021-07-15 03:19:45 UTC

Fix leftover and incorrect JavaScript.

run-dialog-parental-control 2021-06-24 13:22:37 UTC
runDialog: Don't run commands for apps filtered by parental controls

Author: Felipe Borges
Author Date: 2021-06-24 13:19:57 UTC

runDialog: Don't run commands for apps filtered by parental controls

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4415

gnome-3-36 2021-05-31 16:41:56 UTC
calendar-server: Fix double-free detection abort

Author: Gustavo Noronha Silva
Author Date: 2021-05-18 18:28:43 UTC

calendar-server: Fix double-free detection abort

app_notify_events_added uses an intermediate builder to construct an
array that is then added to the main variant using g_variant_builder_add
which should clear the intermediate, but doesn't due to the way it is
passed: by value, rather than as a pointer.

This was debugged with the help of Eduardo Habkost, who believes it
works on x86 due to big structs being passed as pointers.

Fixed: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3440
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1848>

(cherry picked from commit 404ca91941226faaf2479609f0109244e66d4bcd)

wip/carlosg/startup-overview-check 2021-04-01 16:27:52 UTC
layout: Add check about whether session should start on Overview

Author: Carlos Garnacho
Author Date: 2021-04-01 15:03:13 UTC

layout: Add check about whether session should start on Overview

In situations that there are UI applications that are meant to be
started together with the session, it is undesirable to boot into
the overview.

In ideal situations, we would have session management infrastructure
in place that would allow GNOME Shell to find out there's UI services
to be brought up in the startup phase, and be able to decide window
positions and workspaces beforehand.

But we don't have any of that. Add a sneaky file existence test
so the behavior can be tweaked by savvy users and e.g. installers.
The hope being that this is a temporary solution till we have the
ideal framework in place.

Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3854

wip/ewlsh/protocol 2021-02-20 19:07:36 UTC
Implement gnome-extensions:// protocol.

Author: Evan Welsh
Author Date: 2021-02-20 18:15:46 UTC

Implement gnome-extensions:// protocol.

Add a simple protocol to install extensions.
Currently supports gnome-extensions://install?uuid=name@name.com

wip/aday/app-grid-layou 2021-02-19 17:04:33 UTC
schemas: Define default app grid arrangement

Author: Allan Day
Author Date: 2021-02-19 15:58:18 UTC

schemas: Define default app grid arrangement

Specify the default app grid arrangement. This makes the app grid
more useful since the interesting apps are prioritised. It also
communicates that the app grid can be customised.

Fixes #3122

wip/jimmac/app-icon-shadows 2021-02-05 14:59:09 UTC
appDisplay: Revisit "Add drop shadow to icons"

Author: jimmac
Author Date: 2021-02-04 13:16:00 UTC

appDisplay: Revisit "Add drop shadow to icons"

The shadow is barely visible on dark backgrounds, but it's not
wrong to be consistent with Settings, Software and GNOME Classic.

With the app icon swarm animation gon, the performance implications might not be as critical (https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3124

- increase blur but not much, while we can't have multi-layered shadows.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3670
Also see https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3123

wip/jimmac/dash-icon-spacing 2021-02-04 11:54:18 UTC
theme: adjust dash icon spacing

Author: jimmac
Author Date: 2021-02-02 11:01:15 UTC

theme: adjust dash icon spacing

- no padding between icon containers, except the first and last

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3640

gbsneto/profiling-for-real 2020-12-01 13:38:37 UTC
plugin: Implement profiling vfuncs

Author: Georges Basile Stavracas Neto
Author Date: 2020-09-02 20:35:23 UTC

plugin: Implement profiling vfuncs

Use the new GJS API to pass an external capture writer, and
start/stop whenever the compositor asks us to do so.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1430

wip/fmuellner/appstream-mappings 2020-11-20 22:04:37 UTC
appDisplay/pageManager: Update layout when apps are renamed

Author: Florian Müllner
Author Date: 2020-11-19 03:04:14 UTC

appDisplay/pageManager: Update layout when apps are renamed

Now that the app picker uses custom, user-defined positioning, it
makes sense to pick up renamed app IDs like we do for favorites.

wip/rstrode/rhel-7.9 2020-11-12 18:09:34 UTC
weather: Don't spew messages when geolocation is unavailable

Author: Ray Strode
Author Date: 2020-10-14 19:40:05 UTC

weather: Don't spew messages when geolocation is unavailable

It's not a requirement that the xdg portal is installed, so we
shouldn't log an error when it's not.

Furthermore, we shouldn't log an error when geolocation is disabled
in settings.

This commit mutes the log spew.

wip/carlosg/small-api-cleanups 2020-10-06 16:17:30 UTC
shell: Update to MetaCursorTracker API change

Author: Carlos Garnacho
Author Date: 2020-07-20 10:08:43 UTC

shell: Update to MetaCursorTracker API change

The pointer coordinates in meta_cursor_tracker_get_pointer() are now
returned as a graphene_point_t.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1405

gnome-3-28 2020-08-17 11:53:07 UTC
shell-global: Make saving of persistent state asynchronous

Author: Carlos Garnacho
Author Date: 2018-12-03 12:09:47 UTC

shell-global: Make saving of persistent state asynchronous

This is an expensive operation that is best avoided in the main loop. Given
the call doesn't care much about returning error or status, it can just
be made async within.

Every operation on a given file will be destructive wrt previous
operations on the same file, so we just cancel any pending operation on
it before batching the current one.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/815

(cherry picked from commit 86a00b6872375a266449beee1ea6d5e94f1ebbcb)

benzea/use-app-info-launch 2020-07-31 15:11:24 UTC
runDialog: Use new app based launch helper

Author: Benjamin Berg
Author Date: 2020-07-31 13:43:25 UTC

runDialog: Use new app based launch helper

Doing this has the advantage of using the GLib GDesktopAppInfo launching
API, resulting in the automatic registration of the application with
systemd.

See: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1596
Closes: #3025

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1384

wip/exalm/corners 2020-06-23 20:16:50 UTC
Add screen corners

Author: Exalm
Author Date: 2020-06-23 19:20:59 UTC

Add screen corners

Commit message TBD

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1328

wip/ewlsh/unify-app-menus 2020-06-21 08:28:17 UTC
Initial experiment unifying app menus.

Author: Evan Welsh
Author Date: 2020-06-21 08:28:17 UTC

Initial experiment unifying app menus.

cherry-pick-46547ae0 2020-06-05 15:22:00 UTC
shell-mime-sniffer: Ignore invalid file content type

Author: Marco Trevisan (Treviño)
Author Date: 2020-06-05 14:12:58 UTC

shell-mime-sniffer: Ignore invalid file content type

The shell mime sniffer goes through all the files in a directory,
however in case a file content type is not recognized, the GIO function
g_file_info_get_content_type() may return NULL, causing a crash when
looking up into the content type tables, as they are supposed to contain
strings only and they use `g_str_hash` has func, which doesn't support
NULL values.

So, in case we get an invalid content type, let's just ignore it,
without adding it to the cache as we do in the nautilus code that was
inspiring the sniffer.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2643

(cherry picked from commit 46547ae02797558699510595b27857b80c027b5b)

gnome-3-34 2020-06-01 20:09:11 UTC
Updated Slovenian translation

Author: Matej Urbančič
Author Date: 2020-06-01 20:09:11 UTC

Updated Slovenian translation

wip/carlosg/im-caret-taps-x11-3.36 2020-05-12 14:41:45 UTC
keyboard: Detect taps close to the cursor caret on X11

Author: Carlos Garnacho
Author Date: 2020-05-12 14:41:45 UTC

keyboard: Detect taps close to the cursor caret on X11

Try to bring some feature parity wrt OSK being toggled on. Set up
a gesture that triggers on taps nearby the text caret position, as
reported by ibus.

wip/mcrha/issue1875 2020-04-27 16:14:57 UTC
calendar-server: Improve performance by properly using ECalClientView

Author: Milan Crha
Author Date: 2020-04-02 07:24:28 UTC

calendar-server: Improve performance by properly using ECalClientView

The previous code always restarted whole ECalClientView when it received
any changes in it, which could sometimes lead to constant repeated restarts
of the view.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/1875

gtk3-ci 2020-04-06 17:37:35 UTC
animation: Set size through CSS

Author: Georges Basile Stavracas Neto
Author Date: 2020-04-06 14:19:28 UTC

animation: Set size through CSS

Pretty much the same case of the previous commit: we want this size
to be scale-dependant, and using the width and height properties of
ClutterActor doesn't automatically update.

Use CSS to set the width and height.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1176

gbsneto/eager-cache-invalidation 2020-04-03 22:01:08 UTC
st/theme-context: Invalidate texture cache when scaling changes

Author: Georges Basile Stavracas Neto
Author Date: 2020-04-03 22:00:28 UTC

st/theme-context: Invalidate texture cache when scaling changes

wip/smcv/issue2538 2020-04-03 09:04:26 UTC
blur: Always allocate at least one pixel

Author: Simon McVittie
Author Date: 2020-04-02 18:32:18 UTC

blur: Always allocate at least one pixel

This works around a crash when we try to blur a background that hasn't
yet had any space allocated for it, in particular when locking the screen
with mutter 3.36.1 and the Native Window Placement extension.

Workaround for <https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2538>.

Signed-off-by: Simon McVittie <smcv@debian.org>

cherry-pick-a0def239 2020-04-01 03:58:56 UTC
main: Don't override DesktopAppInfo desktop if already GNOME

Author: Marco Trevisan (Treviño)
Author Date: 2020-03-31 18:13:46 UTC

main: Don't override DesktopAppInfo desktop if already GNOME

During the shell initialization we call the (deprecated) function to
override the Desktop environment in Gio DesktopAppInfo to make sure that
applications are correctly shown (as per commit b2fbf5a2), however this
might break the cases in which $XDG_CURRENT_DESKTOP is already set and
contains GNOME (given that is now a list).

In Ubuntu this is in fact set to: ubuntu:GNOME.
Now, if an application contains NotShowIn=ubuntu, the key will be ignored by
the shell, and the application is still listed everywhere.

So, override the DesktopAppInfo desktop environment only in the case that
the current desktop is not already GNOME.

At the current date I think we could just safely get rid of this override at
all, but there could be still cases where it still might be useful, like when
running as nested in some other environment, so keeping it.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1156

(cherry picked from commit a0def239408b389020c8d2dc634ab0250e2d9721)

bilelmoussaoui/extensions/fix 2020-03-02 10:59:43 UTC
ExtensionsPref: always convert the extension version to a string

Author: Bilal Elmoussaoui
Author Date: 2020-03-02 10:02:56 UTC

ExtensionsPref: always convert the extension version to a string

This fixes: Wrong type number; string expected
MR: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1060

wip/chergert/3-28-perf-fixes 2020-02-28 17:24:15 UTC
app-cache: add ShellAppCache for GAppInfo caching

Author: Christian Hergert
Author Date: 2020-02-28 03:48:35 UTC

app-cache: add ShellAppCache for GAppInfo caching

This caches GAppInfo so that the compositor thread does not have to perform
costly disk access to load them. Instead, they are loaded from a worker
thread and the ShellAppCache notifies of changes.

To simplfy maintenace, ShellAppCache manages this directly and the
existing ShellAppSystem wraps the cache. We may want to graft these
together in the future, but now it provides the easiest way to backport
changes to older Shell releases.

Another source of compositor thread disk access was in determining the
name for an application directory. Translations are provided via GKeyFile
installed in "desktop-directories". Each time we would build the name
for a label (or update it) we would have to load all of these files.

Instead, the ShellAppCache caches that information and updates the cache
in bulk when those change. We can reduce this in the future to do less
work, but chances are these will come together anyway so that is probably
worth fixing if we every come across it.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2282

wip/exalm/gestures 2020-02-26 09:36:10 UTC
workspaceAnimation: Support multiple monitors

Author: Alexander Mikhaylenko
Author Date: 2019-07-04 18:43:23 UTC

workspaceAnimation: Support multiple monitors

Currently, there's one animation for the whole canvas. While it looks fine
with just one screen, it causes windows to move between screens when
switching workspaces. Instead, have a separate animation on each screen,
and sync their progress so that at any given time the progress "fraction"
is the same between all screens. Clip all animations to their screens so
that the windows don't leak to other screens.

If a window is placed between every screen, can end up in multiple
animations, in that case each part is still animated separately.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1213

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/605

wip/jimmac/osk-338-tweaks 2020-02-20 14:02:28 UTC
theme: OSK opaque

Author: jimmac
Author Date: 2020-02-20 13:08:34 UTC

theme: OSK opaque

- the on screen keyboard is not an overlay in most cases. the semi-opacity
  is distracting.
- use opaque background color
- see discussion on https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1028

  FIXME: whitespace at the bottom without scaling everything down (padding)
  FIXME: don't behave as overlay anywhere (even for entries above the fold)

wip/jtojnar/adoc 2020-02-11 03:22:32 UTC
extension-tool: Use asciidoctor for manpage

Author: Jan Tojnar
Author Date: 2020-02-11 02:42:42 UTC

extension-tool: Use asciidoctor for manpage

The Python implementation of Asciidoc is abandoned and stuck with Python 2.
Asciidoctor is a maintained implementation written in Ruby.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/992

gbsneto/new-lock-screen-part2 2020-02-10 22:43:00 UTC
extensions-tool: Add option to list updates

Author: Florian Müllner
Author Date: 2019-11-30 18:52:42 UTC

extensions-tool: Add option to list updates

Now that we support extension updates, it may be useful to list
pending updates from the command line. It's easy enough to support,
so add a corresponding option to the list command.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/988

wip/carlosg/drop-device-idle-monitors 2020-02-05 16:17:30 UTC
magnifier: Use core idletime monitor

Author: Carlos Garnacho
Author Date: 2020-02-05 15:49:34 UTC

magnifier: Use core idletime monitor

As it's getting the idletime monitor for the seat pointer, boils
down to about the same thing. We are moving away from per-device
idletime monitors though.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/978

wip/jimmac/system-grey-tweak 2020-02-04 14:28:56 UTC
theme: update system grey background

Author: jimmac
Author Date: 2020-02-04 11:29:02 UTC

theme: update system grey background

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/2174

wip/carlosg/lockscreen-fix 2020-01-31 10:18:54 UTC
shellEntry: Look up keymap from the ClutterSeat

Author: Carlos Garnacho
Author Date: 2020-01-31 10:12:19 UTC

shellEntry: Look up keymap from the ClutterSeat

The get_keymap() method no longer exists on the ClutterBackend, but was
moved to the ClutterSeat.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/969

drop-portal 2020-01-20 16:48:31 UTC
data: Stop providing an Access portal backend

Author: Matthias Clasen
Author Date: 2019-12-06 04:10:54 UTC

data: Stop providing an Access portal backend

A portal review by the design team has concluded that
it is better to have all portals as application-modal
GTK dialogs, instead of mixing them with some system-modal
shell dialogs.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1994

uajain/adapt-user-avatar 2019-12-17 09:57:31 UTC
gnome-shell-sass: Add top padding to unlock-dialog-clock-time

Author: Umang Jain
Author Date: 2019-12-17 09:55:21 UTC

gnome-shell-sass: Add top padding to unlock-dialog-clock-time

The (imaginary)center line for clock time of unlock dialog and the user
avatar should be the same. Since the clock font is 64pt, we need
32pt padding (or 42px).

benzea/systemd-start-waiting 2019-12-13 18:25:00 UTC
util: Improve systemd start/stop API to permit waiting for job

Author: Benjamin Berg
Author Date: 2019-12-13 18:07:16 UTC

util: Improve systemd start/stop API to permit waiting for job

In some cases it may be interesting to wait for the start/stop job to
complete. Improve the API to be asynchronous and add the appropriate
watches for systemd. Only return the task once the start or stop job has
been removed again on the systemd side.

wip/carlosg/fix-tablet-overview-window-dnd 2019-12-13 17:53:41 UTC
workspace: Pass device to startDrag()

Author: Carlos Garnacho
Author Date: 2019-12-13 17:14:51 UTC

workspace: Pass device to startDrag()

This is necessary to make DnD operations work from tablet devices on
wayland, as it's not the same onscreen pointer sprite than mice. Fixes
window DnD in the overview on tablet devices, no longer having them stick
to the wrong pointer.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/897

uajain/st-entry-password-2 2019-12-13 13:09:18 UTC
StPasswordEntry: Add the peek-password-icon for show/hide passwords

Author: Umang Jain
Author Date: 2019-12-10 19:05:10 UTC

StPasswordEntry: Add the peek-password-icon for show/hide passwords

Also introduce a "show-peek-icon" property to enable/disable
the peek-password-icon in the password entry. This is useful
in cases where the peeking the password functionality needs
to be avoided.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/619

gbsneto/content-part2 2019-10-17 06:42:37 UTC
altTab: Switch to MetaWindowContent

Author: Georges Basile Stavracas Neto
Author Date: 2019-10-17 06:42:37 UTC

altTab: Switch to MetaWindowContent

gbsneto/new-lock-screen 2019-10-15 19:34:35 UTC
authPrompt: Wiggle on failure

Author: Georges Basile Stavracas Neto
Author Date: 2019-10-15 19:34:35 UTC

authPrompt: Wiggle on failure

WIP

gbsneto/dnd-fixes 2019-09-26 13:32:07 UTC
dnd: Finish animation before destroying actor

Author: Georges Basile Stavracas Neto
Author Date: 2018-11-27 14:33:15 UTC

dnd: Finish animation before destroying actor

Otherwise JavaScript aborts the execution of the function
and the drag is never released. That's because _dragComplete
tries to unhide this._dragActor from picking, and that cannot
be done after calling this._dragActor.destroy(), which is
the case now.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/744

wip/exalm/battery 2019-09-14 07:17:46 UTC
power: Ceil percentage when looking for icon

Author: Exalm
Author Date: 2019-09-14 07:10:40 UTC

power: Ceil percentage when looking for icon

Use correct battery icon. For example, use battery-level-10-symbolic, with
a warning, on 1%-10% instead of 10%-19%.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1617

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/726

benzea/systemd-user-units-with-extension-warning 2019-08-30 16:58:50 UTC
data: Add desktop autostart file for extension warning

Author: Benjamin Berg
Author Date: 2019-04-19 22:19:17 UTC

data: Add desktop autostart file for extension warning

Adding this file allows gnome-session to trigger the warning after it
disabled extensions in the non-systemd case.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/695

gnome-3-32 2019-08-21 19:29:31 UTC
shell: Ignore non-toplevels for ShellWindowTracker::tracked-windows-changed

Author: Carlos Garnacho
Author Date: 2019-07-19 16:17:54 UTC

shell: Ignore non-toplevels for ShellWindowTracker::tracked-windows-changed

Popups and other override-redirect windows are meaningless to everything
that depends on the ShellWindowTracker. Ignoring those windows will result
in less ShellApp::windows-changed signal emissions, and less activity in
the AppMenuButton and everything else that depends on them.

Reduces gnome-shell CPU activity while typing on the Epiphany addressbar,
as the pop up animation there results in a number of xdg_popup being
created and destroyed.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/642
https://gitlab.gnome.org/GNOME/mutter/issues/556

(cherry picked from commit db9a7ea7a9b4c9485428a63a0bb4b8c2446ba801)

gnome-3-30 2019-08-21 11:38:25 UTC
Update Persian translation

Author: Danial Behzadi
Author Date: 2019-08-21 11:38:25 UTC

Update Persian translation

gbsneto/icon-grid-dnd 2019-08-02 19:33:04 UTC
appDisplay: Close popup when dragging

Author: Georges Basile Stavracas Neto
Author Date: 2019-07-04 19:03:20 UTC

appDisplay: Close popup when dragging

When a drag starts inside a folder, and the cursor moves to
outside it, close the currently opened folder popup.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/603

gbsneto/more-content 2019-07-16 17:31:30 UTC
workspace, workspaceThumbnail: Use window content (WIP)

Author: Georges Basile Stavracas Neto
Author Date: 2019-07-16 17:07:10 UTC

workspace, workspaceThumbnail: Use window content (WIP)

issue369 2019-07-08 11:57:23 UTC
endSessionDialog: Check for PackageKit before considering updates/upgrades

Author: Mario Sanchez Prada
Author Date: 2019-07-08 06:51:36 UTC

endSessionDialog: Check for PackageKit before considering updates/upgrades

GNOME Shell is spitting out some errors in the journal due to its attempts
to speak to PackageKit, which is not present on Endless OS, so let's add
some runtime checks to make sure that PackageKit is actually available
before assuming so and using its proxy to decide which kind of UI to
show to the user when ending the session.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/369

wip/aday/standardise-text-styles 2019-06-27 12:52:40 UTC
adjust UI to new text styles

Author: Allan Day
Author Date: 2019-06-26 13:52:09 UTC

adjust UI to new text styles

With the new text styles, some UI needs to adjusted, primarily to
accommodate larger heading text.

wip/jimmac/typography 2019-06-25 12:28:49 UTC
theme: Standardise text styles

Author: Allan Day
Author Date: 2019-06-19 10:10:28 UTC

theme: Standardise text styles

Initial attempt to use standard text styles, in line with what's
being done for GTK (https://gitlab.gnome.org/GNOME/gtk/issues/1808).

This is just changing the sizes and weights for now. Spacing
adjustments will be required further down the line.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/594

wip/jimmac/sync-with-adwaita 2019-06-24 08:10:14 UTC
Theme: update to sync with gtk Adwaita

Author: Frederik Feichtmeier
Author Date: 2019-06-18 13:29:00 UTC

Theme: update to sync with gtk Adwaita

- consistent OSD colors
- consistent fg/bg colors
- updated rounded corners
- switches

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/841

wip/nielsdg/remove-coglerror 2019-06-20 08:19:37 UTC
Drop CoglError for GError

Author: NielsDG
Author Date: 2019-06-20 08:12:16 UTC

Drop CoglError for GError

From https://gitlab.gnome.org/GNOME/mutter/merge_requests/631

```
CoglError was added at a certain point to remove the hard dependency on
GLib, but since this can't be avoided inside mutter, let's remove this
whole abstraction.
```

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/585

wip/jimmac/frederik-light 2019-06-15 16:32:18 UTC
Icon tile changes

Author: Frederik Feichtmeier
Author Date: 2019-06-15 16:32:18 UTC

Icon tile changes

- use the medium radius
- make checked tiles less hardcore black
- adjust folder popup bg color to checked tiles

wip/jimmac/adwaita-light 2019-05-27 14:03:40 UTC
theme: use light theme for popovers

Author: jimmac
Author Date: 2019-05-27 14:03:40 UTC

theme: use light theme for popovers

Make shell mimic Adwaita gtk.

FIXME:
 - switches
 - buttons
 - modal dialogs

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1045

wip/mcrha/eds-libical-glib 2019-05-17 20:24:08 UTC
calendar-server: Port to libecal-2.0

Author: Milan Crha
Author Date: 2019-04-18 14:21:43 UTC

calendar-server: Port to libecal-2.0

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/501

wip/fmuellner/ease-wm-animations 2019-05-15 22:08:07 UTC
windowManager: Use easing for window animations

Author: Florian Müllner
Author Date: 2018-07-20 19:46:19 UTC

windowManager: Use easing for window animations

wip/carlosg/fix-osk-warnings 2019-05-09 22:09:23 UTC
keyboard: Fix warnings on destroyed actors

Author: Carlos Garnacho
Author Date: 2019-05-09 22:07:25 UTC

keyboard: Fix warnings on destroyed actors

Trying to hide a page gets hard when the page was previouly destroyed.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1281

gnome-3-26 2019-05-03 21:33:58 UTC
dialog: Really set ellipsize mode in subtitle and body

Author: Marco Trevisan (Treviño)
Author Date: 2019-05-03 20:27:13 UTC

dialog: Really set ellipsize mode in subtitle and body

Dialog's subtitle or body could not be properly wrapped, while it's ellipsized
when the text's width doesn't exceed the container size.

Clutter text has an `ellipsize` property, however in dialog's subtitle and body
we have been setting the `ellipsize-mode` property to Pango.EllipsizeMode.NONE
that is not present in the underlying GObject.

Not being an error in javascript, gjs didn't warn us about this, while at the
same time the St.Label's default Pango.EllipsizeMode.END was used.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/922

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/531

(cherry picked from commit 3121c9aa29406ad85e949b697e90092f1fa6fc2e)

wip/rstrode/fix-smooshed-fedora 2019-04-30 18:58:26 UTC
texture-cache: preserve aspect ratio of loaded pixbufs

Author: Ray Strode
Author Date: 2019-04-30 18:58:26 UTC

texture-cache: preserve aspect ratio of loaded pixbufs

st_texture_cache_load_file_async takes optional width and height hints
to specify how much space on-screen the loaded image will take up. One
or both of the width and height can be negative.

gdk-pixbuf uses this information to scale down the image to an
appropriate size, when necessary, to save memory and prevent
aliasing.

gdk-pixbuf never uses this information to scale up the image, though;
that would just waste memory. Instead, the width and height hints are
used to set the geometry of the clutter content, so the texture may
get upscaled on-screen.

If both the passed in width and height are negative, it means to assume
the image will fit at native size, and gdk-pixbuf shouldn't downscale
the image.

If just one dimension is negative, it means the image should be
downscaled by gdk-pixbuf proportionally to fit the given (positive)
dimension.

If neither dimension is negative, it means the image should be
downscaled by gdk-pixbuf proportionally to fit whichever dimension keeps
the whole image within the bounds of its clutter content.

In any case, if the passed in width and height are bigger than the
dimensions of the loaded image, then those passed in values won't be used
by gdk-pixbuf, since it has no downscaling to do.

The problem is, the code that converts a pixbuf to a clutter content
fails to handle the case where the passed in dimensions aren't used by
gdk-pixbuf. It assumes at least one of the pixbuf dimensions matches the
dimensions passed to st_texture_cache_load_file_async. That won't be the
case if the pixbuf code had no downscaling to do.

This commit fixes that problem by deriving the unknown clutter content
dimension from the known clutter content dimension and the aspect ratio
of the image.

wip/fmuellner/opt-in-hot-corner 2019-04-29 17:33:22 UTC
layout: Offer to enable hot corner after repeated attempts to trigger it

Author: Florian Müllner
Author Date: 2019-04-29 17:27:39 UTC

layout: Offer to enable hot corner after repeated attempts to trigger it

wip/jimmac/osd-sync-with-gtk 2019-04-16 14:47:59 UTC
theme: sync OSD colors with gtk

Author: jimmac
Author Date: 2019-04-16 14:47:59 UTC

theme: sync OSD colors with gtk

1151-moving-window-up-to-a-new-workspace-clears-all-always-on-visible-workspace-flags 2019-04-03 13:27:42 UTC
weather: Handle missing permission store

Author: Florian Müllner
Author Date: 2019-04-03 10:35:03 UTC

weather: Handle missing permission store

Our weather integration is supposed to follow GNOME Weather's settings,
including its permission to use location services. However there's a
discrepancy in case xdg-desktop-portal is unavailable:

While our geoclue agent grants all applications access to location
services in that case, the weather integration treats it as if
access was denied.

Fix this by handling this case explicitly.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1130

gbsneto/automatic-updates 2019-03-19 12:18:54 UTC
Introduce updates indicator

Author: Georges Basile Stavracas Neto
Author Date: 2019-03-19 12:16:00 UTC

Introduce updates indicator

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/466

wip/jimmac/closebutton-tweaks 2019-03-11 19:52:27 UTC
theme: window close button touchup

Author: jimmac
Author Date: 2019-03-11 13:14:18 UTC

theme: window close button touchup

- tone down the shading considerably to match the previous look

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/453

wip/rstrode/rhel-8.0.0 2019-02-17 17:28:08 UTC
background: refresh background on gl-video-memory-purged signal

Author: Ray Strode
Author Date: 2019-01-21 20:07:15 UTC

background: refresh background on gl-video-memory-purged signal

Right now we refresh the background when resuming and when NVIDIA.
But mutter has a signal to tell us specifically when to refresh,
and the signal is only emitted for NVIDIA, so use that instead.

pot-ci 2019-02-09 03:51:00 UTC
ci: Check that pot file is generated correctly

Author: Florian Müllner
Author Date: 2019-02-09 03:51:00 UTC

ci: Check that pot file is generated correctly

This is to guard against the now infamous xgettext bug[0].

[0] https://savannah.gnu.org/bugs/?50920#comment5

gbsneto/fix-long-user-names 2019-02-07 19:54:35 UTC
system: Use username if full name is longer than 100 characters

Author: Georges Basile Stavracas Neto
Author Date: 2019-02-07 19:54:35 UTC

system: Use username if full name is longer than 100 characters

The current code relies on unstable behavior of ClutterText, and
does not really work as expected. Still, limiting the label size
is important.

Use a hardcoded limit of 100 characters instead of checking if
the layout is ellipsized already.

wip/timed-login-fix 2019-02-07 17:57:48 UTC
loginDialog: hide user list when starting timed login

Author: Ray Strode
Author Date: 2019-02-07 16:20:51 UTC

loginDialog: hide user list when starting timed login

If the timeout fires and we're starting timed login, we
should hide the user list, in case the login process
needs to show the user any messages on the auth prompt.

wip/fmuellner/remove-app-menu 2019-01-26 13:35:30 UTC
build: Don't introspect ShellMenu

Author: Florian Müllner
Author Date: 2018-10-04 18:09:25 UTC

build: Don't introspect ShellMenu

It is now only used internally by ShellApp to track remote actions,
so there's no need to expose it to javascript code.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/624

cherry-pick-74bb9e62 2019-01-21 16:28:20 UTC
ibusManager: Don't pass undefined callback to ibus

Author: Florian Müllner
Author Date: 2018-11-15 17:47:55 UTC

ibusManager: Don't pass undefined callback to ibus

Since commit 551e8278416, we don't always pass a callback parameter.
However passing it on as undefined to ibus doesn't work, as gjs doesn't
accept that as a valid callback value and throw an error. As a result,
we can end up with no layout selected in the keyboard menu and an "empty"
indicator. Fix this by explicitly passing null if no callback has been
provided.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/293

(cherry picked from commit 74bb9e62492bacda372904d30891eb97685e9b0c)

cherry-pick-b719744e 2019-01-16 00:05:59 UTC
st-bin: Destroy child in ClutterActor:destroy vfunc

Author: Georges Basile Stavracas Neto
Author Date: 2018-08-28 20:29:13 UTC

st-bin: Destroy child in ClutterActor:destroy vfunc

According to Clutter documentation, "[…] actors implementing the
ClutterContainer interface should override the default implementation
of the class handler of this signal and call clutter_actor_destroy()
on their children."

StBin was doing that in GObject:dispose() instead. Move the child
destruction to a new ClutterActor:destroy() vfunc override.

(cherry picked from commit b719744e75e56502cf0340066f9311fdcc755628)

wip/texture-purge-on-nvidia 2019-01-15 17:54:32 UTC
st-texture-cache: purge on resume

Author: Ray Strode
Author Date: 2019-01-15 17:54:32 UTC

st-texture-cache: purge on resume

With the proprietary nvidia driver, textures get garbled on suspend,
so the texture cache needs to evict all textures in that situation.

wip/rstrode/mouse-freeze-fix 2018-12-10 20:29:07 UTC
popupMenu: block input events when menu is closing

Author: Ray Strode
Author Date: 2018-12-10 20:25:35 UTC

popupMenu: block input events when menu is closing

At the moment gnome-shell can get really confused if a menu is
fading out and gets clicked.

It can lead to mouse pointer input getting stuck until the shell
is restarted.

This commit addresses the problem by ignoring input events that
come in when the menu is closing.

wip/jimmac/sharp-icons 2018-11-13 14:11:14 UTC
icons: avoid 96x96

Author: jimmac
Author Date: 2018-11-13 13:52:04 UTC

icons: avoid 96x96

- use 128 instead for total sharpness

see https://gitlab.gnome.org/GNOME/nautilus/issues/743

wip/fmuellner/background-gradient 2018-10-09 13:01:01 UTC
layout: Use background gradient when top bar is transparent

Author: Alessandro Bono
Author Date: 2017-08-19 15:17:40 UTC

layout: Use background gradient when top bar is transparent

Make sure the legibility of top bar elements doesn't depend on the
wallpaper by adding a light gradient at the top when the top bar
is transparent, similar to what Android does.

https://bugzilla.gnome.org/show_bug.cgi?id=783913

wip/fmuellner/duplicate-favs 2018-10-08 16:22:04 UTC
appFavorites: Don't add app explicitly

Author: Florian Müllner
Author Date: 2018-08-12 00:17:42 UTC

appFavorites: Don't add app explicitly

When adding a favorite, we add the ID to the list of favorites, save the
setting and add the new app to the favorites map. However as writing the
settings value already results in reload() to update the favorites map,
the new app is usually already in the map when we add it.

The only exception is when the ID was found in the RENAMED_DESKTOP_IDS map,
in which case we end up adding both the renamed app and the original one.
Fix this by simply relying on reload() to properly update the map, just like
we already do in _removeFavorite().

https://gitlab.gnome.org/GNOME/gnome-shell/issues/471

1100 of 196 results
This repository contains Public information 
Everyone can see this information.

Subscribers