gnome-shell:wip/wayland-gdm-cleanup

Last commit made on 2014-03-08
Get this branch:
git clone -b wip/wayland-gdm-cleanup https://git.launchpad.net/gnome-shell

Branch merges

Branch information

Name:
wip/wayland-gdm-cleanup
Repository:
lp:gnome-shell

Recent commits

28f4030... by Jasper St. Pierre

retrigger greeter

67fe376... by Jasper St. Pierre

gdm: Make the smartcard and service status fields private

We don't need to export these publicly any more.

fb82413... by Jasper St. Pierre

gdm: Integrate username asking into the ShellUserVerifier flow

Currently, prompting for the username on the login screen is done
"out-of-band". This leads to subtle bugs where we're trying to
integrate two different state machines, or interpret results from
one state machine as part of another.

It also complicates the logic, as the ability to know whether we
need or want a username is currently in the UI layer rather than
the logic layer.

Move this into the verifier proper.

056375c... by Jasper St. Pierre

gdm: Merge clear() and cancel()

cancel() isn't used anymore.

84431cb... by Jasper St. Pierre

gdm: Move reset-on-smartcard / reset-on-ovirt code to ShellUserVerifier

We still need to expose smartcardDetected to determine whether to
prompt for a username. This part is another hairy mess of signals
and layer violations that will need untangling, but we'll get there...

92c283d... by Jasper St. Pierre

gdm: Move the verificationStatus state machine to ShellUserVerifier

The idea here is that the ShellUserVerifier does all the logic of
identifying the user, and the AuthPrompt is simply the UI on top
of it.

Thus, it makes sense for more of the state machine to be driven by
the ShellUserVerifier.

This will become more apparent in the next commit.

6e27ef8... by Jasper St. Pierre

gdm: Emit the 'failed' status immediately, and not on reset

There's really no reason to do it this way: it works in both cases,
and it's a lot simpler to reason about.

0c511c8... by Jasper St. Pierre

gdm: Remove the (partially) unused cancelled signal

When we emit the 'cancelled' signal if we were previously verifying,
we'll always emit a 'failed' signal. LoginDialog doesn't care about
cancelled, only UnlockDialog cares about both, but it does the same
thing for both, so there's no reason to have the extra signal.

7afb503... by Jasper St. Pierre

gdm: Rearrange code to make it slightly easier to read

0b9d01a... by Jasper St. Pierre

gdm: Merge some duplicate code

Do a reset at initialization time.

Technically, this isn't needed, since to start the process we'll need
to reset(); anyway after all the signals have connected, but this helps
the code be clean.