powerpc-smp kernel flavour does not boot on OldWorld G3

From: Benjamin Herrenschmidt <email address hidden>

BugLink: https://bugs.launchpad.net/bugs/959959

The code for "powersurge" SMP would kick in and cause a crash
at boot due to the lack of a NULL test.

Signed-off-by: Benjamin Herrenschmidt <email address hidden>
Signed-off-by: Jeremy Kerr <email address hidden>
Reported-By: Adam Conrad <email address hidden>
Tested-By: Adam Conrad <email address hidden>

Cherry-picked from upstream commit
78c5c68a4cf4329d17abfa469345ddf323d4fd62

---
 arch/powerpc/platforms/powermac/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
index 9b6a820..3394254 100644
--- a/arch/powerpc/platforms/powermac/smp.c
+++ b/arch/powerpc/platforms/powermac/smp.c
@@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {

 static void __init smp_psurge_setup_cpu(int cpu_nr)
 {
- if (cpu_nr != 0)
+ if (cpu_nr != 0 || !psurge_start)
   return;

  /* reset the entry point so if we get another intr we won't

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 959959

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Not possible to run apport-collect in this situation, confirming manually.

Adam reports that this patch fixes the issue. Builds are at http://people.canonical.com/~jk/powerpc-oldworld-smp/ , if anyone else would like to test.

On Tue, Mar 20, 2012 at 9:27 AM, Jeremy Kerr <email address hidden> wrote:
> From: Benjamin Herrenschmidt <email address hidden>
>
> BugLink: https://bugs.launchpad.net/bugs/959959
>
> The code for "powersurge" SMP would kick in and cause a crash
> at boot due to the lack of a NULL test.
>
> Signed-off-by: Benjamin Herrenschmidt <email address hidden>
> Signed-off-by: Jeremy Kerr <email address hidden>
> Reported-By: Adam Conrad <email address hidden>
> Tested-By: Adam Conrad <email address hidden>
>
> Cherry-picked from upstream commit
> 78c5c68a4cf4329d17abfa469345ddf323d4fd62
>
> ---
>  arch/powerpc/platforms/powermac/smp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
> index 9b6a820..3394254 100644
> --- a/arch/powerpc/platforms/powermac/smp.c
> +++ b/arch/powerpc/platforms/powermac/smp.c
> @@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {
>
>  static void __init smp_psurge_setup_cpu(int cpu_nr)
>  {
> -       if (cpu_nr != 0)
> +       if (cpu_nr != 0 || !psurge_start)
>                return;
>
>        /* reset the entry point so if we get another intr we won't
>
> --
> kernel-team mailing list
> <email address hidden>
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Why not CC: lkml ?

It is on the stable channel ? Upstream link please ?
Now you understand Greg's concerns about maintaining a stable kernel ?

Hi Anca,

> Why not CC: lkml ?

Because it's already in mainline. Refer:

 > Cherry-picked from upstream commit
 > 78c5c68a4cf4329d17abfa469345ddf323d4fd62

Cheers,

Jeremy

Applied to Precise master-next.

Thanks,
Leann

On Tue, 2012-03-20 at 15:27 +0800, Jeremy Kerr wrote:
> From: Benjamin Herrenschmidt <email address hidden>
>
> BugLink: https://bugs.launchpad.net/bugs/959959
>
> The code for "powersurge" SMP would kick in and cause a crash
> at boot due to the lack of a NULL test.
>
> Signed-off-by: Benjamin Herrenschmidt <email address hidden>
> Signed-off-by: Jeremy Kerr <email address hidden>
> Reported-By: Adam Conrad <email address hidden>
> Tested-By: Adam Conrad <email address hidden>
>
> Cherry-picked from upstream commit
> 78c5c68a4cf4329d17abfa469345ddf323d4fd62
>
> ---
> arch/powerpc/platforms/powermac/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
> index 9b6a820..3394254 100644
> --- a/arch/powerpc/platforms/powermac/smp.c
> +++ b/arch/powerpc/platforms/powermac/smp.c
> @@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {
>
> static void __init smp_psurge_setup_cpu(int cpu_nr)
> {
> - if (cpu_nr != 0)
> + if (cpu_nr != 0 || !psurge_start)
> return;
>
> /* reset the entry point so if we get another intr we won't
>

This bug was fixed in the package linux - 3.2.0-19.31

---------------
linux (3.2.0-19.31) precise; urgency=low

  [ Stefan Bader ]

  * d-i: Add dm-multipath and scsi device handlers
    - LP: #959749
  * d-i: Move multipath modules into their own udeb
    - LP: #598251, #959749

  [ Tim Gardner ]

  * [Config] Auto-detect do_tools setting
  * [Config] correctly specify CROSS_COMPILE for tools build
  * [Config] CONFIG_DRM_PSB_CDV=n
  * Rebase to v3.2.12

  [ Upstream Kernel Changes ]

  * powerpc/pmac: Fix SMP kernels on pre-core99 UP machines
    - LP: #959959
  * rebase to v3.2.12
 -- Leann Ogasawara <email address hidden> Tue, 20 Mar 2012 09:11:26 -0700

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.