Keyboard navigation: no public API to know the current Laucher Icon selected when key nav is activated
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity |
Fix Released
|
Undecided
|
Alejandro Piñeiro | ||
| unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
When you press Alt+F1 it is stated the key nav mode on the Launcher
Internally it maintains a variable called _current_
My idea was an API like this:
LauncherIcon* GetSelectedMenuIcon
That would return NULL if the Launcher is not on key nav mode, and the specific launcher icon pointed by that index otherwise.
I was willing to start to create that, but I found this method on Launcher.h:
LauncherIcon* GetActiveMenuIcon() {return m_ActiveMenuIcon;}
m_ActiveMenuIcon is never updated on the code, and as it doesn't have documentation at all, I don't know the real purpose of this method.
So:
* Should I just add that new method?
* Should I use that method in order to return the information I want?
About why I need it:
* From the a11y POV the easiest way to give support to this key support is use AtkSelection
* As the launcher accessible object is implemented in other object, it would require to ask Launcher about the item selected
* In the same way, each LauncherIcon should update properly his state, specifically ATK_STATE_SELECTED. So it should require a way to ask the Launcher if he is selected or not.
Related branches
- Mirco Müller (community): Approve
- Rodrigo Moya (community): Approve
-
Diff: 640 lines (+392/-3)9 files modifiedsrc/Launcher.cpp (+22/-0)
src/Launcher.h (+3/-0)
src/LauncherIcon.h (+2/-0)
src/unity-launcher-accessible.cpp (+171/-1)
src/unity-launcher-accessible.h (+4/-0)
src/unity-launcher-icon-accessible.cpp (+129/-1)
src/unity-launcher-icon-accessible.h (+4/-0)
src/unity-root-accessible.cpp (+1/-1)
src/unitya11y.cpp (+56/-0)
| Alejandro Piñeiro (apinheiro) wrote | #1 |
| Changed in unity: | |
| assignee: | nobody → Alejandro Piñeiro (apinheiro) |
| Changed in unity: | |
| status: | New → Confirmed |
| Changed in unity (Ubuntu): | |
| status: | New → Triaged |
| Changed in unity: | |
| status: | Confirmed → Triaged |
| Changed in unity: | |
| status: | Triaged → In Progress |
| Changed in unity (Ubuntu): | |
| status: | Triaged → In Progress |
| Alejandro Piñeiro (apinheiro) wrote | #2 |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Changed in unity: | |
| milestone: | none → 3.6 |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Released |
After a brief chat with Jay, we concluded that it would be better to add a new method, GetSelectedMenu
I will assign the bug to myself, as it seems easy enough to be done by myself as part of the accessibility support.