Lots of country names are missing, showing "missing from libgweather" in mobile broadband connection wizard.

Country names come from libgweather country database. libgweather is missing the names for your locale. The way to fix this is to add the missing translations to libgweather. Marking this bug invalid.

According with this, I set libgweather as package affected.

What's your locale, btw?

I can reproduce this ...
I am in South Africa and using Vodacom when doing the setup
Distribution Jaunty Jackalope Alpha 5

My locale is it_IT.

But I try to explain better the bug.

This is what I see on wizard screen:

au | Australia
be | Belgium
br | Brazil
ca | Canada
ch | China
de | Germany

Then, from "ae" to "za" there is "missing from libgweather" instead of Country names.

ae | missing from libgweather
al | missing from libgweather
ar | missing from libgweather
...
...
za | missing from libgweather

And then the last three are correct:

mx | Mexico
gb | United Kingdom
us | United States

Wait, you see these exactly like that? i.e. in English?

no, I see that in Italian "Mancante da libgweather", I wrote it in English
for clarity.

But of course that is not the point.

2009/3/6 Antti Kaijanmäki <email address hidden>

> Wait, you see these exactly like that? i.e. in English?
>
> --
> Lots of country names are missing, showing "missing from libgweather" in
> mobile broadband connection wizard.
> https://bugs.launchpad.net/bugs/334377
> You received this bug notification because you are a direct subscriber
> of the bug.
>

== Regression details ==
Discovered in version: Jaunty Jackalope 9.04 development release
Last known good version: Intrepid Ibex 8.10

Hey,

As long as the countries correctly appear in the clock applet (when you
select a location), it's really likely that's it's not a bug in
libgweather.

I can't test Ubuntu right now, but I've been told the clock applet is
fine... so I don't think it's a libgweather bug. The data is available.

(I don't know anything about the mobile broadband connection wizard,
fwiw)

Vincent

--
Les gens heureux ne sont pas pressés.

that's not a libgweather bug

According with last comments I'm reopening for libmbca

OK, I finally got my jaunty installation working and was able to investigate this. Fixing this needs a change in libmbca. It's not going to big, but I'm not yet sure how to fix this properly and I don't have time to work on this in at least couple of weeks..

The problem lays in http://svn.gnome.org/viewvc/libmbca/trunk/src/provider_thread.c?view=markup where the assistant tries to find country names based on country codes from libgweather database. The format changed with libgweather 2.23.6 and I hoped it would be stable from there on, but now it seems that the format is back what it used to be as the old code works on jaunty.

After the name search is fixed there's a little translation related change required. Apparently debian has patched libgweather package to remove the translations from .xml file and to put them in gettext .mo's instead.

For future releases libmbca could use resources from iso-codes package and wouldn't need libgweather anymore, but that change is too big for jaunty.

== Regression details ==
Discovered in version: Jaunty Jackalope 9.04 Alpha 6
Last known good version: Intrepid Ibex 8.10

@Steve

mmhh.. I think this bug should be considered at least as a "High" importance
because of its high impact on configuring mobile broadband access.

Generally people doesn't know what is their country code (since the name of
the country is not showed).

About 85/90 % of country names are missing, so it affects a lot of people
world-wide.

This prevents people from configuring their mobile broadband connection.

2009/3/23 Steve Beattie <email address hidden>

> ** Changed in: libmbca (Ubuntu)
> Importance: Undecided => Low
> Assignee: (unassigned) => Ubuntu Desktop Bugs (desktop-bugs)
>
> --
> Lots of country names are missing, showing "missing from libgweather" in
> mobile broadband connection wizard.
> https://bugs.launchpad.net/bugs/334377
> You received this bug notification because you are a direct subscriber
> of the bug.
>

not sure what libmbca is but the desktop team is not working on it

@Sebastien

It should be the library of mobile broadband connection.

This bug affects the wizard that help a user creating a new mobile broadband
connection.
It has an high impact on the desktop itself.

2009/3/23 Sebastien Bacher <email address hidden>

> not sure what libmbca is but the desktop team is not working on it
>
> ** Changed in: libmbca (Ubuntu)
> Assignee: Ubuntu Desktop Bugs (desktop-bugs) => (unassigned)
>
> --
> Lots of country names are missing, showing "missing from libgweather" in
> mobile broadband connection wizard.
> https://bugs.launchpad.net/bugs/334377
> You received this bug notification because you are a direct subscriber
> of the bug.
>

It seems to me that libmbca should fall back to the "C" country name if no translated country name exists, instead of showing "missing from libgweather" (which is not helpful at all). Antti, would you have time to work on this?

Actually I don't have time to work on this right now, but it seems that I have to as it seems no one else is going to do it. I know this is really important and I really want to get this fixed.

"missing from libgweather" is intended to make it clear for testers that libgweather is missing translations so that they can be added before a new release, but that's now irrelevant. I described the problem causing this bug on 2009-03-07. I'll do my best to get this fixed before FinalFreeze on 9.4.

And yes, please, bump the Importance to "High". I don't seem to have the permissions to do that myself.

> For future releases libmbca could use resources from iso-codes package and wouldn't need libgweather anymore, but that change is too big for jaunty.

What about enabling old, "LIBGWEATHER_PRIOR_2_23_6" code? The following patch has worked for me.

--- libmbca-0.0.3~bzr42.orig/src/provider_thread.c
+++ libmbca-0.0.3~bzr42/src/provider_thread.c
@@ -32,7 +32,7 @@
 #include "gnome-panel/system-timezone.h"

-#ifdef LIBGWEATHER_PRIOR_2_23_6
+#if 1
 /**
  * ret must be freed
  */

yes, that's almost exactly all that's needed. There's another #ifndef in that file, too, and then there's a new dgettext () call needed where the country names are added to the visible list.

Thanks Antti

BTW, libgweather-common package doesn't contain any mo file:

$ aptitude download libgweather-common && dpkg -c libgweather-common*.deb | grep -c \\.mo$
0

while

$ apt-get source libgweather-common && cd libgweather-2.26.0 && debuild && \
dpkg -c ../libgweather-common*.deb | grep -c \\.mo$
176

In other words, local rebuild of libgweather adds translated messages to the package.

Sorry, my fault. language-pack-gnome-$lang-base packages contain mo files.

Anyway, attached is a patch, which worked for me. Now I can see most of the countries in the list and they are localized. :)

thanks for your interest, but I already prepared a more detailed patch this morning which removes the broken code and uses g_dgettext. I will prepare a new package today or tomorrow.

Great! Thanks a lot.

bzr commit -m '* fix LP: #334377 - Lots of country names are missing, showing "missing from
  libgweather" in mobile broadband connection wizard.
  - add debian/patches/lp334377_debian_libgweather_breakage.patch' --fixes 'lp:334377' 'debian/patches/' 'debian/changelog'
Committing to: bzr+ssh://<email address hidden>/~network-manager/libmbca/libmbca.ubuntu/
modified debian/changelog
added debian/patches
added debian/patches/lp334377_debian_libgweather_breakage.patch
Committed revision 49.

This bug was fixed in the package libmbca - 0.0.4+bzr66-0ubuntu1

---------------
libmbca (0.0.4+bzr66-0ubuntu1) jaunty; urgency=low

  * new 0.0.4 upstream snapshot (bzr66)
    - fix LP: #290625 - New CDMA entries added as GSM
  * add hardy intltool-*in templates (intltoolize -f -c)
    - add intltool-extract.in
    - add intltool-merge.in
    - add intltool-update.in
  * fix LP: #334377 - Lots of country names are missing, showing "missing from
    libgweather" in mobile broadband connection wizard.
    - add debian/patches/lp334377_debian_libgweather_breakage.patch
  * fix LP: #291226 - libmbca doesn't use LP translations; we run intltool-update
    in debian/rules in common-build-arch:: and cleanup generated files in clean::
    - update dbian/rules

 -- Alexander Sack <email address hidden> Mon, 30 Mar 2009 14:08:59 +0200

Verified. Works like a charm. Thanks a lot!