Ubuntu
webbrowser-app package

webbrowser_app.tests.test_new_tab_view.TestNewTabViewContentsWide.test_drag_bookmarks fails on desktop

Bug #1584868 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
webbrowser-app (Ubuntu)
Fix Released
Medium
Olivier Tilloy

Bug Description

The following autopilot test started failing recently on desktop (X11):

    webbrowser_app.tests.test_new_tab_view.TestNewTabViewContentsWide.test_drag_bookmarks

It’s not just the test failing: I can reliably reproduce the issue in the app itself, dragging a bookmark in the new tab view within the list it belongs to and dropping it anywhere, the delegate remains where it was dropped.

Related branches

lp:~osomon/webbrowser-app/fix-dnd-bookmarks-newtabview
Andrew Hayzen (community): Approve
Ubuntu Phablet Team: Pending requested
Diff: 32 lines (+2/-9)
2 files modified
src/app/webbrowser/TabComponent.qml (+1/-1)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+1/-8)
lp:~ci-train-bot/webbrowser-app/webbrowser-app-ubuntu-zesty-2087
Revision history for this message
Olivier Tilloy (osomon) wrote :

The same functionality (dragging a bookmark within its listview and dropping it makes it bounce back to its original position) works in the wide bookmarks view, so the problem is specific to the new tab view.

Revision history for this message
Olivier Tilloy (osomon) wrote :

It appears the invisible webview below the new tab view is in fact above it, thus preventing the drag events from functioning correctly.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Correction: the z-order is correct (i.e. the new tab view is above the webview), but the webview seems to be swallowing the drag events anyway.

Changed in webbrowser-app (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Olivier Tilloy (osomon)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+17.04.20161024.1-0ubuntu1

---------------
webbrowser-app (0.23+17.04.20161024.1-0ubuntu1) zesty; urgency=medium

  [ Andrew Hayzen ]
  * Fix for issue where many tabs causes close button to overlap other
    tabs (LP: #1473630)
  * When page has started, stopped, redirected or errored clear cache for
    history update - which prevents incorrect titles in being set
    (LP: #1603835)
  * Add autopilot tests javascript dialogs to webbrowser and
    webapp-container - alertDialog, beforeUnloadDialog, confirmDialog and
    promptDialog (LP: #1633040)
  * Add user-agent override to display the new twitter mobile interface
    (LP: #1577834)

  [ Florian Boucault ]
  * Improved startup time by 800ms by delaying QML compilation and making
    it asynchronous

  [ Olivier Tilloy ]
  * Replace chromium version in UA overrides at runtime, not at build
    time (LP: #1599695)
  * Initial support for generating a snap package for webbrowser-app
    (LP: #1629009)
  * Do not persist references to incognito downloads on disk
    (LP: #1625519)
  * Increase test coverage (to 97.5%) for DownloadsModel (LP: #1534102)
  * Various performance optimizations linked to load events
    (LP: #1611680)
  * Ensure a tab is loaded when re-opened (LP: #1632246)
  * Fix drag'n'drop of bookmarks within the new tab view (LP: #1584868)
  * Work around a limitation in the sound and microphone policy groups
    to "fix" sound in yakkety an zesty (LP: #1632620)

 -- Olivier Tilloy <email address hidden> Mon, 24 Oct 2016 13:51:59 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.