Ubuntu
webbrowser-app package

Test coverage for the DownloadsModel C++ class is incomplete

Bug #1534102 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
webbrowser-app (Ubuntu)
Fix Released
Medium
Olivier Tilloy

Bug Description

(originally reported in bug #1528651)

As of 2016-01-14, line coverage is at 64.3% and functions coverage is at 68.0%.

In particular, the following methods are completely untested:

DownloadsModel::setPath(…)
DownloadsModel::setError(…)
DownloadsModel::moveToDownloads(…)
DownloadsModel::deleteDownload(…)
DownloadsModel::pauseDownload(…)
DownloadsModel::resumeDownload(…)
DownloadsModel::removeExistingEntryFromDatabase(…)
DownloadsModel::canFetchMore(…)

See original description

Related branches

lp:~osomon/webbrowser-app/private-downloads
Michael Sheldon (community): Approve
system-apps-ci-bot: Needs Fixing (continuous-integration)
Diff: 1317 lines (+597/-297)
9 files modified
src/app/Downloader.qml (+3/-11)
src/app/WebViewImpl.qml (+2/-2)
src/app/webbrowser/Browser.qml (+9/-1)
src/app/webbrowser/DownloadDelegate.qml (+151/-149)
src/app/webbrowser/DownloadsPage.qml (+10/-2)
src/app/webbrowser/downloads-model.cpp (+139/-80)
src/app/webbrowser/downloads-model.h (+7/-9)
src/app/webbrowser/webbrowser-app.qml (+14/-0)
tests/unittests/downloads-model/tst_DownloadsModelTests.cpp (+262/-43)
lp:~ci-train-bot/webbrowser-app/webbrowser-app-ubuntu-zesty-2087
Olivier Tilloy (osomon)
description: updated
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
assignee: Michael Sheldon (michael-sheldon) → Olivier Tilloy (osomon)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+17.04.20161024.1-0ubuntu1

---------------
webbrowser-app (0.23+17.04.20161024.1-0ubuntu1) zesty; urgency=medium

  [ Andrew Hayzen ]
  * Fix for issue where many tabs causes close button to overlap other
    tabs (LP: #1473630)
  * When page has started, stopped, redirected or errored clear cache for
    history update - which prevents incorrect titles in being set
    (LP: #1603835)
  * Add autopilot tests javascript dialogs to webbrowser and
    webapp-container - alertDialog, beforeUnloadDialog, confirmDialog and
    promptDialog (LP: #1633040)
  * Add user-agent override to display the new twitter mobile interface
    (LP: #1577834)

  [ Florian Boucault ]
  * Improved startup time by 800ms by delaying QML compilation and making
    it asynchronous

  [ Olivier Tilloy ]
  * Replace chromium version in UA overrides at runtime, not at build
    time (LP: #1599695)
  * Initial support for generating a snap package for webbrowser-app
    (LP: #1629009)
  * Do not persist references to incognito downloads on disk
    (LP: #1625519)
  * Increase test coverage (to 97.5%) for DownloadsModel (LP: #1534102)
  * Various performance optimizations linked to load events
    (LP: #1611680)
  * Ensure a tab is loaded when re-opened (LP: #1632246)
  * Fix drag'n'drop of bookmarks within the new tab view (LP: #1584868)
  * Work around a limitation in the sound and microphone policy groups
    to "fix" sound in yakkety an zesty (LP: #1632620)

 -- Olivier Tilloy <email address hidden> Mon, 24 Oct 2016 13:51:59 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.