Sometimes url and description of the url do not match in the address bar

Bug #1603835 reported by Victor Gabillon
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
webbrowser-app (Ubuntu)
Fix Released
High
Andrew Hayzen

Bug Description

In the webbrowser, when entering an address url of a website in the address bar, a list of similar webpages is provided below by auto-completion. The list is composed of url with a description of the address.
But sometimes (and quite randomly it seems) the url address and the description do not match at all.

Guess: It seems to happen with websites that I had removed from the history.
Actually, a website that has been suppressed from the history should not appear in the url list no?

Mx4 Ota 11 stable

Related branches

description: updated
Revision history for this message
Olivier Tilloy (osomon) wrote :

It’s not happening with websites that were removed from the history. It’s a regression that I think was introduced with the fix for bug #1455858. Some entries in the history database appear to be stored with the title from the previous page in the navigation history. I haven’t been able to reliably reproduce the issue yet, although I have definitely seen it happening.

Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Olivier Tilloy (osomon)
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
assignee: Olivier Tilloy (osomon) → Andrew Hayzen (ahayzen)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

When the user requests a page this starts a request in the webview, then once this has completed a loadEvent is fired [0]. This load event adds a history entry with url and current title (the url) [1] and stores the url in an internal cache [2]. The normally when a page has finished rendering the title changes [3], which updates the history entry with the new title and blocks any future updates.

However if you start a request to another page while loading a slow page and the title has not changed. Then the onTitleChanged [3] code is triggered before the loadEvent [0] as the title is updated to the new request url. But because of the cached url [2] it updates the wrong history entry.

I've found a reproducible way of doing this on my machine. Navigate to [4]. Click on one of the entries, such as Firewatch [5]. Now as the page is loading quickly navigate to google.com. If you were fast enough, when you type "Firewatch" into the address bar you get a title of "google.com" and a url of "store.playstation.com/..."

So to resolve this issue when a new page is requested, the cache needs to be unset or the code in onTitleChanged needs to be blocked.

0 - http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/Browser.qml#L1237
1 - http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/Browser.qml#L1252
2 - http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/Browser.qml#L1231
3 - http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/Browser.qml#L1255
4 - http://www.thesixthaxis.com/2016/10/05/the-october-savings-sale-for-the-ps-store-is-now-live/
5 - https://store.playstation.com/#!/cid=EP0144-CUSA04118_00-FIREWATCH0000000?smcid=psblog:en:October savings start today on PlayStation Store, inc. Uncharted 4, Just Cause 3, moreFirewatch

Andrew Hayzen (ahayzen)
Changed in webbrowser-app (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+17.04.20161024.1-0ubuntu1

---------------
webbrowser-app (0.23+17.04.20161024.1-0ubuntu1) zesty; urgency=medium

  [ Andrew Hayzen ]
  * Fix for issue where many tabs causes close button to overlap other
    tabs (LP: #1473630)
  * When page has started, stopped, redirected or errored clear cache for
    history update - which prevents incorrect titles in being set
    (LP: #1603835)
  * Add autopilot tests javascript dialogs to webbrowser and
    webapp-container - alertDialog, beforeUnloadDialog, confirmDialog and
    promptDialog (LP: #1633040)
  * Add user-agent override to display the new twitter mobile interface
    (LP: #1577834)

  [ Florian Boucault ]
  * Improved startup time by 800ms by delaying QML compilation and making
    it asynchronous

  [ Olivier Tilloy ]
  * Replace chromium version in UA overrides at runtime, not at build
    time (LP: #1599695)
  * Initial support for generating a snap package for webbrowser-app
    (LP: #1629009)
  * Do not persist references to incognito downloads on disk
    (LP: #1625519)
  * Increase test coverage (to 97.5%) for DownloadsModel (LP: #1534102)
  * Various performance optimizations linked to load events
    (LP: #1611680)
  * Ensure a tab is loaded when re-opened (LP: #1632246)
  * Fix drag'n'drop of bookmarks within the new tab view (LP: #1584868)
  * Work around a limitation in the sound and microphone policy groups
    to "fix" sound in yakkety an zesty (LP: #1632620)

 -- Olivier Tilloy <email address hidden> Mon, 24 Oct 2016 13:51:59 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Victor Gabillon (victorgabillon) wrote :

Great! Thanks a lot for your work! :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.