ubuntu-download-manager

Network error during group download leaves cruft

Bug #1229413 reported by Barry Warsaw on 2013-09-23

6

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	ubuntu-download-manager	Fix Released	Critical	Unassigned
	ubuntu-download-manager (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

Let's say you create a group download with 5 files. 4 of the files exist and one does not. Clients will properly get NETWORK ERROR on the missing file, but the group download will continue to proceed (as evidenced by debug logging of the d/l service), and the other 4 files will *not* be deleted from the destination path, as expected and documented.

Try the attached example. In this case http://system-image.ubuntu.com/no-such-file.txt is the missing file.

Related branches

lp:~mandel/ubuntu-download-manager/handle-error-correctly

Merged into lp:ubuntu-download-manager at revision 135

Barry Warsaw (community): Approve on 2013-09-24

PS Jenkins bot: Approve (continuous-integration) on 2013-09-24

Diego Sarmentero (community): Approve on 2013-09-24

lp:ubuntu/saucy-proposed/ubuntu-download-manager

Revision history for this message

Barry Warsaw (barry) wrote on 2013-09-23:

#1

example.py Edit (4.2 KiB, text/x-python)

Revision history for this message

Barry Warsaw (barry) wrote on 2013-09-23:

#2

I should mention that while I think I can work around this, this should be considered critical before we can release things.

Revision history for this message

Barry Warsaw (barry) wrote on 2013-09-23:

#3

This is a weird one. As shown by the above example (reproducible every time, and it shows up in another system-image test case), it doesn't happen *all* the time. I have another test case where after a 404, the local files don't exist. I don't understand what's going on, or why they'd be different.

Revision history for this message

Manuel de la Peña (mandel) wrote on 2013-09-24:

#4

No problem, I know how to fix this!! Right on it!

Changed in ubuntu-download-manager:
status:	New → In Progress
importance:	Undecided → Critical

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-24:

#5

Fix committed into lp:ubuntu-download-manager at revision 135, scheduled for release in ubuntu-download-manager, milestone 0.3

Changed in ubuntu-download-manager:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-09-25:

#6

This bug was fixed in the package ubuntu-download-manager - 0.2+13.10.20130924.2-0ubuntu1

---------------
ubuntu-download-manager (0.2+13.10.20130924.2-0ubuntu1) saucy; urgency=low

  [ Manuel de la Pena ]
  * Ensure that when there is a network error the state of the
    GroupDownload is correctly set. (LP: #1227850, #1227907, #1218031)
  * Provide system dbus API to be used by apps such as the image
    updates. (LP: #1211486)
  * Provide new arg and new method to simplify tests. (LP: #1228233)
  * Ensure that all downloads are canceled and that the files are
    correctly removed. (LP: #1229413)

[ Ubuntu daily release ]
* Automatic snapshot from revision 135
-- Ubuntu daily release <email address hidden> Tue, 24 Sep 2013 22:03:24 +0000

Changed in ubuntu-download-manager (Ubuntu):
status:	New → Fix Released

Manuel de la Peña (mandel) on 2013-09-25

Changed in ubuntu-download-manager:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

example.py Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.