Zmq raises timeout on cast() if no topic consumers

Bug #1186310 reported by Erica Windisch
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Low
Li Ma
oslo.messaging (Ubuntu)
Fix Released
High
Unassigned
Vivid
Fix Released
High
Unassigned

Bug Description

The RpcTimeout exception is raised if the matchmaker cannot find any consumers for a topic. This is common if there are no consumers.

While this might be legitimate and even expected for call(), it seems likely that delivery failures should be ignored for cast().

There is at least one case in Nova where a cast is made and does not catch this Timeout exception.

Discovered by Joe Gordon

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/31231

Changed in oslo:
assignee: nobody → Eric Windisch (ewindisch)
status: New → In Progress
description: updated
Mark McLoughlin (markmc)
affects: oslo → oslo.messaging
Changed in oslo.messaging:
importance: Undecided → Low
status: In Progress → Triaged
assignee: Eric Windisch (ewindisch) → nobody
Mark McLoughlin (markmc)
tags: added: zmq
Li Ma (nick-ma-z)
Changed in oslo.messaging:
assignee: nobody → Li Ma (nick-ma-z)
Li Ma (nick-ma-z)
Changed in oslo.messaging:
assignee: Li Ma (nick-ma-z) → nobody
Li Ma (nick-ma-z)
Changed in oslo.messaging:
assignee: nobody → Li Ma (nick-ma-z)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165879

Changed in oslo.messaging:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/165879
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=f033fc9436b6f3bc924f19e1457b3cbc85ea548a
Submitter: Jenkins
Branch: master

commit f033fc9436b6f3bc924f19e1457b3cbc85ea548a
Author: Li Ma <email address hidden>
Date: Thu Mar 19 00:32:01 2015 -0700

    Don't raise Timeout on no-matchmaker results

    This patch was proposed by this review:
    https://review.openstack.org/#/c/31231

    The unit test is added.

    Change-Id: Ie124dc22f4ef3bbaeed76186cf08924a39b52812
    Co-Authored-By: Eric Windisch <email address hidden>
    Closes-Bug: #1186310

Changed in oslo.messaging:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/172061

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (stable/kilo)

Reviewed: https://review.openstack.org/172061
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=513b1c9f3b4727f99f5d637aadb37f3710a8e7d6
Submitter: Jenkins
Branch: stable/kilo

commit 513b1c9f3b4727f99f5d637aadb37f3710a8e7d6
Author: Li Ma <email address hidden>
Date: Thu Mar 19 00:32:01 2015 -0700

    Don't raise Timeout on no-matchmaker results

    This patch was proposed by this review:
    https://review.openstack.org/#/c/31231

    The unit test is added.

    Change-Id: Ie124dc22f4ef3bbaeed76186cf08924a39b52812
    Co-Authored-By: Eric Windisch <email address hidden>
    Closes-Bug: #1186310
    (cherry picked from commit f033fc9436b6f3bc924f19e1457b3cbc85ea548a)

tags: added: in-stable-kilo
Changed in oslo.messaging:
milestone: none → 1.10.0
status: Fix Committed → Fix Released
James Page (james-page)
Changed in oslo.messaging (Ubuntu Wily):
status: New → Fix Released
Changed in oslo.messaging (Ubuntu Vivid):
status: New → Triaged
importance: Undecided → High
Changed in oslo.messaging (Ubuntu Wily):
importance: Undecided → High
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Eric, or anyone else affected,

Accepted oslo.messaging into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oslo.messaging/1.8.3-0ubuntu0.15.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in oslo.messaging (Ubuntu Vivid):
status: Triaged → Fix Committed
tags: added: verification-needed
James Page (james-page)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package oslo.messaging - 1.8.3-0ubuntu0.15.04.1

---------------
oslo.messaging (1.8.3-0ubuntu0.15.04.1) vivid; urgency=medium

  * New upstream point release (LP: #1467959):
    - RabbitMQ driver:
      + Adding publisher acknowledgements/confirms for better handling
        of messages during broker shutdown/network failure.
      + Ensure consumer connections closed properly (LP: #1458917).
      + Set timeout on the underlying socket (LP: #1436788).
      + Disable and mark heartbeat as experimental (LP: #1436769).
      + Fix ipv6 support.
    - ZeroMQ driver:
      + Don't raise Timeout on no-matchmaker results (LP: #1186310).
      + Fix issue with Redis not deleting expired keys (LP: #1417464).
      + d/p/Fix-changing-keys-during-iteration-in-matchmaker-hea.patch,
        d/p/Add-pluggability-for-matchmakers.patch: Dropped, included
        upstream.

 -- James Page <email address hidden> Tue, 23 Jun 2015 15:28:01 +0100

Changed in oslo.messaging (Ubuntu Vivid):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for oslo.messaging has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Eric, or anyone else affected,

Accepted oslo.messaging into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oslo.messaging/1.8.3-0ubuntu0.15.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
James Page (james-page)
tags: added: verification-done
removed: verification-needed
Mathew Hodson (mhodson)
no longer affects: oslo.messaging (Ubuntu Wily)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.